Re: [PR] Prepare for Doxia 2.0.0 [maven-javadoc-plugin]

2023-12-13 Thread via GitHub
kriegaex commented on PR #204: URL: https://github.com/apache/maven-javadoc-plugin/pull/204#issuecomment-1853641129 > The reason you see both `reports/` _and_ `site/` is that some ITs use standalone invocation and others site invocation. I know that. You misread my comment. But befor

Re: [PR] Prepare for Doxia 2.0.0 [maven-javadoc-plugin]

2023-12-13 Thread via GitHub
michael-o commented on PR #204: URL: https://github.com/apache/maven-javadoc-plugin/pull/204#issuecomment-1853621439 > LGTM. > > First, I opened [c79769a](https://github.com/apache/maven-javadoc-plugin/commit/c79769afdff432edc956ce665df995d78d735dd6) and was confused after you just

Re: [PR] Prepare for Doxia 2.0.0 [maven-javadoc-plugin]

2023-12-10 Thread via GitHub
kriegaex commented on PR #204: URL: https://github.com/apache/maven-javadoc-plugin/pull/204#issuecomment-1849146890 LGTM. First, I opened c79769afdff432edc956ce665df995d78d735dd6 and was confused after you just merged https://github.com/apache/maven-reporting-impl/pull/26, seeing lo

Re: [PR] Prepare for Doxia 2.0.0 [maven-javadoc-plugin]

2023-11-21 Thread via GitHub
kriegaex commented on PR #204: URL: https://github.com/apache/maven-javadoc-plugin/pull/204#issuecomment-1821952458 > All other plugins with subdirs have fixed names, you can only control the output directory That might be so. I neither know nor use all plugins. But at least, for Ja

Re: [PR] Prepare for Doxia 2.0.0 [maven-javadoc-plugin]

2023-11-19 Thread via GitHub
kriegaex commented on PR #204: URL: https://github.com/apache/maven-javadoc-plugin/pull/204#issuecomment-1818179659 @michael-o, I am quite busy and only took a quick glance at the changes. But to me it seems as if before, you could override the default directory inclusing the "apidocs" par

Re: [PR] Prepare for Doxia 2.0.0 [maven-javadoc-plugin]

2023-11-19 Thread via GitHub
michael-o commented on PR #204: URL: https://github.com/apache/maven-javadoc-plugin/pull/204#issuecomment-1817828979 @kriegaex Have a look at the second commit. It is a prototype how to align this plugin with the behavior of Maven Reporting Impl. Down the path I have found a few bugs I nee