Re: [PR] Prefer Guice constructor injection [maven-gpg-plugin]

2024-12-18 Thread via GitHub
elharo merged PR #126: URL: https://github.com/apache/maven-gpg-plugin/pull/126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven

Re: [PR] Prefer Guice constructor injection [maven-gpg-plugin]

2024-12-18 Thread via GitHub
elharo commented on code in PR #126: URL: https://github.com/apache/maven-gpg-plugin/pull/126#discussion_r1890142496 ## src/main/java/org/apache/maven/plugins/gpg/SignDeployedMojo.java: ## @@ -106,11 +105,15 @@ public class SignDeployedMojo extends AbstractGpgMojo { @Parame

Re: [PR] Prefer Guice constructor injection [maven-gpg-plugin]

2024-12-17 Thread via GitHub
slachiewicz commented on code in PR #126: URL: https://github.com/apache/maven-gpg-plugin/pull/126#discussion_r1889354050 ## src/main/java/org/apache/maven/plugins/gpg/SignDeployedMojo.java: ## @@ -106,11 +105,15 @@ public class SignDeployedMojo extends AbstractGpgMojo { @P

Re: [PR] Prefer Guice constructor injection [maven-gpg-plugin]

2024-12-14 Thread via GitHub
elharo commented on code in PR #126: URL: https://github.com/apache/maven-gpg-plugin/pull/126#discussion_r1885430747 ## src/main/java/org/apache/maven/plugins/gpg/SignDeployedMojo.java: ## @@ -106,11 +105,15 @@ public class SignDeployedMojo extends AbstractGpgMojo { @Parame

Re: [PR] Prefer Guice constructor injection [maven-gpg-plugin]

2024-12-14 Thread via GitHub
slachiewicz commented on code in PR #126: URL: https://github.com/apache/maven-gpg-plugin/pull/126#discussion_r1885408565 ## src/main/java/org/apache/maven/plugins/gpg/SignDeployedMojo.java: ## @@ -106,11 +105,15 @@ public class SignDeployedMojo extends AbstractGpgMojo { @P