Re: [PR] Null implementations shall return null [maven-resolver]

2024-06-13 Thread via GitHub
cstamas commented on PR #113: URL: https://github.com/apache/maven-resolver/pull/113#issuecomment-2165382262 Superseded by https://github.com/apache/maven-resolver/pull/503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Null implementations shall return null [maven-resolver]

2024-06-13 Thread via GitHub
cstamas closed pull request #113: Null implementations shall return null URL: https://github.com/apache/maven-resolver/pull/113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Null implementations shall return null [maven-resolver]

2024-06-05 Thread via GitHub
cstamas commented on PR #113: URL: https://github.com/apache/maven-resolver/pull/113#issuecomment-2149944881 Created https://issues.apache.org/jira/browse/MRESOLVER-565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Null implementations shall return null [maven-resolver]

2024-06-05 Thread via GitHub
michael-o commented on PR #113: URL: https://github.com/apache/maven-resolver/pull/113#issuecomment-2149841456 Would you rename them for 2.0.0? That feels natural... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Null implementations shall return null [maven-resolver]

2024-06-05 Thread via GitHub
cstamas commented on PR #113: URL: https://github.com/apache/maven-resolver/pull/113#issuecomment-2149139709 I think the classes are named badly. These "default" (and not "null") selectors are meant to not interfere with already equipped repositories. In short, you know that when you

Re: [PR] Null implementations shall return null [maven-resolver]

2024-06-04 Thread via GitHub
michael-o commented on PR #113: URL: https://github.com/apache/maven-resolver/pull/113#issuecomment-2148078591 @cstamas What is your opinion, does this make sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR