elharo merged PR #2126:
URL: https://github.com/apache/maven/pull/2126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o
elharo commented on PR #2126:
URL: https://github.com/apache/maven/pull/2126#issuecomment-2701851418
Might have a flkay test since this failed on only one build in this doc only
PR:
Error: Errors:
Error:
MavenITmng5640LifecycleParticipantAfterSessionEnd.testBuildFailureUTFail
elharo commented on code in PR #2126:
URL: https://github.com/apache/maven/pull/2126#discussion_r1981528480
##
compat/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java:
##
@@ -36,25 +36,25 @@
*
* Features:
*
- * mixing of '-' (hyphe
gnodet commented on code in PR #2126:
URL: https://github.com/apache/maven/pull/2126#discussion_r1981449833
##
compat/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java:
##
@@ -36,25 +36,25 @@
*
* Features:
*
- * mixing of '-' (hyphe
elharo commented on code in PR #2126:
URL: https://github.com/apache/maven/pull/2126#discussion_r1981319875
##
compat/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java:
##
@@ -36,25 +36,25 @@
*
* Features:
*
- * mixing of '-' (hyphe
gnodet commented on code in PR #2126:
URL: https://github.com/apache/maven/pull/2126#discussion_r1978102841
##
compat/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java:
##
@@ -36,25 +36,25 @@
*
* Features:
*
- * mixing of '-' (hyphe
gnodet commented on code in PR #2126:
URL: https://github.com/apache/maven/pull/2126#discussion_r1975375521
##
compat/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java:
##
@@ -36,25 +36,25 @@
*
* Features:
*
- * mixing of '-' (hyphe
gnodet commented on PR #2126:
URL: https://github.com/apache/maven/pull/2126#issuecomment-2690587229
> One more time: ComparableVersion is used by third party, non-Maven code
and has direct usages as well (i.e. not as a library but as a program in its
own right). Furthermore, there's at lea
elharo commented on PR #2126:
URL: https://github.com/apache/maven/pull/2126#issuecomment-2690548577
One more time: ComparableVersion is used by third party, non-Maven code and
has direct usages as well (i.e. not as a library but as a program in its own
right). Furthermore, there's at least
cstamas commented on PR #2126:
URL: https://github.com/apache/maven/pull/2126#issuecomment-2685777874
Right, we demoted it to "compat" (with Maven 3) libraries, probably
deprecated it as well (or will soon). Noting in Maven uses these classes
anymore.
OTOH. by not "just leaving" thes
elharo commented on PR #2126:
URL: https://github.com/apache/maven/pull/2126#issuecomment-2683367555
Also worth noting: ComparableVersion is public API used by code that is not
in Maven and not part of a Maven plugin. We should not just abandon it.
--
This is an automated message from th
elharo commented on PR #2126:
URL: https://github.com/apache/maven/pull/2126#issuecomment-2683365783
I'm only editing the Javadoc here, and that can certainly be improved. It is
a little annoying that version comparison now exists in multiple places and
repos.
https://xkcd.com/927/
cstamas commented on PR #2126:
URL: https://github.com/apache/maven/pull/2126#issuecomment-2683300978
You are aware you are editing `compat` subproject? You know, a subproject
that should be left as is (ie. "frozen") and is there only for backward
compatibility reasons?
--
This is an aut
elharo opened a new pull request, #2126:
URL: https://github.com/apache/maven/pull/2126
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
14 matches
Mail list logo
