Re: [PR] Manage jacoco-maven-plugin [maven-apache-parent]

2025-01-10 Thread via GitHub
kwin commented on PR #284: URL: https://github.com/apache/maven-apache-parent/pull/284#issuecomment-2584030624 This whole PR will not add any execution of jacoco-m-p except if activated via profile. But I see that you don’t like it, therefore closing this. -- This is an automated message

Re: [PR] Manage jacoco-maven-plugin [maven-apache-parent]

2025-01-10 Thread via GitHub
kwin closed pull request #284: Manage jacoco-maven-plugin URL: https://github.com/apache/maven-apache-parent/pull/284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] Manage jacoco-maven-plugin [maven-apache-parent]

2025-01-10 Thread via GitHub
ctubbsii commented on PR #284: URL: https://github.com/apache/maven-apache-parent/pull/284#issuecomment-2583864816 > SonarQube is supported and encouraged by the ASF (https://infra.apache.org/build-supported-services.html#sonarcloud), Supported, yes. Encouraged... I don't know where

Re: [PR] Manage jacoco-maven-plugin [maven-apache-parent]

2025-01-02 Thread via GitHub
kwin commented on PR #284: URL: https://github.com/apache/maven-apache-parent/pull/284#issuecomment-2567735154 SonarQube is supported and encouraged by the ASF (https://infra.apache.org/build-supported-services.html#sonarcloud), and part of it is exposing [coverage metrics](https://docs.s

Re: [PR] Manage jacoco-maven-plugin [maven-apache-parent]

2024-12-27 Thread via GitHub
slawekjaranowski commented on PR #284: URL: https://github.com/apache/maven-apache-parent/pull/284#issuecomment-2563432423 I agree with @ctubbsii such configuration should be project specific ... no a global one. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Manage jacoco-maven-plugin [maven-apache-parent]

2024-12-21 Thread via GitHub
kwin commented on code in PR #284: URL: https://github.com/apache/maven-apache-parent/pull/284#discussion_r1894645523 ## pom.xml: ## @@ -517,6 +558,17 @@ under the License. + + coverage + + + +org.jacoco +

Re: [PR] Manage jacoco-maven-plugin [maven-apache-parent]

2024-12-21 Thread via GitHub
kwin commented on code in PR #284: URL: https://github.com/apache/maven-apache-parent/pull/284#discussion_r1894645080 ## pom.xml: ## @@ -517,6 +560,17 @@ under the License. + + coverage Review Comment: TODO: allow to activate via property? --

[PR] Manage jacoco-maven-plugin [maven-apache-parent]

2024-12-21 Thread via GitHub
kwin opened a new pull request, #284: URL: https://github.com/apache/maven-apache-parent/pull/284 Add dedicated profile "coverage" to generate separate reports for both UTs and ITs. This closes #283 -- This is an automated message from the Apache Git Service. To respond to the mess