Re: [PR] Make master 2.0.0-SNAPSHOT [maven-resolver]

2023-10-12 Thread via GitHub
gnodet commented on code in PR #335: URL: https://github.com/apache/maven-resolver/pull/335#discussion_r1357237735 ## pom.xml: ## @@ -85,18 +85,21 @@ 8 +${javaVersion} +${javaVersion} +${javaVersion} true ${surefire.redirectTestOutputToFile}

Re: [PR] Make master 2.0.0-SNAPSHOT [maven-resolver]

2023-10-12 Thread via GitHub
michael-o commented on code in PR #335: URL: https://github.com/apache/maven-resolver/pull/335#discussion_r1357144340 ## pom.xml: ## @@ -85,18 +85,21 @@ 8 +${javaVersion} +${javaVersion} +${javaVersion} true ${surefire.redirectTestOutputToFile}

Re: [PR] Make master 2.0.0-SNAPSHOT [maven-resolver]

2023-10-11 Thread via GitHub
gnodet commented on code in PR #335: URL: https://github.com/apache/maven-resolver/pull/335#discussion_r1355755751 ## Jenkinsfile: ## @@ -19,5 +19,5 @@ // Currently we can only build with JDK8+ based on the usage Review Comment: I think this comment now looks wrong. --

Re: [PR] Make master 2.0.0-SNAPSHOT [maven-resolver]

2023-10-11 Thread via GitHub
cstamas commented on code in PR #335: URL: https://github.com/apache/maven-resolver/pull/335#discussion_r1355576036 ## pom.xml: ## @@ -85,18 +85,21 @@ 8 +${javaVersion} +${javaVersion} +${javaVersion} true ${surefire.redirectTestOutputToFile}

Re: [PR] Make master 2.0.0-SNAPSHOT [maven-resolver]

2023-10-11 Thread via GitHub
cstamas commented on code in PR #335: URL: https://github.com/apache/maven-resolver/pull/335#discussion_r1355562042 ## pom.xml: ## @@ -85,18 +85,21 @@ 8 +${javaVersion} +${javaVersion} +${javaVersion} true ${surefire.redirectTestOutputToFile}

Re: [PR] Make master 2.0.0-SNAPSHOT [maven-resolver]

2023-10-11 Thread via GitHub
michael-o commented on code in PR #335: URL: https://github.com/apache/maven-resolver/pull/335#discussion_r1355569226 ## pom.xml: ## @@ -85,18 +85,21 @@ 8 +${javaVersion} +${javaVersion} +${javaVersion} true ${surefire.redirectTestOutputToFile}

Re: [PR] Make master 2.0.0-SNAPSHOT [maven-resolver]

2023-10-11 Thread via GitHub
cstamas commented on code in PR #335: URL: https://github.com/apache/maven-resolver/pull/335#discussion_r1355562042 ## pom.xml: ## @@ -85,18 +85,21 @@ 8 +${javaVersion} +${javaVersion} +${javaVersion} true ${surefire.redirectTestOutputToFile}

Re: [PR] Make master 2.0.0-SNAPSHOT [maven-resolver]

2023-10-11 Thread via GitHub
cstamas commented on code in PR #335: URL: https://github.com/apache/maven-resolver/pull/335#discussion_r1355562042 ## pom.xml: ## @@ -85,18 +85,21 @@ 8 +${javaVersion} +${javaVersion} +${javaVersion} true ${surefire.redirectTestOutputToFile}

Re: [PR] Make master 2.0.0-SNAPSHOT [maven-resolver]

2023-10-11 Thread via GitHub
michael-o commented on code in PR #335: URL: https://github.com/apache/maven-resolver/pull/335#discussion_r1355104017 ## pom.xml: ## @@ -85,18 +85,21 @@ 8 +${javaVersion} +${javaVersion} +${javaVersion} true ${surefire.redirectTestOutputToFile}

Re: [PR] Make master 2.0.0-SNAPSHOT [maven-resolver]

2023-10-11 Thread via GitHub
slawekjaranowski commented on code in PR #335: URL: https://github.com/apache/maven-resolver/pull/335#discussion_r1355076689 ## pom.xml: ## @@ -85,18 +85,21 @@ 8 +${javaVersion} +${javaVersion} +${javaVersion} true ${surefire.redirectTestOutputT

Re: [PR] Make master 2.0.0-SNAPSHOT [maven-resolver]

2023-10-11 Thread via GitHub
michael-o commented on code in PR #335: URL: https://github.com/apache/maven-resolver/pull/335#discussion_r1355045492 ## pom.xml: ## @@ -85,18 +85,21 @@ 8 +${javaVersion} +${javaVersion} +${javaVersion} true ${surefire.redirectTestOutputToFile}

Re: [PR] Make master 2.0.0-SNAPSHOT [maven-resolver]

2023-10-11 Thread via GitHub
slawekjaranowski commented on code in PR #335: URL: https://github.com/apache/maven-resolver/pull/335#discussion_r1355029885 ## pom.xml: ## @@ -85,18 +85,21 @@ 8 +${javaVersion} +${javaVersion} +${javaVersion} true ${surefire.redirectTestOutputT

Re: [PR] Make master 2.0.0-SNAPSHOT [maven-resolver]

2023-10-11 Thread via GitHub
cstamas commented on code in PR #335: URL: https://github.com/apache/maven-resolver/pull/335#discussion_r1355015991 ## pom.xml: ## @@ -85,18 +85,21 @@ 8 +${javaVersion} +${javaVersion} +${javaVersion} true ${surefire.redirectTestOutputToFile}

Re: [PR] Make master 2.0.0-SNAPSHOT [maven-resolver]

2023-10-11 Thread via GitHub
michael-o commented on code in PR #335: URL: https://github.com/apache/maven-resolver/pull/335#discussion_r1354305518 ## pom.xml: ## @@ -85,18 +85,21 @@ 8 +${javaVersion} +${javaVersion} +${javaVersion} true ${surefire.redirectTestOutputToFile}

[PR] Make master 2.0.0-SNAPSHOT [maven-resolver]

2023-10-10 Thread via GitHub
cstamas opened a new pull request, #335: URL: https://github.com/apache/maven-resolver/pull/335 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,