Re: [PR] [MNG-8069] add failing projects if a project is banned from reactor [maven]

2024-03-17 Thread via GitHub
elharo commented on code in PR #1435: URL: https://github.com/apache/maven/pull/1435#discussion_r1527655423 ## maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java: ## @@ -243,10 +246,44 @@ public void projectSkipped(ExecutionEvent event) {

Re: [PR] MNG-8069 - add failing projects if a project is banned from reactor [maven]

2024-03-11 Thread via GitHub
laeubi commented on PR #1435: URL: https://github.com/apache/maven/pull/1435#issuecomment-1987801822 The problem is that if you have a multimodule build (lets say 300 modules) and use multithreading (so build messages are interleaved), and one of the projects fail in the middle you have a h

Re: [PR] MNG-8069 - add failing projects if a project is banned from reactor [maven]

2024-03-11 Thread via GitHub
gnodet commented on PR #1435: URL: https://github.com/apache/maven/pull/1435#issuecomment-1987790899 Wouldn't it be better to add the cause when the project is banned rather than trying to reconstruct it later ? I wonder if we should enhance the [`blacklist()` method](https://github.com/ap

[PR] MNG-8069 - add failing projects if a project is banned from reactor [maven]

2024-03-06 Thread via GitHub
laeubi opened a new pull request, #1435: URL: https://github.com/apache/maven/pull/1435 Currently if a multimodule build fails (either fast or at the end), the user gets a message in the log that reads: "This project has been banned from the build due to previous failures." thi