slawekjaranowski merged PR #273:
URL: https://github.com/apache/maven-compiler-plugin/pull/273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-un
heliodoro198205 commented on PR #273:
URL:
https://github.com/apache/maven-compiler-plugin/pull/273#issuecomment-2657422373
🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
desruisseaux commented on PR #273:
URL:
https://github.com/apache/maven-compiler-plugin/pull/273#issuecomment-2657332053
I think that we should not provide `--module-version` parameter for the test
classes. We are restricted to only one module version per `module-info.class`
file, and that
slawekjaranowski commented on PR #273:
URL:
https://github.com/apache/maven-compiler-plugin/pull/273#issuecomment-2657264099
> Right. Would you like to do it in this pull request?
yes I would like .. but look like `--module-version` is not used in
`TestCompilerMojo` but it can be ano
desruisseaux commented on PR #273:
URL:
https://github.com/apache/maven-compiler-plugin/pull/273#issuecomment-2657247617
Right. Would you like to do it in this pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
slawekjaranowski commented on PR #273:
URL:
https://github.com/apache/maven-compiler-plugin/pull/273#issuecomment-2657204621
One more question `moduleVersion` is added to `AbstractCompilerMojo` but it
is only used in `CompilerMojo` it is not used in `TestCompilerMojo` ... so
should be move
slawekjaranowski commented on PR #273:
URL:
https://github.com/apache/maven-compiler-plugin/pull/273#issuecomment-2654588605
property in master #302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
slawekjaranowski commented on PR #273:
URL:
https://github.com/apache/maven-compiler-plugin/pull/273#issuecomment-2654560364
ok, I see -
https://github.com/apache/maven-compiler-plugin/blob/470ca8869cb4ac9b573167f936db2ef2fe837d19/src/main/java/org/apache/maven/plugin/compiler/AbstractCompi
mguillem commented on PR #273:
URL:
https://github.com/apache/maven-compiler-plugin/pull/273#issuecomment-2654032367
@slachiewicz the changes have been picked up from master branch. The master
branch contains unit tests for that but the setup for these tests is not
available in the 3.x bra
slawekjaranowski commented on PR #273:
URL:
https://github.com/apache/maven-compiler-plugin/pull/273#issuecomment-2637296597
@mguillem I will take care about it.
Thanks for patient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mguillem commented on PR #273:
URL:
https://github.com/apache/maven-compiler-plugin/pull/273#issuecomment-2577891415
Is there a chance to see this merged and released? Otherwise we'll have to
start working with our own private version of the plugin what is never a
pleasure to maintain.
-
mguillem opened a new pull request, #273:
URL: https://github.com/apache/maven-compiler-plugin/pull/273
Allow module-version configuration (like in master branch).
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is
12 matches
Mail list logo
