michael-o commented on PR #161:
URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1761042561
I'd like to perform a release this weekend. Anyone want to complete the
discussion with me?
--
This is an automated message from the Apache Git Service.
To respond to the message, p
michael-o commented on PR #161:
URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753613903
> I think the indentation is clearly removed in order to prevent horizontal
scrollbars for included snippets.
I'd prefer to leave formatting as-is, but I am open to a snippet op
Jotschi commented on PR #161:
URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753609381
I think the indentation is clearly removed in order to prevent horizontal
scrollbars for included snippets.
--
This is an automated message from the Apache Git Service.
To respond to
michael-o commented on PR #161:
URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753607241
> The code clearly removes this indentation if it is done by using spaces.
Using tabs it is not removed and thus looks broken. I'm okay with it if that is
the desired behaviour.
Jotschi commented on PR #161:
URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753603833
The code clearly removes this indentation if it is done by using spaces.
Using tabs it is not removed and thus looks broken.
I'm okay with it if that is the desired behaviour.
--
T
michael-o commented on PR #161:
URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753593496
But what if
```
{
// your code
}
```
is correct indentation?
--
This is an automated message from the Apache Git Ser
Jotschi commented on PR #161:
URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753582952
The snippet renderer removed unnecessary indentation. It thus moved the code
block left. A code example which is highly indented will thus not include the
bogus indentation.
```j
michael-o commented on PR #161:
URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753573765
@kwin, do you understand this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
michael-o commented on PR #161:
URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753573193
> The tabs from this example `[tab][tab]line` will not be removed. Thus the
snippet looks ugly. The tabs should be removed.
Why? If the snippet is intended that way? How can we
Jotschi commented on PR #161:
URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753562919
The tabs from this example
```[tab][tab]line```
will not be removed. Thus the snippet looks ugly. The tabs should be removed.
--
This is an automated message from the Apache
michael-o commented on PR #161:
URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753550682
First snippet has two tabs, but expected does not have any. What do I miss?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
Jotschi commented on PR #161:
URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753545065
As far as I recall - no - tabs are not removed at all. See first example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
michael-o commented on PR #161:
URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753541119
> It fixes the indentation behaviour when the source contains tabs. Without
the fix the indentation is not correctly handled. Without the fix the source
code block has too many tabs a
Jotschi commented on PR #161:
URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753538027
It fixes the indentation behaviour when the source contains tabs. Without
the fix the indentation is not correctly handled. Without the fix the source
code block has too many tabs and i
michael-o commented on PR #161:
URL: https://github.com/apache/maven-doxia/pull/161#issuecomment-1753520298
I don't understand this change. It does not retain the original format, what
does it address?
--
This is an automated message from the Apache Git Service.
To respond to the message,
15 matches
Mail list logo
