Re: [PR] Convert to Guice injection [maven-site-plugin]

2024-12-26 Thread via GitHub
elharo merged PR #218: URL: https://github.com/apache/maven-site-plugin/pull/218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mave

Re: [PR] Convert to Guice injection [maven-site-plugin]

2024-12-25 Thread via GitHub
elharo commented on PR #218: URL: https://github.com/apache/maven-site-plugin/pull/218#issuecomment-2561929801 Makes sense. Meanwhile anyone feel like approving this so I can merge and move forward? -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Convert to Guice injection [maven-site-plugin]

2024-12-25 Thread via GitHub
slachiewicz commented on PR #218: URL: https://github.com/apache/maven-site-plugin/pull/218#issuecomment-2561892317 @hendrikebbers jakarta.inject is not supported by Maven - mainly due to a missing feature in Eclipse Sisu. See https://github.com/eclipse-sisu/sisu-project/issues/103 h

Re: [PR] Convert to Guice injection [maven-site-plugin]

2024-12-24 Thread via GitHub
elharo commented on PR #218: URL: https://github.com/apache/maven-site-plugin/pull/218#issuecomment-2561106126 > Since javax.inject is outdated at has been transferred to Jakarta it would be best to directly use https://mvnrepository.com/artifact/jakarta.inject/jakarta.inject-api Th

Re: [PR] Convert to Guice injection [maven-site-plugin]

2024-12-24 Thread via GitHub
hendrikebbers commented on PR #218: URL: https://github.com/apache/maven-site-plugin/pull/218#issuecomment-2561053640 Since javax.inject is outdated at has been transferred to Jakarta it would be best to directly use https://mvnrepository.com/artifact/jakarta.inject/jakarta.inject-api --

[PR] Convert to Guice injection [maven-site-plugin]

2024-12-20 Thread via GitHub
elharo opened a new pull request, #218: URL: https://github.com/apache/maven-site-plugin/pull/218 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib