Re: [PR] Convert reports to Guice [maven-surefire]

2025-02-15 Thread via GitHub
elharo merged PR #803: URL: https://github.com/apache/maven-surefire/pull/803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.a

Re: [PR] Convert reports to Guice [maven-surefire]

2024-12-25 Thread via GitHub
elharo commented on code in PR #803: URL: https://github.com/apache/maven-surefire/pull/803#discussion_r1897467556 ## maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/AbstractSurefireReport.java: ## @@ -278,17 +281,20 @@ protected I18N getI18N(

Re: [PR] Convert reports to Guice [maven-surefire]

2024-12-25 Thread via GitHub
Bukama commented on code in PR #803: URL: https://github.com/apache/maven-surefire/pull/803#discussion_r1897466706 ## maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/AbstractSurefireReport.java: ## @@ -278,17 +281,20 @@ protected I18N getI18N(

Re: [PR] Convert reports to Guice [maven-surefire]

2024-12-25 Thread via GitHub
Bukama commented on code in PR #803: URL: https://github.com/apache/maven-surefire/pull/803#discussion_r1897466706 ## maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/AbstractSurefireReport.java: ## @@ -278,17 +281,20 @@ protected I18N getI18N(

Re: [PR] Convert reports to Guice [maven-surefire]

2024-12-22 Thread via GitHub
slachiewicz commented on PR #803: URL: https://github.com/apache/maven-surefire/pull/803#issuecomment-2558514233 anyway - good job. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Convert reports to Guice [maven-surefire]

2024-12-22 Thread via GitHub
slachiewicz commented on PR #803: URL: https://github.com/apache/maven-surefire/pull/803#issuecomment-2558514193 If yes, it would be good to have a similar understanding also described on our Maven site, as we have a plan to open reporting issues via gh. -- This is an automated message f

Re: [PR] Convert reports to Guice [maven-surefire]

2024-12-22 Thread via GitHub
elharo commented on PR #803: URL: https://github.com/apache/maven-surefire/pull/803#issuecomment-2558423119 I think release notes, Jira (or Giithub) issues, and PRs are three independent things. There's no 1:1 relationship between them. Each should be written for its audience and purpose.

Re: [PR] Convert reports to Guice [maven-surefire]

2024-12-22 Thread via GitHub
slachiewicz commented on PR #803: URL: https://github.com/apache/maven-surefire/pull/803#issuecomment-2558418866 Yes, here we ask to register Jira. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Convert reports to Guice [maven-surefire]

2024-12-22 Thread via GitHub
elharo commented on PR #803: URL: https://github.com/apache/maven-surefire/pull/803#issuecomment-2558416394 This PR probablly isn't the right place to discuss that, unless there's something more specific you wanted to ask? -- This is an automated message from the Apache Git Service. To r

Re: [PR] Convert reports to Guice [maven-surefire]

2024-12-22 Thread via GitHub
slachiewicz commented on PR #803: URL: https://github.com/apache/maven-surefire/pull/803#issuecomment-2558412467 Vote about migrating to GitHub issues passed so we could słowny, project by project move to GH Issues. Wdyt @elharo -- This is an automated message from the Apache Git Service

Re: [PR] Convert reports to Guice [maven-surefire]

2024-12-21 Thread via GitHub
slawekjaranowski commented on PR #803: URL: https://github.com/apache/maven-surefire/pull/803#issuecomment-2558119461 > IMHO release notes should be limited to user visible changes. This isn't such. Every code changes, refactor and so can have an impact on users ... so should be list

Re: [PR] Convert reports to Guice [maven-surefire]

2024-12-21 Thread via GitHub
elharo commented on PR #803: URL: https://github.com/apache/maven-surefire/pull/803#issuecomment-2558115276 IMHO release notes should be limited to user visible changes. This isn't such. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] Convert reports to Guice [maven-surefire]

2024-12-20 Thread via GitHub
elharo opened a new pull request, #803: URL: https://github.com/apache/maven-surefire/pull/803 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,