Re: [PR] Add tests with Java 8 and 21 [maven-archetypes]

2024-01-03 Thread via GitHub
judovana commented on PR #23: URL: https://github.com/apache/maven-archetypes/pull/23#issuecomment-1874981469 This is present in: https://github.com/apache/maven-archetypes/commit/65fe5eef78fe1fe9b57033deefd3ec65a542e3b2#diff-0d8d63e58484b917cba33e4838a95e7433ee11fd7d9845b16bee9cf807a8de54

Re: [PR] Add tests with Java 8 and 21 [maven-archetypes]

2024-01-03 Thread via GitHub
judovana closed pull request #23: Add tests with Java 8 and 21 URL: https://github.com/apache/maven-archetypes/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] Add tests with Java 8 and 21 [maven-archetypes]

2024-01-02 Thread via GitHub
judovana commented on PR #23: URL: https://github.com/apache/maven-archetypes/pull/23#issuecomment-1874254805 The changes were split to several PRs on @ slachiewicz request -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Add tests with Java 8 and 21 [maven-archetypes]

2024-01-02 Thread via GitHub
judovana commented on PR #23: URL: https://github.com/apache/maven-archetypes/pull/23#issuecomment-1874249710 hi! Sorry, I had to be explicit in initial comment - this is expected to fail, because jdk21 is not supported. If you look into https://github.com/apache/maven-archetypes/p

Re: [PR] Add tests with Java 8 and 21 [maven-archetypes]

2023-12-25 Thread via GitHub
judovana commented on PR #23: URL: https://github.com/apache/maven-archetypes/pull/23#issuecomment-1868927313 This is commit for https://github.com/apache/maven-archetypes/pull/24 and should be merged first. If not approved, it should be rebased -- This is an automated message from the Ap

[PR] Add tests with Java 8 and 21 [maven-archetypes]

2023-12-25 Thread via GitHub
judovana opened a new pull request, #23: URL: https://github.com/apache/maven-archetypes/pull/23 Originally by @slachiewicz Based on the "discussions" in: https://lists.apache.org/thread/chqcxvlko3nz6cgrs2kzjrdy5tv9spkx , https://github.com/apache/maven-archetypes/pull/22 , h