Re: [PR] [WAGON-632] Java 8 [maven-wagon]

2023-10-21 Thread via GitHub
slachiewicz commented on PR #89: URL: https://github.com/apache/maven-wagon/pull/89#issuecomment-1773844321 implicitly fixed by parent pom update https://issues.apache.org/jira/browse/WAGON-634 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [WAGON-632] Java 8 [maven-wagon]

2023-10-21 Thread via GitHub
slachiewicz closed pull request #89: [WAGON-632] Java 8 URL: https://github.com/apache/maven-wagon/pull/89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] [WAGON-632] Java 8 [maven-wagon]

2023-10-03 Thread via GitHub
elharo commented on PR #89: URL: https://github.com/apache/maven-wagon/pull/89#issuecomment-1744976242 @slachiewicz You can merge this if you like once @michael-o dismisses the requested change. However if you prefer to simply merge #93 and close this PR, I think that works too. -- This

Re: [PR] [WAGON-632] Java 8 [maven-wagon]

2023-10-03 Thread via GitHub
elharo commented on PR #89: URL: https://github.com/apache/maven-wagon/pull/89#issuecomment-1744838765 #93 might render this moot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [WAGON-632] Java 8 [maven-wagon]

2023-10-03 Thread via GitHub
elharo commented on PR #89: URL: https://github.com/apache/maven-wagon/pull/89#issuecomment-1744818700 Let me see if I can get the tests to pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] [WAGON-632] Java 8 [maven-wagon]

2023-10-03 Thread via GitHub
michael-o commented on PR #89: URL: https://github.com/apache/maven-wagon/pull/89#issuecomment-1744810922 > Tests have not passed. > > @michael-o are you OK with this now? Yes -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] [WAGON-632] Java 8 [maven-wagon]

2023-10-03 Thread via GitHub
elharo commented on PR #89: URL: https://github.com/apache/maven-wagon/pull/89#issuecomment-1744796832 Tests have not passed. @michael-o are you OK with this now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [WAGON-632] Java 8 [maven-wagon]

2023-10-03 Thread via GitHub
slachiewicz commented on PR #89: URL: https://github.com/apache/maven-wagon/pull/89#issuecomment-1744605108 LGTM @elharo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To