marcphilipp commented on PR #725:
URL: https://github.com/apache/maven-surefire/pull/725#issuecomment-1983657637
FWIWI Gradle recently went that route to no longer include/resolve
junit-platform-launcher but require users to add it themselves:
https://docs.gradle.org/current/userguide/upgra
kwin merged PR #725:
URL: https://github.com/apache/maven-surefire/pull/725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apa
rmannibucau commented on PR #725:
URL: https://github.com/apache/maven-surefire/pull/725#issuecomment-1983399262
@marcphilipp we wouldn't have any provided dependency in surefire itself,
everything would be resolved from project dependencies (if provided use else
resolve the aligned version
kwin commented on PR #725:
URL: https://github.com/apache/maven-surefire/pull/725#issuecomment-1983282674
@marcphilipp @rmannibucau Let us focus in this PR only on the issue that
overriding plugin dependencies as outlined in
https://maven.apache.org/surefire/maven-surefire-plugin/examples/j
marcphilipp commented on PR #725:
URL: https://github.com/apache/maven-surefire/pull/725#issuecomment-1983213597
The used version needs to match the one in the project's dependencies, i.e.
if a build uses JUnit Jupiter 5.10.2, Surefire should use 1.10.2 of its JUnit
Platform dependencies. I
rmannibucau commented on PR #725:
URL: https://github.com/apache/maven-surefire/pull/725#issuecomment-1983072275
Thinking out loud: any reason to have junit in dependency at all? can't we
just use ToolProvider "junit" to launch it and be totally decoupled from junit?
Would enable to use the
kwin commented on code in PR #725:
URL: https://github.com/apache/maven-surefire/pull/725#discussion_r1515756414
##
surefire-providers/surefire-junit-platform/pom.xml:
##
@@ -80,6 +80,13 @@
surefire-3.0.0-M8
+
+
Review Comment:
The BOM will affect transitive
kwin commented on code in PR #725:
URL: https://github.com/apache/maven-surefire/pull/725#discussion_r1515756414
##
surefire-providers/surefire-junit-platform/pom.xml:
##
@@ -80,6 +80,13 @@
surefire-3.0.0-M8
+
+
Review Comment:
The BOM will affect transitive
marcphilipp commented on code in PR #725:
URL: https://github.com/apache/maven-surefire/pull/725#discussion_r1515753439
##
surefire-providers/surefire-junit-platform/pom.xml:
##
@@ -80,6 +80,13 @@
surefire-3.0.0-M8
+
+
Review Comment:
Yes, that's correct but
kwin commented on code in PR #725:
URL: https://github.com/apache/maven-surefire/pull/725#discussion_r1513124629
##
surefire-providers/surefire-junit-platform/pom.xml:
##
@@ -80,6 +80,13 @@
surefire-3.0.0-M8
+
+
Review Comment:
@marcphilipp Is the assumption
kwin opened a new pull request, #725:
URL: https://github.com/apache/maven-surefire/pull/725
This allows to more easily overwrite the version via plugin dependencies
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there
11 matches
Mail list logo
