Re: [PR] [SCM-1022] - jgit push failure is not failing the build [maven-scm]

2024-04-08 Thread via GitHub
michael-o closed pull request #203: [SCM-1022] - jgit push failure is not failing the build URL: https://github.com/apache/maven-scm/pull/203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [SCM-1022] - jgit push failure is not failing the build [maven-scm]

2024-04-08 Thread via GitHub
michael-o commented on PR #203: URL: https://github.com/apache/maven-scm/pull/203#issuecomment-2042404769 Let me run this again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [SCM-1022] - jgit push failure is not failing the build [maven-scm]

2024-04-08 Thread via GitHub
attiand commented on PR #203: URL: https://github.com/apache/maven-scm/pull/203#issuecomment-2042327072 Status.UP_TO_DATE is now successful. Added TCK testUpToDatePush. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [SCM-1022] - jgit push failure is not failing the build [maven-scm]

2024-04-08 Thread via GitHub
kwin commented on code in PR #203: URL: https://github.com/apache/maven-scm/pull/203#discussion_r1555400678 ## maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckInCommand.java: ## @@

Re: [PR] [SCM-1022] - jgit push failure is not failing the build [maven-scm]

2024-04-08 Thread via GitHub
kwin commented on code in PR #203: URL: https://github.com/apache/maven-scm/pull/203#discussion_r1555398863 ## maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/test/java/org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckinCommandTest.java: ##

Re: [PR] [SCM-1022] - jgit push failure is not failing the build [maven-scm]

2024-04-08 Thread via GitHub
michael-o commented on PR #203: URL: https://github.com/apache/maven-scm/pull/203#issuecomment-2042108540 @kwin Any objections? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [SCM-1022] - jgit push failure is not failing the build [maven-scm]

2024-04-07 Thread via GitHub
attiand commented on PR #203: URL: https://github.com/apache/maven-scm/pull/203#issuecomment-2041933386 Moved RejectedNonFastForward Test to TCK. Removed UpToDate test since gitexec and jgit return different status, see https://github.com/apache/maven-scm/pull/203#discussion_r1551846585 -

Re: [PR] [SCM-1022] - jgit push failure is not failing the build [maven-scm]

2024-04-07 Thread via GitHub
michael-o commented on PR #203: URL: https://github.com/apache/maven-scm/pull/203#issuecomment-2041556020 This PR triggers https://github.com/apache/mina-sshd/issues/282. We first need to upgrade MINA. I am working on this right now. -- This is an automated message from the Apache Git Ser

Re: [PR] [SCM-1022] - jgit push failure is not failing the build [maven-scm]

2024-04-04 Thread via GitHub
attiand commented on code in PR #203: URL: https://github.com/apache/maven-scm/pull/203#discussion_r1551846585 ## maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/test/java/org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckinCommandTest.java: ###

Re: [PR] [SCM-1022] - jgit push failure is not failing the build [maven-scm]

2024-04-04 Thread via GitHub
michael-o commented on code in PR #203: URL: https://github.com/apache/maven-scm/pull/203#discussion_r1551701670 ## maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/test/java/org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckinCommandTest.java: #

Re: [PR] [SCM-1022] - jgit push failure is not failing the build [maven-scm]

2024-04-04 Thread via GitHub
michael-o commented on code in PR #203: URL: https://github.com/apache/maven-scm/pull/203#discussion_r1551698288 ## maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckInCommand.java: #

Re: [PR] [SCM-1022] - jgit push failure is not failing the build [maven-scm]

2024-04-04 Thread via GitHub
kwin commented on code in PR #203: URL: https://github.com/apache/maven-scm/pull/203#discussion_r1551603301 ## maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/test/java/org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckinCommandTest.java: ##

Re: [PR] [SCM-1022] - jgit push failure is not failing the build [maven-scm]

2024-04-04 Thread via GitHub
michael-o commented on PR #203: URL: https://github.com/apache/maven-scm/pull/203#issuecomment-2037067814 Looking into... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To