michael-o closed pull request #202: [MSITE-945] Remove dependency on Commons IO
URL: https://github.com/apache/maven-site-plugin/pull/202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
FredrikAnderson commented on code in PR #202:
URL: https://github.com/apache/maven-site-plugin/pull/202#discussion_r1694344292
##
src/test/java/org/apache/maven/plugins/site/deploy/SimpleDavServerHandler.java:
##
@@ -111,4 +112,17 @@ public int getPort() {
public void stop(
FredrikAnderson commented on code in PR #202:
URL: https://github.com/apache/maven-site-plugin/pull/202#discussion_r1694344249
##
src/test/java/org/apache/maven/plugins/site/deploy/SimpleDavServerHandler.java:
##
@@ -111,4 +112,17 @@ public int getPort() {
public void stop(
FredrikAnderson commented on code in PR #202:
URL: https://github.com/apache/maven-site-plugin/pull/202#discussion_r1694344213
##
src/test/java/org/apache/maven/plugins/site/deploy/AbstractSiteDeployWebDavTest.java:
##
@@ -247,4 +249,26 @@ private boolean
assertAtLeastOneReques
FredrikAnderson commented on code in PR #202:
URL: https://github.com/apache/maven-site-plugin/pull/202#discussion_r1694344174
##
src/test/java/org/apache/maven/plugins/site/deploy/AbstractSiteDeployWebDavTest.java:
##
@@ -219,14 +221,14 @@ public void davDeployThruProxyWitAuthz
michael-o commented on code in PR #202:
URL: https://github.com/apache/maven-site-plugin/pull/202#discussion_r1694343621
##
src/test/java/org/apache/maven/plugins/site/deploy/AuthAsyncProxyServlet.java:
##
@@ -137,4 +142,16 @@ public void service(ServletRequest req, ServletRespo
elharo commented on code in PR #202:
URL: https://github.com/apache/maven-site-plugin/pull/202#discussion_r1694234300
##
src/test/java/org/apache/maven/plugins/site/deploy/AbstractSiteDeployWebDavTest.java:
##
@@ -219,14 +221,14 @@ public void davDeployThruProxyWitAuthzInProxy()
michael-o commented on code in PR #202:
URL: https://github.com/apache/maven-site-plugin/pull/202#discussion_r1694170614
##
src/test/java/org/apache/maven/plugins/site/deploy/AbstractSiteDeployWebDavTest.java:
##
@@ -219,14 +221,14 @@ public void davDeployThruProxyWitAuthzInProx
FredrikAnderson commented on PR #202:
URL:
https://github.com/apache/maven-site-plugin/pull/202#issuecomment-2254237447
See your point, fixed!
PR updated.
On Sat, Jul 27, 2024 at 8:37 PM Michael Osipov ***@***.***>
wrote:
> ***@***. requested changes on this pull requ
FredrikAnderson commented on PR #197:
URL:
https://github.com/apache/maven-site-plugin/pull/197#issuecomment-2254213733
"Old" PR closed.
Created a new PR which has base from main and only contains changes for
#945.
https://github.com/apache/maven-site-plugin/pull/202
Plea
FredrikAnderson opened a new pull request, #202:
URL: https://github.com/apache/maven-site-plugin/pull/202
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MSITE) fi
FredrikAnderson closed pull request #197: [MSITE-945] - Remove dependency on
Commons IO
URL: https://github.com/apache/maven-site-plugin/pull/197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
FredrikAnderson opened a new pull request, #197:
URL: https://github.com/apache/maven-site-plugin/pull/197
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MSITE) fi
FredrikAnderson commented on PR #174:
URL:
https://github.com/apache/maven-site-plugin/pull/174#issuecomment-1995152481
Hi again,
Now I have updated with code in a branch in my fork at:
https://github.com/FredrikAnderson/maven-site-plugin/tree/feature/msite-945
Since I neede
FredrikAnderson closed pull request #174: [MSITE-945] Remove dependency on
Commons IO
URL: https://github.com/apache/maven-site-plugin/pull/174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
FredrikAnderson commented on PR #174:
URL:
https://github.com/apache/maven-site-plugin/pull/174#issuecomment-1977492846
Ah, well now I see. Will look into it and come back.
Thx for now.
On Mon, Mar 4, 2024 at 10:27 PM Fredrik Anderson ***@***.***>
wrote:
> Maybe I mis
FredrikAnderson commented on PR #174:
URL:
https://github.com/apache/maven-site-plugin/pull/174#issuecomment-1977489455
Maybe I missed something here then; removed the dependency and thought that
there will be compilation or verification error if something broke, but it
didn't so then
michael-o commented on PR #174:
URL:
https://github.com/apache/maven-site-plugin/pull/174#issuecomment-1977479509
But what about the actual code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
FredrikAnderson opened a new pull request, #174:
URL: https://github.com/apache/maven-site-plugin/pull/174
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MSITE) f
19 matches
Mail list logo
