Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]

2024-05-01 Thread via GitHub
michael-o commented on PR #177: URL: https://github.com/apache/maven-site-plugin/pull/177#issuecomment-2088535907 Here is a fix: https://github.com/apache/maven-plugin-tools/pull/281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]

2024-05-01 Thread via GitHub
michael-o commented on PR #177: URL: https://github.com/apache/maven-site-plugin/pull/177#issuecomment-2088483641 The bug is in `org.apache.maven.tools.plugin.generator.PluginDescriptorFilesGenerator.getJavadocUrlForType(JavadocLinkGenerator, String)`. I guess it should until all generics

Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]

2024-05-01 Thread via GitHub
michael-o commented on PR #177: URL: https://github.com/apache/maven-site-plugin/pull/177#issuecomment-2088245135 It also fails with: `Error generating maven-plugin-report-plugin:3.12.0:report report:` -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]

2024-05-01 Thread via GitHub
michael-o commented on code in PR #177: URL: https://github.com/apache/maven-site-plugin/pull/177#discussion_r1585980633 ## src/main/java/org/apache/maven/plugins/site/render/ParserConfiguratorImpl.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]

2024-04-30 Thread via GitHub
michael-o commented on PR #177: URL: https://github.com/apache/maven-site-plugin/pull/177#issuecomment-2084555013 I will happily review again after #185 has been merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]

2024-04-29 Thread via GitHub
kwin commented on code in PR #177: URL: https://github.com/apache/maven-site-plugin/pull/177#discussion_r1583435793 ## src/main/java/org/apache/maven/plugins/site/render/ParserConfiguratorImpl.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]

2024-04-29 Thread via GitHub
kwin commented on code in PR #177: URL: https://github.com/apache/maven-site-plugin/pull/177#discussion_r1583427213 ## src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java: ## @@ -94,6 +97,37 @@ public abstract class AbstractSiteRenderingMojo extends

Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]

2024-04-19 Thread via GitHub
michael-o commented on code in PR #177: URL: https://github.com/apache/maven-site-plugin/pull/177#discussion_r1572746343 ## src/main/java/org/apache/maven/plugins/site/render/ParserConfiguratorImpl.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]

2024-04-19 Thread via GitHub
michael-o commented on code in PR #177: URL: https://github.com/apache/maven-site-plugin/pull/177#discussion_r1572744522 ## src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java: ## @@ -94,6 +97,37 @@ public abstract class AbstractSiteRenderingMojo ex

Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]

2024-01-13 Thread via GitHub
michael-o commented on PR #171: URL: https://github.com/apache/maven-site-plugin/pull/171#issuecomment-1890398224 @kwin Can you adapt to recent changes to the sitetools PR? I'd like to review this today. -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]

2024-01-07 Thread via GitHub
michael-o commented on code in PR #171: URL: https://github.com/apache/maven-site-plugin/pull/171#discussion_r1444061958 ## src/main/java/org/apache/maven/plugins/site/render/ReportDocumentRenderer.java: ## @@ -131,6 +131,7 @@ public Sink createSink(File outputDirectory, String

Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]

2024-01-02 Thread via GitHub
kwin commented on code in PR #171: URL: https://github.com/apache/maven-site-plugin/pull/171#discussion_r1439879467 ## src/main/java/org/apache/maven/plugins/site/render/ParserConfiguration.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]

2023-12-30 Thread via GitHub
kwin commented on code in PR #171: URL: https://github.com/apache/maven-site-plugin/pull/171#discussion_r1438573138 ## src/main/java/org/apache/maven/plugins/site/render/ParserConfiguration.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under