adangel commented on PR #144:
URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2104232352
> @adangel That merge was a pile of junk. You imported all intermediate work
into master making it impossible to trace down the actual change. Don't do that
again please, always sq
michael-o commented on PR #144:
URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094396908
Reminds of
https://github.com/apache/maven-fluido-skin/pull/39#issuecomment-1166243030
--
This is an automated message from the Apache Git Service.
To respond to the message, p
michael-o commented on PR #144:
URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094373023
There it is:
https://github.com/apache/maven-pmd-plugin/actions/runs/8953082426/job/24591196710#step:6:1942
--
This is an automated message from the Apache Git Service.
To resp
michael-o commented on PR #144:
URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094372771
@mkolesnikov Please rework this with a followup PR. for now, the flow is
broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
michael-o commented on code in PR #144:
URL: https://github.com/apache/maven-pmd-plugin/pull/144#discussion_r1590128034
##
src/main/java/org/apache/maven/plugins/pmd/exec/CpdExecutor.java:
##
@@ -155,46 +149,50 @@ private CpdResult run() throws MavenReportException {
michael-o commented on PR #144:
URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094371392
This change introduced now a failing test which did no bubble up in CI, but
should have:
```
[INFO] Running org.apache.maven.plugins.pmd.CpdReportTest
org.apache.maven.re
michael-o commented on PR #144:
URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094369580
> @michael-o please abstain from statements like these. Any contribution is
welcome, and mistakes do happen (yes, squashing the PR would be good, but this
is not the end of the w
cstamas commented on PR #144:
URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094367940
@michael-o please abstain from statements like these. Any contribution is
welcome, and mistakes do happen (yes, squashing the PR would be good, but this
is not the end of the world
michael-o commented on PR #144:
URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2094353945
@adangel That merge was a pile of junk. You imported all intermediate work
into master making it impossible to trace down the actual change. Don't do that
again please, always sq
lapostoj commented on PR #144:
URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2066441436
Ah my bad I didn't know that part of the process!
Sounds great then! 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
slawekjaranowski commented on PR #144:
URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2066313975
@lapostoj - release under vote -
https://lists.apache.org/thread/d0lkjhqv8ddwkw7vz7brlgv93mv1n86n
--
This is an automated message from the Apache Git Service.
To respond
lapostoj commented on PR #144:
URL: https://github.com/apache/maven-pmd-plugin/pull/144#issuecomment-2066241133
Hey @adangel, thanks for getting the PR merged!
I believe the new version has not been deployed and pushed to the mvn
repository, any step missing there?
--
This is an automa
adangel merged PR #144:
URL: https://github.com/apache/maven-pmd-plugin/pull/144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@mave
13 matches
Mail list logo
