Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-alpha-13 [maven-plugin-tools]

2024-05-23 Thread via GitHub
gnodet closed pull request #242: [MPLUGIN-508] Upgrade to Maven 4.0.0-alpha-13 URL: https://github.com/apache/maven-plugin-tools/pull/242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-alpha-13 [maven-plugin-tools]

2024-05-23 Thread via GitHub
gnodet commented on PR #242: URL: https://github.com/apache/maven-plugin-tools/pull/242#issuecomment-2126521901 Closed in favour of https://github.com/apache/maven-plugin-tools/pull/286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-alpha-13 [maven-plugin-tools]

2024-05-22 Thread via GitHub
slawekjaranowski commented on code in PR #242: URL: https://github.com/apache/maven-plugin-tools/pull/242#discussion_r1610706745 ## pom.xml: ## @@ -333,6 +333,21 @@ + + + +true +never +fail + + +false + +

Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-alpha-13 [maven-plugin-tools]

2024-03-29 Thread via GitHub
hboutemy commented on PR #242: URL: https://github.com/apache/maven-plugin-tools/pull/242#issuecomment-2027872569 IIUC, discussion means this PR is not ready for merge and release: I'll release 3.12.0 without -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-alpha-13 [maven-plugin-tools]

2024-03-29 Thread via GitHub
hboutemy commented on PR #242: URL: https://github.com/apache/maven-plugin-tools/pull/242#issuecomment-2026933356 too complex answer, I'm not sure what to do to release plugin-tools 3.12.0 this WE regarding this PR associated to MPLUGIN-508: 1. release now without the PR? 2. push to f

Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-alpha-13 [maven-plugin-tools]

2024-03-24 Thread via GitHub
gnodet commented on PR #242: URL: https://github.com/apache/maven-plugin-tools/pull/242#issuecomment-2016909806 > I extracted from this huge PR updates that were not really related to Maven 4 alpha but cleanup that caused it hard to get the intent of the PR you'll need to rebase to get a m

Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-alpha-13 [maven-plugin-tools]

2024-03-24 Thread via GitHub
hboutemy commented on PR #242: URL: https://github.com/apache/maven-plugin-tools/pull/242#issuecomment-2016844928 I extracted from this huge PR updates that were not really related to Maven 4 alpha but cleanup that caused it hard to get the intent of the PR you'll need to rebase to get a

Re: [PR] [MPLUGIN-508] Upgrade to Maven 4.0.0-alpha-13 [maven-plugin-tools]

2024-03-21 Thread via GitHub
gnodet commented on PR #242: URL: https://github.com/apache/maven-plugin-tools/pull/242#issuecomment-2012198247 > > > The plugin currently supports building either a Maven 3 or a Maven 4 plugin. > > > > > > sorry, I still need some explanations because I can't guess from this PR