Re: [PR] [MNGSITE-504] Fix rendering / markdown warnings [maven-site]

2025-01-04 Thread via GitHub
slachiewicz merged PR #614: URL: https://github.com/apache/maven-site/pull/614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

Re: [PR] [MNGSITE-504] Fix rendering / markdown warnings [maven-site]

2025-01-04 Thread via GitHub
Bukama commented on PR #614: URL: https://github.com/apache/maven-site/pull/614#issuecomment-2571354571 Rebased after several other commits were merged into master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [MNGSITE-504] Fix rendering / markdown warnings [maven-site]

2025-01-01 Thread via GitHub
Bukama commented on code in PR #614: URL: https://github.com/apache/maven-site/pull/614#discussion_r1900425802 ## content/xdoc/errors/404.xml.vm: ## Review Comment: Side note: Did some tests about using test and filed an issue [DOXIASITETOOLS-358](https://issues.apache.org

Re: [PR] [MNGSITE-504] Fix rendering / markdown warnings [maven-site]

2025-01-01 Thread via GitHub
Bukama commented on code in PR #614: URL: https://github.com/apache/maven-site/pull/614#discussion_r1900387361 ## content/xdoc/errors/404.xml.vm: ## Review Comment: > In general every valid HTML is also valid in MD (https://daringfireball.net/projects/markdown/syntax#html)

Re: [PR] [MNGSITE-504] Fix rendering / markdown warnings [maven-site]

2025-01-01 Thread via GitHub
kwin commented on code in PR #614: URL: https://github.com/apache/maven-site/pull/614#discussion_r1900385042 ## content/xdoc/errors/404.xml.vm: ## Review Comment: In general every valid HTML is also valid in MD (https://daringfireball.net/projects/markdown/syntax#html). Th

Re: [PR] [MNGSITE-504] Fix rendering / markdown warnings [maven-site]

2024-12-30 Thread via GitHub
Bukama commented on code in PR #614: URL: https://github.com/apache/maven-site/pull/614#discussion_r1899365421 ## content/xdoc/errors/404.xml.vm: ## Review Comment: Okay, will wait for an answer of @kwin or @michael-o about your question and then change or revert the 404 f

Re: [PR] [MNGSITE-504] Fix rendering / markdown warnings [maven-site]

2024-12-29 Thread via GitHub
elharo commented on code in PR #614: URL: https://github.com/apache/maven-site/pull/614#discussion_r1899197068 ## content/markdown/errors/404.md: ## @@ -0,0 +1,29 @@ +

Re: [PR] [MNGSITE-504] Fix rendering / markdown warnings [maven-site]

2024-12-29 Thread via GitHub
michael-o commented on code in PR #614: URL: https://github.com/apache/maven-site/pull/614#discussion_r1899196305 ## content/markdown/errors/404.md: ## @@ -0,0 +1,29 @@ +

Re: [PR] [MNGSITE-504] Fix rendering / markdown warnings [maven-site]

2024-12-29 Thread via GitHub
slawekjaranowski commented on code in PR #614: URL: https://github.com/apache/maven-site/pull/614#discussion_r1899194852 ## content/xdoc/errors/404.xml.vm: ## Review Comment: The problem will be on page like: https://maven.apache.org/plugins/maven-abc-plugin/ -- This i

Re: [PR] [MNGSITE-504] Fix rendering / markdown warnings [maven-site]

2024-12-29 Thread via GitHub
Bukama commented on code in PR #614: URL: https://github.com/apache/maven-site/pull/614#discussion_r1899194534 ## content/markdown/errors/404.md: ## @@ -0,0 +1,29 @@ +

Re: [PR] [MNGSITE-504] Fix rendering / markdown warnings [maven-site]

2024-12-29 Thread via GitHub
elharo commented on code in PR #614: URL: https://github.com/apache/maven-site/pull/614#discussion_r1899192970 ## content/markdown/errors/404.md: ## @@ -0,0 +1,29 @@ +

Re: [PR] [MNGSITE-504] Fix rendering / markdown warnings [maven-site]

2024-12-29 Thread via GitHub
Bukama commented on code in PR #614: URL: https://github.com/apache/maven-site/pull/614#discussion_r1899183058 ## content/markdown/errors/404.md: ## @@ -0,0 +1,29 @@ +

Re: [PR] [MNGSITE-504] Fix rendering / markdown warnings [maven-site]

2024-12-29 Thread via GitHub
Bukama commented on code in PR #614: URL: https://github.com/apache/maven-site/pull/614#discussion_r1899182501 ## content/xdoc/errors/404.xml.vm: ## Review Comment: > We can not move it to `md` We need additional html page headers. > > This content can be displayed i

Re: [PR] [MNGSITE-504] Fix rendering / markdown warnings [maven-site]

2024-12-29 Thread via GitHub
slawekjaranowski commented on code in PR #614: URL: https://github.com/apache/maven-site/pull/614#discussion_r1899178078 ## content/xdoc/errors/404.xml.vm: ## Review Comment: We can not move it to `md` We need additional html page headers. This content can be disp

Re: [PR] [MNGSITE-504] Fix rendering / markdown warnings [maven-site]

2024-12-29 Thread via GitHub
elharo commented on code in PR #614: URL: https://github.com/apache/maven-site/pull/614#discussion_r1899175911 ## content/markdown/errors/404.md: ## @@ -0,0 +1,29 @@ + + +# Page Not Found + +We're sorry, but the page you requested cannot be found. This may be because: + Review

[PR] [MNGSITE-504] Fix rendering / markdown warnings [maven-site]

2024-12-29 Thread via GitHub
Bukama opened a new pull request, #614: URL: https://github.com/apache/maven-site/pull/614 With this PR I updated some very old (, but still existing) pages to reduce the renderer warnings during the `site` goal (see MNGSITE-504). This PR is **not* to update the outdated content of th