Stellar1999 closed pull request #2029: [MNG-8490] Combine XmlNode and
XmlNodeImpl.
URL: https://github.com/apache/maven/pull/2029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
elharo commented on code in PR #2029:
URL: https://github.com/apache/maven/pull/2029#discussion_r1905374218
##
api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java:
##
@@ -18,121 +18,244 @@
*/
package org.apache.maven.api.xml;
+import javax.xml.stream.XMLSt
gnodet commented on code in PR #2029:
URL: https://github.com/apache/maven/pull/2029#discussion_r1904987719
##
api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java:
##
@@ -18,121 +18,244 @@
*/
package org.apache.maven.api.xml;
+import javax.xml.stream.XMLSt
Stellar1999 commented on PR #2029:
URL: https://github.com/apache/maven/pull/2029#issuecomment-2574250755
> [MNG-8490] Combine XmlNode and XmlNodeImpl. codehaus-plexus/plexus-xml#54
> A few points need to be addressed:
>
> * no third party dependency in the API
> * no
gnodet commented on code in PR #2029:
URL: https://github.com/apache/maven/pull/2029#discussion_r1904798423
##
api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java:
##
@@ -18,121 +18,244 @@
*/
package org.apache.maven.api.xml;
+import javax.xml.stream.XMLSt
gnodet commented on code in PR #2029:
URL: https://github.com/apache/maven/pull/2029#discussion_r1904796769
##
api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java:
##
@@ -18,121 +18,244 @@
*/
package org.apache.maven.api.xml;
+import javax.xml.stream.XMLSt
gnodet commented on code in PR #2029:
URL: https://github.com/apache/maven/pull/2029#discussion_r1904796329
##
api/maven-api-xml/pom.xml:
##
@@ -35,6 +35,14 @@
org.apache.maven
maven-api-annotations
+
+ com.fasterxml.woodstox
Review Comment:
No e
gnodet commented on code in PR #2029:
URL: https://github.com/apache/maven/pull/2029#discussion_r1904796130
##
apache-maven/pom.xml:
##
@@ -125,6 +125,10 @@ under the License.
org.eclipse.sisu
org.eclipse.sisu.plexus
+
+ org.codehaus.plexus
+ pl
elharo commented on code in PR #2029:
URL: https://github.com/apache/maven/pull/2029#discussion_r1904259241
##
api/maven-api-xml/src/main/java/org/apache/maven/api/xml/XmlNode.java:
##
@@ -18,121 +18,244 @@
*/
package org.apache.maven.api.xml;
+import javax.xml.stream.XMLSt
Stellar1999 commented on PR #2029:
URL: https://github.com/apache/maven/pull/2029#issuecomment-2573159562
There are still some comment-related tasks remaining, and I will complete
them later.
--
This is an automated message from the Apache Git Service.
To respo
Stellar1999 commented on PR #2029:
URL: https://github.com/apache/maven/pull/2029#issuecomment-2573153116
> And this implementation class changes quite often with bug fixes, so I
would not put it in the API.
I’ve placed most of the implementation in the Util class to avoid impacting
Stellar1999 commented on PR #2029:
URL: https://github.com/apache/maven/pull/2029#issuecomment-2573149780
I’ve almost completed most of the coding work and linked it to a plexus-xml
PR. However, this PR seems to have a broader impact than expected. Could you
please help evaluate it?
--
T
gnodet commented on PR #2029:
URL: https://github.com/apache/maven/pull/2029#issuecomment-2573049205
And this implementation class changes quite often with bug fixes, so I would
not put it in the API.
--
This is an automated message from the Apache Git Service.
To respond to the message,
Stellar1999 commented on PR #2029:
URL: https://github.com/apache/maven/pull/2029#issuecomment-2572295793
We need to synchronize the implementation in plexus-xml, so we will keep it
as a draft for now.
--
This is an automated message from the Apache Git Service
Stellar1999 opened a new pull request, #2029:
URL: https://github.com/apache/maven/pull/2029
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for
15 matches
Mail list logo
