Re: [PR] [MNG-8461] Initial settings method must restore context state [maven]

2024-12-22 Thread via GitHub
cstamas merged PR #2004: URL: https://github.com/apache/maven/pull/2004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

Re: [PR] [MNG-8461] Initial settings method must restore context state [maven]

2024-12-20 Thread via GitHub
cstamas commented on PR #2004: URL: https://github.com/apache/maven/pull/2004#issuecomment-2557209436 Still cannot figure, and I starting to doubt in our ITs... The only difference I found so far: * reproducer uses `.mvn/extensions.xml` to load up spy listener * IT uses `-Dmaven.ext.cl

Re: [PR] [MNG-8461] Initial settings method must restore context state [maven]

2024-12-20 Thread via GitHub
cstamas commented on PR #2004: URL: https://github.com/apache/maven/pull/2004#issuecomment-2557170897 So, we need to dig in, why reproducer fails, and why IT succeeds. Locally running the related IT I have this (mng-4936/target/spy.log): fixed: Apache Maven 4.0.0-rc-3-SNAPSHOT (a9f6f

Re: [PR] [MNG-8461] Initial settings method must restore context state [maven]

2024-12-20 Thread via GitHub
cstamas commented on PR #2004: URL: https://github.com/apache/maven/pull/2004#issuecomment-2557132290 I think we can... but am now looking at MavenITmng4936EventSpyTest and it seems it does test for this thing but did not fail? -- This is an automated message from the Apache Git Service.

[PR] [MNG-8461] Initial settings method must restore context state [maven]

2024-12-20 Thread via GitHub
cstamas opened a new pull request, #2004: URL: https://github.com/apache/maven/pull/2004 Effective settings are (should be) created twice, once for "early boot" of Plexus when extensions are loaded up, and then again when Maven "boots". Bug was that early call "corrupted" (inited sett