cstamas merged PR #1929:
URL: https://github.com/apache/maven/pull/1929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.
cstamas commented on PR #1929:
URL: https://github.com/apache/maven/pull/1929#issuecomment-2489359658
Dropped two files, locally is ok, let see ITs and merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
gnodet commented on code in PR #1929:
URL: https://github.com/apache/maven/pull/1929#discussion_r1850832511
##
its/core-it-suite/src/test/resources/mng-8385/spi-extension/.mvn/placeholder.txt:
##
Review Comment:
It should be unneeded, since you added `root="true"` on the po
gnodet commented on code in PR #1929:
URL: https://github.com/apache/maven/pull/1929#discussion_r1850835090
##
impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/spi/PropertyContributorsHolder.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation
gnodet commented on code in PR #1929:
URL: https://github.com/apache/maven/pull/1929#discussion_r1850834371
##
api/maven-api-spi/src/main/java/org/apache/maven/api/spi/PropertyContributor.java:
##
@@ -38,6 +40,19 @@ public interface PropertyContributor extends SpiService {
