Re: [PR] [MNG-8340] Resolve parent according to the exact model location [maven]

2024-11-13 Thread via GitHub
gnodet merged PR #1857: URL: https://github.com/apache/maven/pull/1857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

Re: [PR] [MNG-8340] Resolve parent according to the exact model location [maven]

2024-11-13 Thread via GitHub
cstamas commented on code in PR #1857: URL: https://github.com/apache/maven/pull/1857#discussion_r1840493162 ## impl/maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java: ## @@ -913,7 +913,7 @@ private Model injectLifecycleBindings( } pr

Re: [PR] [MNG-8340] Resolve parent according to the exact model location [maven]

2024-11-13 Thread via GitHub
gnodet commented on PR #1857: URL: https://github.com/apache/maven/pull/1857#issuecomment-2473836298 It seems this PR also fixes [MNG-8336](https://issues.apache.org/jira/browse/MNG-8336) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [MNG-8340] Resolve parent according to the exact model location [maven]

2024-10-29 Thread via GitHub
cstamas commented on PR #1857: URL: https://github.com/apache/maven/pull/1857#issuecomment-2444367136 Something is still not right, as this PR w/ shade in IT https://github.com/apache/maven-integration-testing/pull/400 now causes NPE -- This is an automated message from the Apache Git Ser

Re: [PR] [MNG-8340] Resolve parent according to the exact model location [maven]

2024-10-29 Thread via GitHub
cstamas commented on PR #1857: URL: https://github.com/apache/maven/pull/1857#issuecomment-2444227468 https://github.com/apache/maven-integration-testing/pull/400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [MNG-8340] Resolve parent according to the exact model location [maven]

2024-10-29 Thread via GitHub
gnodet commented on PR #1857: URL: https://github.com/apache/maven/pull/1857#issuecomment-2444139151 > Just a plain project with one module shade + dep reduced POM would work as an IT? It needs child subproject, and the shade plugin should generate the Pom in the target folder (inste

Re: [PR] [MNG-8340] Resolve parent according to the exact model location [maven]

2024-10-29 Thread via GitHub
cstamas commented on PR #1857: URL: https://github.com/apache/maven/pull/1857#issuecomment-2444131553 Just a plain project with one module shade + dep reduced POM would work as an IT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to