Re: [PR] [MNG-8331] Fix disappearing dependencies [maven]

2024-10-19 Thread via GitHub
gnodet closed pull request #1822: [MNG-8331] Fix disappearing dependencies URL: https://github.com/apache/maven/pull/1822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [MNG-8331] Fix disappearing dependencies [maven]

2024-10-19 Thread via GitHub
gnodet commented on PR #1822: URL: https://github.com/apache/maven/pull/1822#issuecomment-2424067815 Let's go with #1821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [MNG-8331] Fix disappearing dependencies [maven]

2024-10-19 Thread via GitHub
gnodet commented on code in PR #1822: URL: https://github.com/apache/maven/pull/1822#discussion_r1807254941 ## maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelBuilder.java: ## @@ -595,6 +595,8 @@ Model transformFileToRaw(Model model) {

Re: [PR] [MNG-8331] Fix disappearing dependencies [maven]

2024-10-19 Thread via GitHub
cstamas commented on PR #1822: URL: https://github.com/apache/maven/pull/1822#issuecomment-2423691520 Another alternative mixing the two solutions: https://github.com/apache/maven/pull/1823 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [MNG-8331] Fix disappearing dependencies [maven]

2024-10-19 Thread via GitHub
mthmulders commented on code in PR #1822: URL: https://github.com/apache/maven/pull/1822#discussion_r1807238719 ## maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelBuilder.java: ## @@ -595,6 +595,8 @@ Model transformFileToRaw(Model model) {