Re: [PR] [MNG-8214] Improve model velocity template to support subclasses [maven]

kwin merged PR #1660: URL: https://github.com/apache/maven/pull/1660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

Re: [PR] [MNG-8214] Improve model velocity template to support subclasses [maven]

kwin commented on code in PR #1660: URL: https://github.com/apache/maven/pull/1660#discussion_r1732258290 ## src/mdo/model.vm: ## @@ -493,40 +482,15 @@ public class ${class.name} #end @Nonnull public ${class.name} build() { +// this method shou

Re: [PR] [MNG-8214] Improve model velocity template to support subclasses [maven]

gnodet commented on code in PR #1660: URL: https://github.com/apache/maven/pull/1660#discussion_r1731523749 ## src/mdo/model.vm: ## @@ -493,40 +482,15 @@ public class ${class.name} #end @Nonnull public ${class.name} build() { +// this method sh

Re: [PR] [MNG-8214] Improve model velocity template to support subclasses [maven]

kwin commented on code in PR #1660: URL: https://github.com/apache/maven/pull/1660#discussion_r1731437500 ## src/mdo/model.vm: ## @@ -145,55 +145,39 @@ public class ${class.name} #end /** - * Constructor for this class, package protected. + * Constructor fo

Re: [PR] [MNG-8214] Improve model velocity template to support subclasses [maven]

gnodet commented on code in PR #1660: URL: https://github.com/apache/maven/pull/1660#discussion_r1731010876 ## src/mdo/model.vm: ## @@ -145,55 +145,39 @@ public class ${class.name} #end /** - * Constructor for this class, package protected. + * Constructor

Re: [PR] [MNG-8214] Improve model velocity template to support subclasses [maven]

gnodet commented on code in PR #1660: URL: https://github.com/apache/maven/pull/1660#discussion_r1731010876 ## src/mdo/model.vm: ## @@ -145,55 +145,39 @@ public class ${class.name} #end /** - * Constructor for this class, package protected. + * Constructor

Re: [PR] [MNG-8214] Improve model velocity template to support subclasses [maven]

kwin commented on code in PR #1660: URL: https://github.com/apache/maven/pull/1660#discussion_r1730881137 ## src/mdo/model.vm: ## @@ -145,55 +145,39 @@ public class ${class.name} #end /** - * Constructor for this class, package protected. + * Constructor fo

Re: [PR] [MNG-8214] Improve model velocity template to support subclasses [maven]

gnodet commented on code in PR #1660: URL: https://github.com/apache/maven/pull/1660#discussion_r1730817966 ## src/mdo/model.vm: ## @@ -145,55 +145,39 @@ public class ${class.name} #end /** - * Constructor for this class, package protected. + * Constructor

Re: [PR] [MNG-8214] Improve model velocity template to support subclasses [maven]

kwin commented on code in PR #1660: URL: https://github.com/apache/maven/pull/1660#discussion_r1730778218 ## src/mdo/model.vm: ## @@ -145,55 +145,39 @@ public class ${class.name} #end /** - * Constructor for this class, package protected. + * Constructor fo

Re: [PR] [MNG-8214] Improve model velocity template to support subclasses [maven]

gnodet commented on code in PR #1660: URL: https://github.com/apache/maven/pull/1660#discussion_r1730326047 ## src/mdo/model.vm: ## @@ -145,55 +145,39 @@ public class ${class.name} #end /** - * Constructor for this class, package protected. + * Constructor

Re: [PR] [MNG-8214] Improve model velocity template to support subclasses [maven]

kwin commented on code in PR #1660: URL: https://github.com/apache/maven/pull/1660#discussion_r1730292226 ## src/mdo/model.vm: ## @@ -145,55 +145,39 @@ public class ${class.name} #end /** - * Constructor for this class, package protected. + * Constructor fo

Re: [PR] [MNG-8214] Improve model velocity template to support subclasses [maven]

gnodet commented on code in PR #1660: URL: https://github.com/apache/maven/pull/1660#discussion_r1729584195 ## src/mdo/model.vm: ## @@ -145,55 +145,39 @@ public class ${class.name} #end /** - * Constructor for this class, package protected. + * Constructor

Re: [PR] [MNG-8214] Improve model velocity template to support subclasses [maven]

gnodet commented on code in PR #1660: URL: https://github.com/apache/maven/pull/1660#discussion_r1720833527 ## src/mdo/model.vm: ## @@ -142,46 +142,33 @@ public class ${class.name} #end /** - * Constructor for this class, package protected. + * Constructor

Re: [PR] [MNG-8214] Improve model velocity template to support subclasses [maven]

kwin commented on PR #1660: URL: https://github.com/apache/maven/pull/1660#issuecomment-2294852304 > However the use case of ExtendedMojoDescriptor is definitely a bad one. I only partially agree, extending the MDO for this case is not useful as the additional attribute really only is

Re: [PR] [MNG-8214] Improve model velocity template to support subclasses [maven]

kwin commented on code in PR #1660: URL: https://github.com/apache/maven/pull/1660#discussion_r1720744714 ## src/mdo/model.vm: ## @@ -142,46 +142,33 @@ public class ${class.name} #end /** - * Constructor for this class, package protected. + * Constructor fo

Re: [PR] [MNG-8214] Improve model velocity template to support subclasses [maven]

gnodet commented on PR #1660: URL: https://github.com/apache/maven/pull/1660#issuecomment-2294375827 I don't really see what's your use case for that ? We already have inheritance such as `Build` extends `BuildBase` and it works correctly. Is that just a cleanup ? -- This is an automate

[PR] [MNG-8214] Improve model velocity template to support subclasses [maven]

kwin opened a new pull request, #1660: URL: https://github.com/apache/maven/pull/1660 This makes the constructor protected and takes the Builder as argument Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA