cstamas merged PR #1564:
URL: https://github.com/apache/maven/pull/1564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.
cstamas commented on code in PR #1564:
URL: https://github.com/apache/maven/pull/1564#discussion_r1629954594
##
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/DefaultArtifactVersionTest.java:
##
@@ -80,6 +80,15 @@ public void testVersionParsing() {
ch
michael-o commented on code in PR #1564:
URL: https://github.com/apache/maven/pull/1564#discussion_r1629952883
##
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/DefaultArtifactVersionTest.java:
##
@@ -80,6 +80,15 @@ public void testVersionParsing() {
cstamas commented on code in PR #1564:
URL: https://github.com/apache/maven/pull/1564#discussion_r1629950638
##
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/DefaultArtifactVersionTest.java:
##
@@ -80,6 +80,15 @@ public void testVersionParsing() {
ch
michael-o commented on code in PR #1564:
URL: https://github.com/apache/maven/pull/1564#discussion_r1629949818
##
maven-artifact/src/test/java/org/apache/maven/artifact/versioning/DefaultArtifactVersionTest.java:
##
@@ -80,6 +80,15 @@ public void testVersionParsing() {
michael-o commented on code in PR #1564:
URL: https://github.com/apache/maven/pull/1564#discussion_r1629948490
##
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java:
##
@@ -179,7 +179,8 @@ private static boolean isDigits(String str) {
cstamas commented on PR #1564:
URL: https://github.com/apache/maven/pull/1564#issuecomment-2152739532
I agree with this "general" rule to prefer NPE over IAE, but disagree with
unconditional sticking to this rule. One has to be pragmatic a bit, and allow
deviation. My point was, that in thi
cstamas commented on code in PR #1564:
URL: https://github.com/apache/maven/pull/1564#discussion_r1629689572
##
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java:
##
@@ -176,6 +174,18 @@ private static Integer getNextIntegerToken(Strin
elharo commented on PR #1564:
URL: https://github.com/apache/maven/pull/1564#issuecomment-2152717446
I concur that NPE is strongly preferred over IAE for null values. I didn't
happen to find any places where this was done wrong, but I wasn't reading that
closely.
--
This is an automated
elharo commented on code in PR #1564:
URL: https://github.com/apache/maven/pull/1564#discussion_r1629675910
##
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java:
##
@@ -176,6 +174,18 @@ private static Integer getNextIntegerToken(String
cstamas commented on PR #1564:
URL: https://github.com/apache/maven/pull/1564#issuecomment-2152701271
For ref, the Maven4 PR https://github.com/apache/maven/pull/1080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
elharo commented on PR #1564:
URL: https://github.com/apache/maven/pull/1564#issuecomment-2152697789
I'll have to dig into the individual changes. However overall I no longer
trust commons-lang and definitely favor removing our dependence on it if
possible.
--
This is an automated messa
cstamas commented on PR #1564:
URL: https://github.com/apache/maven/pull/1564#issuecomment-2152638881
> Yes, through out our entire codebase.
Don't divert: I asked you to show me where _changed_ spots in this PR
benefit anything from NPE (as vs IAEx).
But nevertheless, with co
michael-o commented on code in PR #1564:
URL: https://github.com/apache/maven/pull/1564#discussion_r1629570046
##
pom.xml:
##
@@ -442,16 +441,6 @@ under the License.
commons-cli
commons-cli
${commonsCliVersion}
-
-
-common
cstamas commented on code in PR #1564:
URL: https://github.com/apache/maven/pull/1564#discussion_r1629554150
##
pom.xml:
##
@@ -442,16 +441,6 @@ under the License.
commons-cli
commons-cli
${commonsCliVersion}
-
-
-commons-
michael-o commented on PR #1564:
URL: https://github.com/apache/maven/pull/1564#issuecomment-2152503852
I agree that for those few cases Commons Lang is overkill.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
michael-o commented on code in PR #1564:
URL: https://github.com/apache/maven/pull/1564#discussion_r1629513653
##
pom.xml:
##
@@ -442,16 +441,6 @@ under the License.
commons-cli
commons-cli
${commonsCliVersion}
-
-
-common
michael-o commented on PR #1564:
URL: https://github.com/apache/maven/pull/1564#issuecomment-2152392587
> > Several changes are _not_ OK. There is clearly a definition that for a
null value an NPE is expected, not IAE for past 10+ years. This violates the
expectations from Effective Java. @
cstamas commented on PR #1564:
URL: https://github.com/apache/maven/pull/1564#issuecomment-2152375090
> Several changes are _not_ OK. There is clearly a definition that for a
null value an NPE is expected, not IAE for past 10+ years. This violates the
expectations from Effective Java. @elha
19 matches
Mail list logo
