Re: [PR] [MNG-8077] tolerate injected timestamp value [maven-artifact-plugin]

2024-03-28 Thread via GitHub
hboutemy commented on PR #30: URL: https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2026772190 I don't see any pom.xml to run any mvn command against: I don't know what the initial symptom is (with which artifact goal, during what type of work) and given AFAIK the cur

Re: [PR] [MNG-8077] tolerate injected timestamp value [maven-artifact-plugin]

2024-03-28 Thread via GitHub
rmannibucau commented on PR #30: URL: https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2025273864 @hboutemy you can check the test, the log.error will be emitted if you use a property instead of a hardcoded value which adds maintenance burden (either force a manual step

Re: [PR] [MNG-8077] tolerate injected timestamp value [maven-artifact-plugin]

2024-03-28 Thread via GitHub
hboutemy commented on PR #30: URL: https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2025223379 I mostly disagree on why fixed value is or not a good idea (and how to. do it) but I agree that some people may prefer to inject last git commit time: please share a pr

Re: [PR] [MNG-8077] tolerate injected timestamp value [maven-artifact-plugin]

2024-03-25 Thread via GitHub
rmannibucau commented on PR #30: URL: https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2017402158 Goal is really to enable the value to be a property from the project but not hardcoded. Typically it is injected from a plugin in initialize phase (git commit id plugin

Re: [PR] [MNG-8077] tolerate injected timestamp value [maven-artifact-plugin]

2024-03-25 Thread via GitHub
hboutemy commented on PR #30: URL: https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2017385334 IIUC, it's about not displaying an ERROR message when build run as `mvn -Dproject.build.outputTimestamp=xxx`? (and improving error message with full XML proposal including a

Re: [PR] [MNG-8077] tolerate injected timestamp value [maven-artifact-plugin]

2024-03-25 Thread via GitHub
hboutemy commented on PR #30: URL: https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2017380552 issue moved to https://issues.apache.org/jira/browse/MARTIFACT-59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git