gnodet commented on PR #1388:
URL: https://github.com/apache/maven/pull/1388#issuecomment-1973300906
Superseded by https://github.com/apache/maven/pull/1433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
gnodet closed pull request #1388: [MNG-8024] Make WrapperProperties and
WrapperList serizalizable.
URL: https://github.com/apache/maven/pull/1388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gnodet commented on PR #1388:
URL: https://github.com/apache/maven/pull/1388#issuecomment-1906223854
> > Yes, that is exactly what is happening, the incremental build basically
taks "bits" of model and would like to serialize those with DataOutputStream...
>
> I'm not sure we should s
gnodet commented on PR #1388:
URL: https://github.com/apache/maven/pull/1388#issuecomment-1906038901
> Yes, that is exactly what is happening, the incremental build basically
taks "bits" of model and would like to serialize those with DataOutputStream...
I'm not sure we should support
cstamas commented on PR #1388:
URL: https://github.com/apache/maven/pull/1388#issuecomment-1905890251
Yes, that is exactly what is happening, the incremental build basically taks
"bits" of model and would like to serialize those with DataOutputStream...
--
This is an automated message fro
gnodet commented on PR #1388:
URL: https://github.com/apache/maven/pull/1388#issuecomment-1904473390
> We need a clear unit test. Basic serialisation is already supported, so
something's wrong... The `WrapperList` and `WrapperProperties` should not
actually be used during serialisation, as
gnodet commented on code in PR #1388:
URL: https://github.com/apache/maven/pull/1388#discussion_r1462051148
##
src/mdo/java/WrapperList.java:
##
@@ -27,16 +27,21 @@
import java.util.function.Supplier;
class WrapperList extends AbstractList {
Review Comment:
What's the po
gnodet commented on PR #1388:
URL: https://github.com/apache/maven/pull/1388#issuecomment-1904273419
We need to extend the unit test
https://github.com/apache/maven/blob/master/maven-model/src/test/java/org/apache/maven/model/SerializationTest.java
to exercise the actual problem.
