Re: [PR] [MNG-8001] Expose CoreRealm internally [maven]

2024-01-10 Thread via GitHub
cstamas merged PR #1369: URL: https://github.com/apache/maven/pull/1369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

Re: [PR] [MNG-8001] Expose CoreRealm internally [maven]

2024-01-10 Thread via GitHub
michael-o commented on PR #1369: URL: https://github.com/apache/maven/pull/1369#issuecomment-1884716100 > > Why is this necessary? > > To confine passing around PlexusContainer, basically to remove it (or "hide" it well) even in Maven core OK, this basically applies a decorator

Re: [PR] [MNG-8001] Expose CoreRealm internally [maven]

2024-01-10 Thread via GitHub
cstamas commented on PR #1369: URL: https://github.com/apache/maven/pull/1369#issuecomment-1884692235 > Why is this necessary? To contain passing around PlexusContainer, basically to remove it (or "hide" it well) even in Maven core -- This is an automated message from the Apache Gi

Re: [PR] [MNG-8001] Expose CoreRealm internally [maven]

2024-01-10 Thread via GitHub
michael-o commented on PR #1369: URL: https://github.com/apache/maven/pull/1369#issuecomment-1884611950 Why is this necessary? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [MNG-8001] Expose CoreRealm internally [maven]

2024-01-10 Thread via GitHub
cstamas commented on code in PR #1369: URL: https://github.com/apache/maven/pull/1369#discussion_r1447174451 ## maven-core/src/main/java/org/apache/maven/internal/CoreRealm.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] [MNG-8001] Expose CoreRealm internally [maven]

2024-01-10 Thread via GitHub
gnodet commented on code in PR #1369: URL: https://github.com/apache/maven/pull/1369#discussion_r1447171055 ## maven-core/src/main/java/org/apache/maven/internal/CoreRealm.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co