Re: [PR] [MNG-7982] Switch to enable transitivity in depMgr used by Maven [maven]

2024-01-11 Thread via GitHub
cstamas merged PR #1357: URL: https://github.com/apache/maven/pull/1357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

Re: [PR] [MNG-7982] Switch to enable transitivity in depMgr used by Maven [maven]

2024-01-11 Thread via GitHub
cstamas commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1887094814 > I mean you build the project with maven 4, upload to central, and a maven 3 projects depends on it. Yes, in that case they may be differences. BUT, since we talk about _two distinc

Re: [PR] [MNG-7982] Switch to enable transitivity in depMgr used by Maven [maven]

2024-01-11 Thread via GitHub
gnodet commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1887066792 > > However, I have no idea what the impact is if one builds a project with the _transitive_ dependency manager, but uses it with the _classic_ one in Maven 3. Could that break the consumer

Re: [PR] [MNG-7982] Switch to enable transitivity in depMgr used by Maven [maven]

2024-01-11 Thread via GitHub
cstamas commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1886835845 Yes, we have separate issue for that https://github.com/apache/maven/pull/1373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] [MNG-7982] Switch to enable transitivity in depMgr used by Maven [maven]

2024-01-11 Thread via GitHub
gnodet commented on code in PR #1357: URL: https://github.com/apache/maven/pull/1357#discussion_r1448599723 ## pom.xml: ## @@ -176,7 +176,7 @@ under the License. 1.26 1.0.0 4.0.1 -2.0.0-alpha-5 +2.0.0-alpha-6 Review Comment: This should be in a separat

Re: [PR] [MNG-7982] Switch to enable transitivity in depMgr used by Maven [maven]

2024-01-08 Thread via GitHub
cstamas commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1880869332 > However, I have no idea what the impact is if one builds a project with the _transitive_ dependency manager, but uses it with the _classic_ one in Maven 3. Could that break the consumer s

Re: [PR] [MNG-7982] Switch to enable transitivity in depMgr used by Maven [maven]

2023-12-20 Thread via GitHub
gnodet commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1865512751 > Hmm, still thinking a bit out loud but at some point it was discussed that the consumed pom would be "cleaned for central" (flatten maven plugin like etc) to ensure the consumers see it as

Re: [PR] [MNG-7982] Switch to enable transitivity in depMgr used by Maven [maven]

2023-12-20 Thread via GitHub
rmannibucau commented on PR #1357: URL: https://github.com/apache/maven/pull/1357#issuecomment-1864990604 Hmm, still thinking a bit out loud but at some point it was discussed that the consumed pom would be "cleaned for central" (flatten maven plugin like etc) to ensure the consumers see it