Re: [PR] [MNG-7950][MNG-7951] Allow use of custom VersionScheme [maven]

2023-12-16 Thread via GitHub
cstamas commented on PR #1337: URL: https://github.com/apache/maven/pull/1337#issuecomment-1858911606 Reworked PR: stepped off selector, it was reverted (see https://issues.apache.org/jira/browse/MRESOLVER-457 and read why it was bad idea). All simpler now. -- This is an automated messag

Re: [PR] [MNG-7950][MNG-7951] Allow use of custom VersionScheme [maven]

2023-12-15 Thread via GitHub
cstamas commented on PR #1337: URL: https://github.com/apache/maven/pull/1337#issuecomment-1858125936 The goal of this PR is to allow _transparently_ per-session choice of `VersionScheme`. The "transparently" means that even the constructed object graph can be retained, as all the selection

Re: [PR] [MNG-7950][MNG-7951] Allow use of custom VersionScheme [maven]

2023-12-15 Thread via GitHub
gnodet commented on PR #1337: URL: https://github.com/apache/maven/pull/1337#issuecomment-1858101613 I'm not sure I'm buying the use of the additional indirection for the `VersionSchemeSelector`. I wonder if it would be just as simple to be injected with a `VersionScheme`. If users want t