gnodet merged PR #1296:
URL: https://github.com/apache/maven/pull/1296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o
sebastien-doyon commented on PR #1296:
URL: https://github.com/apache/maven/pull/1296#issuecomment-1803979760
@gnodet I just fixed a format problem that made the build fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
sebastien-doyon commented on PR #1296:
URL: https://github.com/apache/maven/pull/1296#issuecomment-1803945482
@gnodet your changes are cleaner. I agree with your contribution, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
sebastien-doyon commented on code in PR #1296:
URL: https://github.com/apache/maven/pull/1296#discussion_r1367546942
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/FileSizeFormat.java:
##
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
sebastien-doyon commented on code in PR #1296:
URL: https://github.com/apache/maven/pull/1296#discussion_r1367520121
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/FileSizeFormat.java:
##
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
gnodet commented on code in PR #1296:
URL: https://github.com/apache/maven/pull/1296#discussion_r1367394828
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/FileSizeFormat.java:
##
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
sebastien-doyon commented on code in PR #1296:
URL: https://github.com/apache/maven/pull/1296#discussion_r1367135089
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/FileSizeFormat.java:
##
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
gnodet commented on code in PR #1296:
URL: https://github.com/apache/maven/pull/1296#discussion_r136706
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/FileSizeFormat.java:
##
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
sebastien-doyon opened a new pull request, #1296:
URL: https://github.com/apache/maven/pull/1296
- `BatchModeMavenTransferListener` removed
- `FileSizeFormat` moved to top level class
- `FileSizeFormat.formatProcess()` refactored to accept an StringBuilder
as argument
- `FileSizeF
