Re: [PR] [MNG-6036] Add namespace to XmlNode [maven]

2023-11-27 Thread via GitHub
gnodet merged PR #1318: URL: https://github.com/apache/maven/pull/1318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

Re: [PR] [MNG-6036] Add namespace to XmlNode [maven]

2023-11-20 Thread via GitHub
gnodet commented on code in PR #1318: URL: https://github.com/apache/maven/pull/1318#discussion_r1400146352 ## maven-xml-impl/src/main/java/org/apache/maven/internal/xml/XmlNodeBuilder.java: ## @@ -176,6 +176,8 @@ public static XmlNodeImpl build(XMLStreamReader parser, InputLoc

Re: [PR] [MNG-6036] Add namespace to XmlNode [maven]

2023-11-20 Thread via GitHub
gnodet commented on code in PR #1318: URL: https://github.com/apache/maven/pull/1318#discussion_r1400146599 ## maven-xml-impl/src/main/java/org/apache/maven/internal/xml/XmlNodeBuilder.java: ## @@ -176,6 +176,8 @@ public static XmlNodeImpl build(XMLStreamReader parser, InputLoc

Re: [PR] [MNG-6036] Add namespace to XmlNode [maven]

2023-11-20 Thread via GitHub
gnodet commented on code in PR #1318: URL: https://github.com/apache/maven/pull/1318#discussion_r1400142226 ## maven-xml-impl/src/main/java/org/apache/maven/internal/xml/XmlNodeWriter.java: ## @@ -18,49 +18,146 @@ */ package org.apache.maven.internal.xml; -import java.io.Pr

Re: [PR] [MNG-6036] Add namespace to XmlNode [maven]

2023-11-20 Thread via GitHub
elharo commented on code in PR #1318: URL: https://github.com/apache/maven/pull/1318#discussion_r1399477511 ## maven-xml-impl/src/main/java/org/apache/maven/internal/xml/XmlNodeWriter.java: ## @@ -18,49 +18,146 @@ */ package org.apache.maven.internal.xml; -import java.io.Pr

Re: [PR] [MNG-6036] Add namespace to XmlNode [maven]

2023-11-20 Thread via GitHub
gnodet commented on code in PR #1318: URL: https://github.com/apache/maven/pull/1318#discussion_r1399155019 ## maven-xml-impl/src/main/java/org/apache/maven/internal/xml/XmlNodeWriter.java: ## @@ -18,49 +18,146 @@ */ package org.apache.maven.internal.xml; -import java.io.Pr

Re: [PR] [MNG-6036] Add namespace to XmlNode [maven]

2023-11-20 Thread via GitHub
gnodet commented on code in PR #1318: URL: https://github.com/apache/maven/pull/1318#discussion_r1399153026 ## maven-xml-impl/src/main/java/org/apache/maven/internal/xml/XmlNodeWriter.java: ## @@ -18,49 +18,146 @@ */ package org.apache.maven.internal.xml; -import java.io.Pr

Re: [PR] [MNG-6036] Add namespace to XmlNode [maven]

2023-11-20 Thread via GitHub
elharo commented on code in PR #1318: URL: https://github.com/apache/maven/pull/1318#discussion_r1399113172 ## maven-xml-impl/src/main/java/org/apache/maven/internal/xml/XmlNodeBuilder.java: ## @@ -176,6 +176,8 @@ public static XmlNodeImpl build(XMLStreamReader parser, InputLoc