hboutemy commented on PR #1444:
URL: https://github.com/apache/maven/pull/1444#issuecomment-2018518340
I'll propose a PR to fix my mistakes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
hboutemy commented on PR #1444:
URL: https://github.com/apache/maven/pull/1444#issuecomment-2017656398
and re-reading Jira issue description
https://issues.apache.org/jira/browse/MNG-7570 "there is currently no element
for this on the plugin descriptor", it was true for 4 but not completely
hboutemy commented on PR #1444:
URL: https://github.com/apache/maven/pull/1444#issuecomment-2017651584
still there in Maven 3.9.x
https://github.com/apache/maven/blob/maven-3.9.x/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java#L189
oh, now I se
hboutemy commented on PR #1444:
URL: https://github.com/apache/maven/pull/1444#issuecomment-2017634033
history is complex: when the fiels has been introduced in 3.0.2, it has been
filled
https://github.com/apache/maven/commit/40fb1880ae8ea832e822e975168919bc56239dca#diff-8a738ae425b439d6a52
hboutemy commented on PR #1444:
URL: https://github.com/apache/maven/pull/1444#issuecomment-2017619482
don't hesitate to update description: yes, history is complex between field
addition and its usage
--
This is an automated message from the Apache Git Service.
To respond to the message,
kwin commented on PR #1444:
URL: https://github.com/apache/maven/pull/1444#issuecomment-2017511014
As you can see in
https://github.com/apache/maven/blob/eae39474cbb5a88048cea76709321f20e2f42b0b/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilder.java#L4
hboutemy commented on PR #1444:
URL: https://github.com/apache/maven/pull/1444#issuecomment-2017419219
I see you added the field to .mdo in
https://github.com/apache/maven/pull/832/files#diff-62346c3118817c527a41027bab54349b463add4c91df98f95984012304378c87
the fact is that mdo was not
kwin commented on PR #1444:
URL: https://github.com/apache/maven/pull/1444#issuecomment-2011397677
@hboutemy I am confused by this PR. MNG-4840 iss not about plugin
descriptors but about POMs. The required Maven version in plugin descriptors
has been added in just recently and is only evalu
hboutemy merged PR #1445:
URL: https://github.com/apache/maven/pull/1445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache
hboutemy merged PR #1444:
URL: https://github.com/apache/maven/pull/1444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache
10 matches
Mail list logo
