Re: [PR] [MJLINK-83] Implement multiple launcher elements [maven-jlink-plugin]

olamy merged PR #202: URL: https://github.com/apache/maven-jlink-plugin/pull/202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mave

Re: [PR] [MJLINK-83] Implement multiple launcher elements [maven-jlink-plugin]

pedro-w commented on PR #202: URL: https://github.com/apache/maven-jlink-plugin/pull/202#issuecomment-2235824828 OK if I understand correctly we're going back to reflection because `setVariableValueToObject` is (as far as I can see) only in version 4.0.0-SNAPSHOT of the plugin test harness

Re: [PR] [MJLINK-83] Implement multiple launcher elements [maven-jlink-plugin]

olamy commented on PR #202: URL: https://github.com/apache/maven-jlink-plugin/pull/202#issuecomment-2230311504 > I've been able to do it using your second suggested method, i.e. using `org.apache.maven.api.plugin.testing.MojoExtension.setVariableValueToObject` > > The calls now look

Re: [PR] [MJLINK-83] Implement multiple launcher elements [maven-jlink-plugin]

pedro-w commented on PR #202: URL: https://github.com/apache/maven-jlink-plugin/pull/202#issuecomment-2230305065 I've been able to do it using your second suggested method, i.e. using `org.apache.maven.api.plugin.testing.MojoExtension.setVariableValueToObject` The calls now look like

Re: [PR] [MJLINK-83] Implement multiple launcher elements [maven-jlink-plugin]

olamy commented on PR #202: URL: https://github.com/apache/maven-jlink-plugin/pull/202#issuecomment-2228186614 > I will look into that. I based the first attempt on the [existing test](https://github.com/apache/maven-jlink-plugin/blob/master/src/test/java/org/apache/maven/plugins/jlink/JLin

Re: [PR] [MJLINK-83] Implement multiple launcher elements [maven-jlink-plugin]

pedro-w commented on PR #202: URL: https://github.com/apache/maven-jlink-plugin/pull/202#issuecomment-2228159654 I will look into that. I based the first attempt on the [existing test](https://github.com/apache/maven-jlink-plugin/blob/master/src/test/java/org/apache/maven/plugins/jlink/JLin

Re: [PR] [MJLINK-83] Implement multiple launcher elements [maven-jlink-plugin]

olamy commented on PR #202: URL: https://github.com/apache/maven-jlink-plugin/pull/202#issuecomment-2228129614 > I have added a new test class as requested @olamy Thanks. I would prefer avoid using the technique of reflection and prefer using something such https://github.com/apache

Re: [PR] [MJLINK-83] Implement multiple launcher elements [maven-jlink-plugin]

pedro-w commented on PR #202: URL: https://github.com/apache/maven-jlink-plugin/pull/202#issuecomment-2228096034 I have added a new test class as requested @olamy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] [MJLINK-83] Implement multiple launcher elements [maven-jlink-plugin]

olamy commented on PR #202: URL: https://github.com/apache/maven-jlink-plugin/pull/202#issuecomment-2227662257 sounds good. Could you please add a simple test for this new feature? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] [MJLINK-83] Implement multiple launcher elements [maven-jlink-plugin]

vietj commented on PR #202: URL: https://github.com/apache/maven-jlink-plugin/pull/202#issuecomment-2227214927 I do support this feature that is useful -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [MJLINK-83] Implement multiple launcher elements [maven-jlink-plugin]

pedro-w opened a new pull request, #202: URL: https://github.com/apache/maven-jlink-plugin/pull/202 This is a simple change to allow the Maven plugin to generate more than one launcher in a `jlink` image. The `jlink` tool itself already supports this, but there was no way to pass the requir