Re: [PR] [MBUILDCACHE-96] Remove use of maven-compat [maven-build-cache-extension]

2024-08-12 Thread via GitHub
olamy merged PR #171: URL: https://github.com/apache/maven-build-cache-extension/pull/171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

Re: [PR] [MBUILDCACHE-96] Remove use of maven-compat [maven-build-cache-extension]

2024-08-12 Thread via GitHub
cstamas commented on PR #171: URL: https://github.com/apache/maven-build-cache-extension/pull/171#issuecomment-2283723710 Perso, I'd not mix maven-artifact and resolver Artifact/Version stuff, but that is not related to PR goal, so might be done in some subsequent PR. -- This is an autom

Re: [PR] [MBUILDCACHE-96] Remove use of maven-compat [maven-build-cache-extension]

2024-08-12 Thread via GitHub
cstamas commented on code in PR #171: URL: https://github.com/apache/maven-build-cache-extension/pull/171#discussion_r1713592672 ## src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java: ## @@ -684,51 +801,58 @@ private SortedMap getMutableDependenciesHashe

Re: [PR] [MBUILDCACHE-96] Remove use of maven-compat [maven-build-cache-extension]

2024-08-12 Thread via GitHub
cstamas commented on code in PR #171: URL: https://github.com/apache/maven-build-cache-extension/pull/171#discussion_r1713592139 ## src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java: ## @@ -684,51 +801,58 @@ private SortedMap getMutableDependenciesHashe

Re: [PR] [MBUILDCACHE-96] Remove use of maven-compat [maven-build-cache-extension]

2024-08-12 Thread via GitHub
olamy commented on code in PR #171: URL: https://github.com/apache/maven-build-cache-extension/pull/171#discussion_r1713579111 ## src/main/java/org/apache/maven/buildcache/DefaultProjectInputCalculator.java: ## @@ -27,13 +27,15 @@ import java.util.concurrent.ConcurrentMap;

Re: [PR] [MBUILDCACHE-96] Remove use of maven-compat [maven-build-cache-extension]

2024-08-12 Thread via GitHub
cstamas commented on code in PR #171: URL: https://github.com/apache/maven-build-cache-extension/pull/171#discussion_r1713562746 ## src/main/java/org/apache/maven/buildcache/DefaultProjectInputCalculator.java: ## @@ -27,13 +27,15 @@ import java.util.concurrent.ConcurrentMap;

Re: [PR] [MBUILDCACHE-96] Remove use of maven-compat [maven-build-cache-extension]

2024-08-12 Thread via GitHub
olamy commented on code in PR #171: URL: https://github.com/apache/maven-build-cache-extension/pull/171#discussion_r1713561956 ## src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java: ## @@ -684,51 +804,58 @@ private SortedMap getMutableDependenciesHashes(

Re: [PR] [MBUILDCACHE-96] Remove use of maven-compat [maven-build-cache-extension]

2024-08-12 Thread via GitHub
cstamas commented on code in PR #171: URL: https://github.com/apache/maven-build-cache-extension/pull/171#discussion_r1713548688 ## src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java: ## @@ -684,51 +804,58 @@ private SortedMap getMutableDependenciesHashe

[PR] [MBUILDCACHE-96] Remove use of maven-compat [maven-build-cache-extension]

2024-08-11 Thread via GitHub
olamy opened a new pull request, #171: URL: https://github.com/apache/maven-build-cache-extension/pull/171 Signed-off-by: Olivier Lamy Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [MBUILDCACHE JIRA issue]