Re: [PR] [DOXIA-710] Auto-generate anchor for TOC entries [maven-doxia]

2023-12-30 Thread via GitHub
kwin commented on PR #180: URL: https://github.com/apache/maven-doxia/pull/180#issuecomment-1872519693 > can we somehow check it based on our maven-site and the doxia converter? Doesn't affect Doxia Converter, for checking with m-site-p you need a patch for m-site-p and m-doxia-siteto

Re: [PR] [DOXIA-710] Auto-generate anchor for TOC entries [maven-doxia]

2023-12-27 Thread via GitHub
michael-o commented on PR #180: URL: https://github.com/apache/maven-doxia/pull/180#issuecomment-1870606472 @hboutemy Are you able to review within a week or so? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [DOXIA-710] Auto-generate anchor for TOC entries [maven-doxia]

2023-12-27 Thread via GitHub
michael-o commented on code in PR #180: URL: https://github.com/apache/maven-doxia/pull/180#discussion_r1437239607 ## doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/UniqueAnchorNamesValidatorFactory.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] [DOXIA-710] Auto-generate anchor for TOC entries [maven-doxia]

2023-12-27 Thread via GitHub
michael-o commented on code in PR #180: URL: https://github.com/apache/maven-doxia/pull/180#discussion_r1437238183 ## doxia-core/src/main/java/org/apache/maven/doxia/index/IndexEntry.java: ## @@ -53,10 +56,41 @@ public class IndexEntry { */ private List childEntries =

Re: [PR] [DOXIA-710] Auto-generate anchor for TOC entries [maven-doxia]

2023-12-27 Thread via GitHub
kwin commented on code in PR #180: URL: https://github.com/apache/maven-doxia/pull/180#discussion_r1437136714 ## doxia-core/src/main/java/org/apache/maven/doxia/index/IndexEntry.java: ## @@ -53,10 +56,41 @@ public class IndexEntry { */ private List childEntries = new

Re: [PR] [DOXIA-710] Auto-generate anchor for TOC entries [maven-doxia]

2023-12-27 Thread via GitHub
kwin commented on code in PR #180: URL: https://github.com/apache/maven-doxia/pull/180#discussion_r1437134790 ## doxia-core/src/main/java/org/apache/maven/doxia/index/IndexEntry.java: ## @@ -53,10 +56,41 @@ public class IndexEntry { */ private List childEntries = new

Re: [PR] [DOXIA-710] Auto-generate anchor for TOC entries [maven-doxia]

2023-12-23 Thread via GitHub
michael-o commented on code in PR #180: URL: https://github.com/apache/maven-doxia/pull/180#discussion_r1435692207 ## doxia-core/src/main/java/org/apache/maven/doxia/index/IndexEntry.java: ## @@ -53,10 +56,41 @@ public class IndexEntry { */ private List childEntries =

Re: [PR] [DOXIA-710] Auto-generate anchor for TOC entries [maven-doxia]

2023-12-23 Thread via GitHub
michael-o commented on code in PR #180: URL: https://github.com/apache/maven-doxia/pull/180#discussion_r1428911493 ## doxia-core/src/main/java/org/apache/maven/doxia/index/IndexEntry.java: ## @@ -304,7 +310,7 @@ public String toString(int depth) { message.append(",

Re: [PR] [DOXIA-710] Auto-generate anchor for TOC entries [maven-doxia]

2023-12-23 Thread via GitHub
kwin commented on code in PR #180: URL: https://github.com/apache/maven-doxia/pull/180#discussion_r1435592379 ## doxia-core/src/main/java/org/apache/maven/doxia/index/IndexEntry.java: ## @@ -304,7 +310,7 @@ public String toString(int depth) { message.append(", title