Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-436784820
@jglick
You do not have to investigate on Windows. We were talking about it here
because Windows has typically many disks and anyway the `surefirebo
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-436656371
@jglick
This decision must be bullet proof. If we want to go this way, we have to
run a branch with this prototype on Jenkins using multiple JDKs. S
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-436602084
@cstamas
@jglick
@mirabilos
@rockysingh
Version `3.0.0-M1` is on Maven Central now.
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435657984
@cstamas
Thx for contributing. Pls close this PR.
This is an automated message from
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435585356
Feedback for everybody. We are on the Slack ASF chat with @cstamas and we
are fixing and testing old ITs one by one and the changes are being pushed to
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435569639
@cstamas
I have fixed that problem. My bad, the reportsDir should be passed via
method and not constructor to the ForkedCnfig because the dir is par
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435438509
The problem is that `TEST-TestSuite.xml` appears in wrong folder and it
should be in `target/surefire-reports-1` and 2. Not sure how this change could
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435436625
@cstamas
I think nobody run the ITs on this PR. The problem is that we broke the
build with this fix.
There are two failing ITs.
The first one
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435419279
@mirabilos
I understand, but MRESOURCES-237 is a problem of symbolic links in
maven-resources-plugin. Nothing to do with us in my understanding. Do
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435405583
@mirabilos
You can check it out now from our staging repo
https://repository.apache.org/content/repositories/maven-1463. See the guide to
testing s
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435397200
@mirabilos
It will take 3 days or longer. Sorry, this is the process of Vote for the
release. So you are welcome to join our mailing list and Vote t
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435394570
@cstamas
It's in master. The log dump was added too.
I will cut the release.
Thi
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435386856
@cstamas I have already done it in my working copy. Is it necessary to log
it? I removed the log because of what i wrote. But I can accept any of your
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435384927
ok, I am just running a local build and I will push it to master in few
minutes only and then I will start the release Vote. Hoping this helps.
---
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435381394
Are there any objections if I proceed with pushing the fix to master?
Can somebody run a test?
@mirabilos
We are not waiting for 3.0. It is
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435275114
@cstamas Can you please squash the commits in one? Exclude the `pom.xml`
because the master is already on Java 1.7.
---
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435226142
We should see the Manifest. Why this issue does not exist on Windows? I
think it should because the code base is in TEMP since the `surefire.jar`
(sure
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435190994
A new branch `3.0.0-M1-J7` went out.
It contains API 3.0 and Java 1.7 (SUREFIRE-1493 and SUREFIRE-1474).
Let's wait for the Jenkins build...
-
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435186507
@cstamas
@rockysingh
@jglick
Why we did not do it with `java.i.File.toURI()`?
--
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-435146720
Hi @rfscholte . The CLI in shared-utils executes a subprocess and we in
surefire rely on a callback that the process finished. It seems we do not
recei
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-434996412
Now the API 3.0 is applied. I will work on Java 1.7 in that branch.
Btw somebody broke the behavior of maven:shared-utils:3.2.0+. I have to use
older
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-434780362
@cstamas
I will try to do my bets today. Okay?
And then I will ask you to rebase this branch.
We can start release tomorrow.
-
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-434777977
@cstamas
This will be a mess in project. As I said please wait a bit, I will fork the
issues of 3.0.0-M1 to multiple versions and we will make very
Tibor17 commented on issue #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#issuecomment-434721855
Hi @cstamas
Thx for the fix. We will release version 3.0.0-M1 nd we discontinued
versions 2.x.
The only issue is that we develop new version in b
24 matches
Mail list logo
