gnodet commented on PR #703:
URL: https://github.com/apache/maven/pull/703#issuecomment-1237058033
All tests are passing. I'd like to go on and merge this PR (and release an
alpha version if possible). This would allow further work on other components
and plugins (see the various PRs in t
gnodet commented on PR #703:
URL: https://github.com/apache/maven/pull/703#issuecomment-1173690384
> What about
https://github.com/apache/maven/blob/2926f033cb934e7bcef51362639663bc2a39cf9a/maven-core/src/main/java/org/apache/maven/artifact/handler/DefaultArtifactHandler.java
and
https://g
gnodet commented on PR #703:
URL: https://github.com/apache/maven/pull/703#issuecomment-1173518358
> @gnodet Is there already a branch for any of the core plugins, to see if
this API is complete? (i.e. allows to drop all other Maven dependencies)? Which
plugin would be a good candidate for
gnodet commented on PR #703:
URL: https://github.com/apache/maven/pull/703#issuecomment-1173459869
> Is this change planned for Maven 4 only or will be also soon backported to
3.9 line?
No, that's definitely a longer term goal, so maven 4 only.
It would still be experimental for a
gnodet commented on PR #703:
URL: https://github.com/apache/maven/pull/703#issuecomment-1097715774
> First question... Do we want to have a cycles between packages and
interfaces?
> eg:
> `org.apache.maven.api. Session` needs
`org.apache.maven.api.services.ArtifactDeployer`
> and `
gnodet commented on PR #703:
URL: https://github.com/apache/maven/pull/703#issuecomment-1095245409
> First question... Do we want to have a cycles between packages and
interfaces?
> eg:
> `org.apache.maven.api. Session` needs
`org.apache.maven.api.services.ArtifactDeployer`
> and `
gnodet commented on pull request #703:
URL: https://github.com/apache/maven/pull/703#issuecomment-1085701331
> Don;t use `Collections.unmodifiableList(xxx)`. It is vert old style -
before year 2004 where the constructors where not thread safe, a typical
findings with String and final field
gnodet commented on pull request #703:
URL: https://github.com/apache/maven/pull/703#issuecomment-1085598999
> Yes I saw the MDO.
So unless we raise the requirements to JDK 17, I don't see how we could
actually use records / List.of(). That said, I'm not sure there's actually
much
gnodet commented on pull request #703:
URL: https://github.com/apache/maven/pull/703#issuecomment-1085591083
> If we want to use immutable objects, we should use Java Records. We still
do not have Valhalla ready. The developers often do not understand Java Memory
Model and there is no guar
