slawekjaranowski merged PR #238:
URL: https://github.com/apache/maven-enforcer/pull/238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
ArloL commented on code in PR #67:
URL: https://github.com/apache/maven-wrapper/pull/67#discussion_r1082774153
##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -160,7 +160,7 @@ find_maven_basedir() {
# concatenates all lines of a file
concat_lines() {
if [ -f "$1" ];
cstamas commented on PR #907:
URL: https://github.com/apache/maven/pull/907#issuecomment-1398620400
@michael-o pls review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
rmannibucau commented on PR #964:
URL: https://github.com/apache/maven/pull/964#issuecomment-1398368495
-1 for me to get anything not org.apache.maven in maven core, in particular
when test covering is 0 and this can break any time.
+1 to get it maintained where it belongs to only.
--
laeubi commented on PR #964:
URL: https://github.com/apache/maven/pull/964#issuecomment-1398366690
as @cstamas pointed out, only change in XML file would be required, I
updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
slawekjaranowski opened a new pull request, #238:
URL: https://github.com/apache/maven-enforcer/pull/238
- isolate abstract class in api
- fix date format in documentation
- drop maven-shared-utils
- fix javadoc warnings
- drop old classes
---
Following this checklis
winhkey commented on issue #777:
URL: https://github.com/apache/maven-mvnd/issues/777#issuecomment-1398072616
> Simply add `java.home=` into your
`~/.m2/mvnd.properties` file, and you should be fine.
I forgot I have added java.home for 1.8 in .m2/mvnd.properties, now I have
removed m
winhkey commented on issue #777:
URL: https://github.com/apache/maven-mvnd/issues/777#issuecomment-1398071537
>
I forgot I have added java.home for 1.8 in .m2/mvnd.properties, now I have
removed mvnd.properties and it works, thanks~
--
This is an automated message from the Apache
theit commented on issue #777:
URL: https://github.com/apache/maven-mvnd/issues/777#issuecomment-1397988466
Simply add `java.home=` into your
`~/.m2/mvnd.properties` file, and you should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
laeubi closed pull request #230: MRESOLVER-307 - Support listing of workspace
artifacts
URL: https://github.com/apache/maven-resolver/pull/230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
laeubi commented on PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#issuecomment-1397943417
As @cstamas has explained, this might not be useful for resolver if it never
has a need to call the API, so lets close this, probabbly some time later but
it won't be hard to recover
laeubi closed pull request #913: MNG-7630 - Support listing of workspace models
URL: https://github.com/apache/maven/pull/913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
laeubi commented on PR #913:
URL: https://github.com/apache/maven/pull/913#issuecomment-1397941596
I'll close this PR and just try to spin up my own API, even though this will
replicate some code from maven and do not gracefully integrates with other IDEs.
It seams maven is not ready
dependabot[bot] closed pull request #100: Bump modello-maven-plugin from 2.0.0
to 2.1.0
URL: https://github.com/apache/maven-parent/pull/100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
dependabot[bot] commented on PR #100:
URL: https://github.com/apache/maven-parent/pull/100#issuecomment-1397895250
Superseded by #105.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] opened a new pull request, #105:
URL: https://github.com/apache/maven-parent/pull/105
Bumps [modello-maven-plugin](https://github.com/codehaus-plexus/modello)
from 2.0.0 to 2.1.1.
Release notes
Sourced from https://github.com/codehaus-plexus/modello/releases";>model
winhkey opened a new issue, #777:
URL: https://github.com/apache/maven-mvnd/issues/777
https://user-images.githubusercontent.com/4877808/213612658-bae32b40-d36e-405a-89c3-86497aa13846.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please
hboutemy merged PR #949:
URL: https://github.com/apache/maven/pull/949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o
psiroky commented on code in PR #238:
URL:
https://github.com/apache/maven-integration-testing/pull/238#discussion_r1081959748
##
core-it-support/maven-it-plugin-bootstrap/src/main/java/org/apache/maven/its/bootstrap/DownloadMojo.java:
##
@@ -74,7 +74,7 @@
@Component
psiroky commented on code in PR #238:
URL:
https://github.com/apache/maven-integration-testing/pull/238#discussion_r1081958595
##
core-it-support/core-it-plugins/maven-it-plugin-site/pom.xml:
##
@@ -72,6 +72,12 @@ under the License.
org.apache.maven.reporting
mave
psiroky commented on code in PR #238:
URL:
https://github.com/apache/maven-integration-testing/pull/238#discussion_r1081957444
##
core-it-support/core-it-plugins/maven-it-plugin-class-loader/maven-it-plugin-class-loader/pom.xml:
##
@@ -44,6 +44,10 @@ under the License.
2
psiroky commented on code in PR #238:
URL:
https://github.com/apache/maven-integration-testing/pull/238#discussion_r1081957076
##
core-it-support/core-it-javaagent/pom.xml:
##
@@ -53,6 +53,17 @@ under the License.
shade
+
+
psiroky opened a new pull request, #238:
URL: https://github.com/apache/maven-integration-testing/pull/238
Just couple of minor fixes. I realized I had these stashed away for some
time and just forgot to create PR earlier
--
This is an automated message from the Apache Git Service.
To res
rmannibucau commented on code in PR #913:
URL: https://github.com/apache/maven/pull/913#discussion_r1081859598
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenWorkspaceReader.java:
##
@@ -28,4 +29,20 @@
public interface MavenWorkspaceReader ex
laeubi commented on code in PR #913:
URL: https://github.com/apache/maven/pull/913#discussion_r1081687942
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenWorkspaceReader.java:
##
@@ -28,4 +29,20 @@
public interface MavenWorkspaceReader extends
psiroky commented on code in PR #169:
URL:
https://github.com/apache/maven-compiler-plugin/pull/169#discussion_r1081657329
##
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##
@@ -1814,29 +1810,26 @@ private List resolveProcessorPathEntries()
psiroky commented on code in PR #169:
URL:
https://github.com/apache/maven-compiler-plugin/pull/169#discussion_r1081648930
##
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##
@@ -1814,29 +1810,26 @@ private List resolveProcessorPathEntries()
rmannibucau commented on code in PR #913:
URL: https://github.com/apache/maven/pull/913#discussion_r1081652684
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenWorkspaceReader.java:
##
@@ -28,4 +29,20 @@
public interface MavenWorkspaceReader ex
michael-o commented on code in PR #913:
URL: https://github.com/apache/maven/pull/913#discussion_r1081651908
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenWorkspaceReader.java:
##
@@ -28,4 +29,20 @@
public interface MavenWorkspaceReader exte
ajarmoniuk commented on code in PR #169:
URL:
https://github.com/apache/maven-compiler-plugin/pull/169#discussion_r1081650624
##
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##
@@ -1814,29 +1810,26 @@ private List resolveProcessorPathEntries()
ajarmoniuk commented on code in PR #169:
URL:
https://github.com/apache/maven-compiler-plugin/pull/169#discussion_r1081650624
##
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##
@@ -1814,29 +1810,26 @@ private List resolveProcessorPathEntries()
psiroky commented on code in PR #169:
URL:
https://github.com/apache/maven-compiler-plugin/pull/169#discussion_r1081648930
##
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##
@@ -1814,29 +1810,26 @@ private List resolveProcessorPathEntries()
cstamas commented on code in PR #169:
URL:
https://github.com/apache/maven-compiler-plugin/pull/169#discussion_r1081646808
##
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##
@@ -1814,29 +1810,26 @@ private List resolveProcessorPathEntries()
psiroky commented on PR #371:
URL: https://github.com/apache/maven-site/pull/371#issuecomment-1397407845
@slawekjaranowski I removed the example and just linked the Getting Started
guide. Please take another look if this looks like something you had in mind.
Thanks!
--
This is an automat
ajarmoniuk commented on code in PR #169:
URL:
https://github.com/apache/maven-compiler-plugin/pull/169#discussion_r1081635311
##
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##
@@ -1814,29 +1810,26 @@ private List resolveProcessorPathEntries()
laeubi commented on code in PR #913:
URL: https://github.com/apache/maven/pull/913#discussion_r1081641445
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenWorkspaceReader.java:
##
@@ -28,4 +29,20 @@
public interface MavenWorkspaceReader extends
ajarmoniuk commented on code in PR #169:
URL:
https://github.com/apache/maven-compiler-plugin/pull/169#discussion_r1081635311
##
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##
@@ -1814,29 +1810,26 @@ private List resolveProcessorPathEntries()
psiroky commented on code in PR #169:
URL:
https://github.com/apache/maven-compiler-plugin/pull/169#discussion_r1081610573
##
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##
@@ -1814,29 +1810,26 @@ private List resolveProcessorPathEntries()
rmannibucau commented on code in PR #913:
URL: https://github.com/apache/maven/pull/913#discussion_r1081611183
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenWorkspaceReader.java:
##
@@ -28,4 +29,20 @@
public interface MavenWorkspaceReader ex
psiroky commented on code in PR #169:
URL:
https://github.com/apache/maven-compiler-plugin/pull/169#discussion_r1081610573
##
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##
@@ -1814,29 +1810,26 @@ private List resolveProcessorPathEntries()
cstamas closed pull request #151: Move away from legacy maven-compat
URL: https://github.com/apache/maven-compiler-plugin/pull/151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
cstamas commented on PR #151:
URL:
https://github.com/apache/maven-compiler-plugin/pull/151#issuecomment-1397336608
Superseded by https://github.com/apache/maven-compiler-plugin/pull/169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ajarmoniuk commented on code in PR #169:
URL:
https://github.com/apache/maven-compiler-plugin/pull/169#discussion_r1081577830
##
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##
@@ -1814,29 +1810,26 @@ private List resolveProcessorPathEntries()
ajarmoniuk commented on code in PR #169:
URL:
https://github.com/apache/maven-compiler-plugin/pull/169#discussion_r1081577830
##
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##
@@ -1814,29 +1810,26 @@ private List resolveProcessorPathEntries()
ajarmoniuk commented on code in PR #151:
URL:
https://github.com/apache/maven-compiler-plugin/pull/151#discussion_r1081577683
##
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##
@@ -1841,29 +1838,36 @@ private List resolveProcessorPathEntries()
michael-o commented on PR #964:
URL: https://github.com/apache/maven/pull/964#issuecomment-1397306568
For me, this seems hardless. I'd like to know what others think. @gnodet
@cstamas @hboutemy
--
This is an automated message from the Apache Git Service.
To respond to the message, please
psiroky commented on PR #371:
URL: https://github.com/apache/maven-site/pull/371#issuecomment-1397304613
Yeah, I guess the whole page could use some reworking (e.g. not recommending
junit 3.x `AbstractMojoTestCase`). I just found these changes I had in the
maven-site repo and figured it is
laeubi commented on PR #964:
URL: https://github.com/apache/maven/pull/964#issuecomment-1397301706
> I think this should be master first.
I can create one for master as well, but if its not accepted for 3.9 it does
not make much sense to port it (as master is a bit different one can't
michael-o commented on PR #964:
URL: https://github.com/apache/maven/pull/964#issuecomment-1397296927
I think this should be master first.
What about lifecycles?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
laeubi opened a new pull request, #964:
URL: https://github.com/apache/maven/pull/964
Since a while Tycho is going more and more "maven-like" so today even more
Tycho artifacts approaching at maven-central.
In some circumstances this leads to strange problems, because Dependencies
ha
slawekjaranowski merged PR #237:
URL: https://github.com/apache/maven-enforcer/pull/237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
gnodet commented on code in PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#discussion_r1081479002
##
maven-resolver-api/src/main/java/org/eclipse/aether/repository/WorkspaceReader.java:
##
@@ -21,13 +21,18 @@
import java.io.File;
import java.util.List;
+impo
laeubi commented on code in PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#discussion_r1081454851
##
maven-resolver-api/src/main/java/org/eclipse/aether/repository/WorkspaceReader.java:
##
@@ -21,13 +21,18 @@
import java.io.File;
import java.util.List;
+impo
slawekjaranowski commented on PR #371:
URL: https://github.com/apache/maven-site/pull/371#issuecomment-1397151426
I would go a step forward, general page should only contains general
description about tools, and links to pages maintained by tools.
In Verifier case we have:
https://maven
cstamas commented on code in PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#discussion_r1081401160
##
maven-resolver-api/src/main/java/org/eclipse/aether/repository/WorkspaceReader.java:
##
@@ -21,13 +21,18 @@
import java.io.File;
import java.util.List;
+imp
laeubi commented on code in PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#discussion_r1081395840
##
maven-resolver-api/src/main/java/org/eclipse/aether/repository/WorkspaceReader.java:
##
@@ -21,13 +21,18 @@
import java.io.File;
import java.util.List;
+impo
psiroky commented on code in PR #371:
URL: https://github.com/apache/maven-site/pull/371#discussion_r1081338234
##
content/apt/plugin-developers/plugin-testing.apt:
##
@@ -144,16 +144,16 @@ public class TrivialMavenVerifierTest extends TestCase
verifier.deleteArtifact(
psiroky commented on code in PR #371:
URL: https://github.com/apache/maven-site/pull/371#discussion_r1081338234
##
content/apt/plugin-developers/plugin-testing.apt:
##
@@ -144,16 +144,16 @@ public class TrivialMavenVerifierTest extends TestCase
verifier.deleteArtifact(
psiroky opened a new pull request, #371:
URL: https://github.com/apache/maven-site/pull/371
* addCliOption() and resetStreams() are deprecated in the current verifier
version (2.0.0-M1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
gnodet commented on code in PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#discussion_r1081330592
##
maven-resolver-api/src/main/java/org/eclipse/aether/repository/WorkspaceReader.java:
##
@@ -55,4 +60,11 @@
*/
List findVersions( Artifact artifact );
gnodet commented on code in PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#discussion_r1081324959
##
maven-resolver-api/src/main/java/org/eclipse/aether/repository/WorkspaceReader.java:
##
@@ -21,13 +21,18 @@
import java.io.File;
import java.util.List;
+impo
laeubi commented on code in PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#discussion_r1081304362
##
maven-resolver-api/src/main/java/org/eclipse/aether/repository/WorkspaceReader.java:
##
@@ -55,4 +60,11 @@
*/
List findVersions( Artifact artifact );
laeubi commented on code in PR #913:
URL: https://github.com/apache/maven/pull/913#discussion_r1081279805
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenWorkspaceReader.java:
##
@@ -28,4 +29,20 @@
public interface MavenWorkspaceReader extends
rmannibucau commented on code in PR #913:
URL: https://github.com/apache/maven/pull/913#discussion_r1081260241
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenWorkspaceReader.java:
##
@@ -28,4 +29,20 @@
public interface MavenWorkspaceReader ex
gnodet commented on code in PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#discussion_r1081249124
##
maven-resolver-api/src/main/java/org/eclipse/aether/repository/WorkspaceReader.java:
##
@@ -55,4 +60,11 @@
*/
List findVersions( Artifact artifact );
michael-o commented on code in PR #913:
URL: https://github.com/apache/maven/pull/913#discussion_r1081238732
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenWorkspaceReader.java:
##
@@ -28,4 +29,20 @@
public interface MavenWorkspaceReader exte
dependabot[bot] closed pull request #74: Bump modello-maven-plugin from 2.0.0
to 2.1.0
URL: https://github.com/apache/maven-antrun-plugin/pull/74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] commented on PR #74:
URL:
https://github.com/apache/maven-antrun-plugin/pull/74#issuecomment-1396940532
Superseded by #76.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
dependabot[bot] opened a new pull request, #76:
URL: https://github.com/apache/maven-antrun-plugin/pull/76
Bumps [modello-maven-plugin](https://github.com/codehaus-plexus/modello)
from 2.0.0 to 2.1.1.
Release notes
Sourced from https://github.com/codehaus-plexus/modello/releases";>
laeubi commented on code in PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#discussion_r1081222797
##
maven-resolver-api/src/main/java/org/eclipse/aether/repository/WorkspaceReader.java:
##
@@ -55,4 +60,11 @@
*/
List findVersions( Artifact artifact );
laeubi commented on code in PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#discussion_r1081211988
##
maven-resolver-api/src/main/java/org/eclipse/aether/repository/WorkspaceReader.java:
##
@@ -55,4 +60,11 @@
*/
List findVersions( Artifact artifact );
laeubi commented on code in PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#discussion_r1081211988
##
maven-resolver-api/src/main/java/org/eclipse/aether/repository/WorkspaceReader.java:
##
@@ -55,4 +60,11 @@
*/
List findVersions( Artifact artifact );
gnodet commented on code in PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#discussion_r1081198571
##
maven-resolver-api/src/main/java/org/eclipse/aether/repository/WorkspaceReader.java:
##
@@ -55,4 +60,11 @@
*/
List findVersions( Artifact artifact );
laeubi commented on code in PR #913:
URL: https://github.com/apache/maven/pull/913#discussion_r1081186329
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenWorkspaceReader.java:
##
@@ -28,4 +29,20 @@
public interface MavenWorkspaceReader extends
laeubi commented on code in PR #913:
URL: https://github.com/apache/maven/pull/913#discussion_r1081186329
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenWorkspaceReader.java:
##
@@ -28,4 +29,20 @@
public interface MavenWorkspaceReader extends
rmannibucau commented on code in PR #913:
URL: https://github.com/apache/maven/pull/913#discussion_r1081182626
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenWorkspaceReader.java:
##
@@ -28,4 +29,20 @@
public interface MavenWorkspaceReader ex
psiroky commented on PR #151:
URL:
https://github.com/apache/maven-compiler-plugin/pull/151#issuecomment-1396837771
I think we can close this one in favor of #169. Thanks @cstamas for the
initial changes!
--
This is an automated message from the Apache Git Service.
To respond to the mess
psiroky commented on code in PR #169:
URL:
https://github.com/apache/maven-compiler-plugin/pull/169#discussion_r1081140364
##
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##
@@ -1814,29 +1810,26 @@ private List resolveProcessorPathEntries()
ajarmoniuk commented on PR #169:
URL:
https://github.com/apache/maven-compiler-plugin/pull/169#issuecomment-1396835348
No problem, I'll do that in the evening
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
psiroky commented on PR #169:
URL:
https://github.com/apache/maven-compiler-plugin/pull/169#issuecomment-1396834486
@ajarmoniuk would you have some time to review? (since you did similar
changes in other plugins)
--
This is an automated message from the Apache Git Service.
To respond to
psiroky opened a new pull request, #169:
URL: https://github.com/apache/maven-compiler-plugin/pull/169
* heavily based on work by @cstamas (PR #151)
* added IT to verify the build fails if one the dependencies cannot be
resolved (e.g. does not exist)
Following this checkl
gnodet merged PR #954:
URL: https://github.com/apache/maven/pull/954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
gnodet merged PR #234:
URL: https://github.com/apache/maven-integration-testing/pull/234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr
slawekjaranowski merged PR #236:
URL: https://github.com/apache/maven-enforcer/pull/236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
psiroky commented on PR #151:
URL:
https://github.com/apache/maven-compiler-plugin/pull/151#issuecomment-1396717655
@cstamas @ajarmoniuk I'll take a look then. I think it will be a nice way
way to get a bit more understanding how the dependency resolution stuff works.
I would possibly reac
gnodet merged PR #776:
URL: https://github.com/apache/maven-mvnd/pull/776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apach
ajarmoniuk commented on PR #151:
URL:
https://github.com/apache/maven-compiler-plugin/pull/151#issuecomment-1396701600
@psiroky let me know if you want to do it, otherwise I'll do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rmannibucau commented on code in PR #913:
URL: https://github.com/apache/maven/pull/913#discussion_r1081012109
##
maven-core/src/main/java/org/apache/maven/internal/aether/MavenChainedWorkspaceReader.java:
##
@@ -60,6 +62,31 @@ public Model findModel(Artifact artifact) {
cstamas commented on PR #151:
URL:
https://github.com/apache/maven-compiler-plugin/pull/151#issuecomment-1396620806
Toss a coin then :coin:
I am currently unable to continue this PR, and I'd hate anyone being
hindered by sitting and waiting for this PR to land...
--
This is an a
michael-o commented on PR #913:
URL: https://github.com/apache/maven/pull/913#issuecomment-1396619075
> > > > pls rebase against latest maven-3.9.x branch
> > >
> > >
> > > Will do, btw maybe this feature can be enabled:
https://github.blog/changelog/2022-02-03-more-ways-to-keep-y
cstamas commented on code in PR #913:
URL: https://github.com/apache/maven/pull/913#discussion_r1080950099
##
maven-core/src/main/java/org/apache/maven/internal/aether/MavenChainedWorkspaceReader.java:
##
@@ -60,6 +62,31 @@ public Model findModel(Artifact artifact) {
re
cstamas commented on code in PR #913:
URL: https://github.com/apache/maven/pull/913#discussion_r1080948867
##
maven-core/src/main/java/org/apache/maven/internal/aether/MavenChainedWorkspaceReader.java:
##
@@ -60,6 +62,31 @@ public Model findModel(Artifact artifact) {
re
ajarmoniuk commented on PR #151:
URL:
https://github.com/apache/maven-compiler-plugin/pull/151#issuecomment-1396612678
Hi, I can help as well. I've done similar jobs for versions, enforcer and
mrm already.
--
This is an automated message from the Apache Git Service.
To respond to the me
laeubi commented on PR #913:
URL: https://github.com/apache/maven/pull/913#issuecomment-1396612596
> > > pls rebase against latest maven-3.9.x branch
> >
> >
> > Will do, btw maybe this feature can be enabled:
https://github.blog/changelog/2022-02-03-more-ways-to-keep-your-pull-re
michael-o commented on PR #913:
URL: https://github.com/apache/maven/pull/913#issuecomment-1396607144
> > pls rebase against latest maven-3.9.x branch
>
> Will do, btw maybe this feature can be enabled:
https://github.blog/changelog/2022-02-03-more-ways-to-keep-your-pull-request-branc
laeubi commented on PR #913:
URL: https://github.com/apache/maven/pull/913#issuecomment-1396606402
> -P format
Would be cool to have a github action doing this and automatically push this
to the branch if the "allow edit by maintainers" is enabled!
--
This is an automated message f
cstamas commented on PR #913:
URL: https://github.com/apache/maven/pull/913#issuecomment-1396599551
To reformat build with `-P format` and commit source changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
cstamas commented on code in PR #913:
URL: https://github.com/apache/maven/pull/913#discussion_r1080930862
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenWorkspaceReader.java:
##
@@ -28,4 +29,18 @@
public interface MavenWorkspaceReader extend
cstamas commented on PR #913:
URL: https://github.com/apache/maven/pull/913#issuecomment-1396594967
> Will do, btw maybe this feature can be enabled:
https://github.blog/changelog/2022-02-03-more-ways-to-keep-your-pull-request-branch-up-to-date/
?
Unsure who has power to enable those
laeubi commented on PR #913:
URL: https://github.com/apache/maven/pull/913#issuecomment-1396591612
> pls rebase against latest maven-3.9.x branch
Will do, btw maybe this feature can be enabled:
https://github.blog/changelog/2022-02-03-more-ways-to-keep-your-pull-request-branch-up-to-d
1 - 100 of 1260 matches
Mail list logo
