Re: [I] simplify our GH issue templates boilerplate [maven-gh-actions-shared]

2025-05-27 Thread via GitHub
hboutemy commented on issue #165: URL: https://github.com/apache/maven-gh-actions-shared/issues/165#issuecomment-2915191791 quick research for CLA bot: - LF EasyCLA https://docs.linuxfoundation.org/lfx/easycla seems powerful, perhaps complex, perhaps require wider ASF involvement - ht

Re: [PR] Enable Github Issues [maven-doxia]

2025-05-27 Thread via GitHub
hboutemy commented on PR #267: URL: https://github.com/apache/maven-doxia/pull/267#issuecomment-2915186610 FYI https://github.com/apache/maven-gh-actions-shared/issues/165 created to track the template simplification feature request -- This is an automated message from the Apache Git Serv

[I] simplify our GH issue templates boilerplate [maven-gh-actions-shared]

2025-05-27 Thread via GitHub
hboutemy opened a new issue, #165: URL: https://github.com/apache/maven-gh-actions-shared/issues/165 ### New feature, improvement proposal reporting here as is it a general topic for many Git repositories, even if [templates in this precise Git repo](https://github.com/apache/maven-g

Re: [PR] chore: `ArtifactHandlerTest` add assertion to resolve `@SuppressWarnings("checkstyle:UnusedLocalVariable")` [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2375: URL: https://github.com/apache/maven/pull/2375#discussion_r2111064875 ## impl/maven-core/src/test/java/org/apache/maven/artifact/handler/ArtifactHandlerTest.java: ## @@ -77,8 +107,8 @@ void testAptConsistency() throws Exception {

Re: [PR] Bump org.redisson:redisson from 3.46.0 to 3.47.0 [maven-resolver]

2025-05-27 Thread via GitHub
dependabot[bot] closed pull request #729: Bump org.redisson:redisson from 3.46.0 to 3.47.0 URL: https://github.com/apache/maven-resolver/pull/729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump org.redisson:redisson from 3.46.0 to 3.47.0 [maven-resolver]

2025-05-27 Thread via GitHub
dependabot[bot] commented on PR #729: URL: https://github.com/apache/maven-resolver/pull/729#issuecomment-2915041386 Superseded by #732. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[PR] Bump org.redisson:redisson from 3.46.0 to 3.48.0 [maven-resolver]

2025-05-27 Thread via GitHub
dependabot[bot] opened a new pull request, #732: URL: https://github.com/apache/maven-resolver/pull/732 Bumps [org.redisson:redisson](https://github.com/redisson/redisson) from 3.46.0 to 3.48.0. Release notes Sourced from https://github.com/redisson/redisson/releases";>org.redisson

[PR] Bump org.codehaus.mojo:exec-maven-plugin from 3.5.0 to 3.5.1 [maven-resolver]

2025-05-27 Thread via GitHub
dependabot[bot] opened a new pull request, #731: URL: https://github.com/apache/maven-resolver/pull/731 Bumps [org.codehaus.mojo:exec-maven-plugin](https://github.com/mojohaus/exec-maven-plugin) from 3.5.0 to 3.5.1. Release notes Sourced from https://github.com/mojohaus/exec-maven

Re: [PR] Enable Github Issues [maven-doxia]

2025-05-27 Thread via GitHub
hboutemy commented on PR #267: URL: https://github.com/apache/maven-doxia/pull/267#issuecomment-2915032101 @Bukama please apply the usual PR template approach: it has been applied on 80% of our repositories, too late to change now we'll have that discussion in a separate time, let's not c

Re: [PR] Bump org.redisson:redisson from 3.46.0 to 3.47.0 [maven-resolver]

2025-05-27 Thread via GitHub
dependabot[bot] closed pull request #728: Bump org.redisson:redisson from 3.46.0 to 3.47.0 URL: https://github.com/apache/maven-resolver/pull/728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump org.redisson:redisson from 3.46.0 to 3.47.0 [maven-resolver]

2025-05-27 Thread via GitHub
dependabot[bot] commented on PR #728: URL: https://github.com/apache/maven-resolver/pull/728#issuecomment-2914990793 Superseded by #730. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[PR] Bump org.redisson:redisson from 3.46.0 to 3.48.0 [maven-resolver]

2025-05-27 Thread via GitHub
dependabot[bot] opened a new pull request, #730: URL: https://github.com/apache/maven-resolver/pull/730 Bumps [org.redisson:redisson](https://github.com/redisson/redisson) from 3.46.0 to 3.48.0. Release notes Sourced from https://github.com/redisson/redisson/releases";>org.redisson

Re: [PR] Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.3 to 2.44.4 [maven-parent]

2025-05-27 Thread via GitHub
dependabot[bot] commented on PR #464: URL: https://github.com/apache/maven-parent/pull/464#issuecomment-2914853279 Superseded by #471. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.3 to 2.44.4 [maven-parent]

2025-05-27 Thread via GitHub
dependabot[bot] closed pull request #464: Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.3 to 2.44.4 URL: https://github.com/apache/maven-parent/pull/464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.3 to 2.44.5 [maven-parent]

2025-05-27 Thread via GitHub
dependabot[bot] opened a new pull request, #471: URL: https://github.com/apache/maven-parent/pull/471 Bumps [com.diffplug.spotless:spotless-maven-plugin](https://github.com/diffplug/spotless) from 2.44.3 to 2.44.5. Release notes Sourced from https://github.com/diffplug/spotless/re

[PR] Bump commons-beanutils:commons-beanutils from 1.10.1 to 1.11.0 [maven-invoker-plugin]

2025-05-27 Thread via GitHub
dependabot[bot] opened a new pull request, #288: URL: https://github.com/apache/maven-invoker-plugin/pull/288 Bumps commons-beanutils:commons-beanutils from 1.10.1 to 1.11.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?depe

[PR] Bump org.codehaus.mojo:exec-maven-plugin from 3.5.0 to 3.5.1 [maven]

2025-05-27 Thread via GitHub
dependabot[bot] opened a new pull request, #2397: URL: https://github.com/apache/maven/pull/2397 Bumps [org.codehaus.mojo:exec-maven-plugin](https://github.com/mojohaus/exec-maven-plugin) from 3.5.0 to 3.5.1. Release notes Sourced from https://github.com/mojohaus/exec-maven-plugin

Re: [I] mvnd does not signal test run completion do NetBeans IDE [maven-mvnd]

2025-05-27 Thread via GitHub
mbien commented on issue #1333: URL: https://github.com/apache/maven-mvnd/issues/1333#issuecomment-2914598201 feel free to close this since mvnd is working fine, sorry for the noise. (NB patch: https://github.com/apache/netbeans/pull/8539) -- This is an automated message from the Apache G

[I] GpgSignAttachedMojo attaches artifacts with an empty string classifier [maven-gpg-plugin]

2025-05-27 Thread via GitHub
bstansberry opened a new issue, #138: URL: https://github.com/apache/maven-gpg-plugin/issues/138 ### Affected version 3.2.7 ### Bug description The algorithm GpgSignAttachedMojo follows to attach signed artifacts results in attachments with the empty string as the classi

[jira] [Assigned] (MNG-8699) Seems inferring fields is not fully covered?

2025-05-27 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-8699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet reassigned MNG-8699: Assignee: Guillaume Nodet > Seems inferring fields is not fully covered? > -

[jira] [Updated] (MNG-8699) Seems inferring fields is not fully covered?

2025-05-27 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-8699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-8699: - Fix Version/s: 4.0.0-rc-4 > Seems inferring fields is not fully covered? >

[jira] [Closed] (MNG-8657) GMavenPlus and AspectJ plugins break with 4-rc-3

2025-05-27 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-8657. Resolution: Fixed > GMavenPlus and AspectJ plugins break with 4-rc-3 > --

[PR] Bump org.codehaus.mojo:exec-maven-plugin from 3.5.0 to 3.5.1 [maven-site]

2025-05-27 Thread via GitHub
dependabot[bot] opened a new pull request, #799: URL: https://github.com/apache/maven-site/pull/799 Bumps [org.codehaus.mojo:exec-maven-plugin](https://github.com/mojohaus/exec-maven-plugin) from 3.5.0 to 3.5.1. Release notes Sourced from https://github.com/mojohaus/exec-maven-plu

[jira] [Closed] (MNG-8713) Default source directory should include the module name when present

2025-05-27 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-8713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-8713. Fix Version/s: 4.0.0-rc-4 Assignee: Martin Desruisseaux Resolution: Fixed > Default s

[jira] [Commented] (MNG-8746) Maven4 reorders properties of read POM

2025-05-27 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954439#comment-17954439 ] Guillaume Nodet commented on MNG-8746: -- Did you figure out anything ? > Maven4 reorde

[jira] [Commented] (MNG-8609) Dependency is not an Artifact

2025-05-27 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954438#comment-17954438 ] Guillaume Nodet commented on MNG-8609: -- This may be a semantic problem. When we talk

[PR] Issue #373 Fix JDK 23 build [maven-javadoc-plugin]

2025-05-27 Thread via GitHub
olamy opened a new pull request, #374: URL: https://github.com/apache/maven-javadoc-plugin/pull/374 - **test build with jdk23** - **fix ghas** - **some javadoc jdk 23 fixes** - **add jdk23 specific test** Following this checklist to help us incorporate your contribution qui

[jira] [Commented] (MNG-8748) org.apache.maven.api.services.model.UrlNormalizer should be a concrete class

2025-05-27 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954437#comment-17954437 ] Guillaume Nodet commented on MNG-8748: -- Same comment as MNG-8749. This actually appli

[jira] [Commented] (MNG-8749) Hide PathTranslator from API

2025-05-27 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954436#comment-17954436 ] Guillaume Nodet commented on MNG-8749: -- {{ModelPathTranslator}} goes through a {{Model

[PR] Update issueManagement to GitHub [maven-clean-plugin]

2025-05-27 Thread via GitHub
slawekjaranowski opened a new pull request, #256: URL: https://github.com/apache/maven-clean-plugin/pull/256 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Your pull request should address just one issue, without pulling in other changes

[PR] Update site descriptor [maven-clean-plugin]

2025-05-27 Thread via GitHub
slawekjaranowski opened a new pull request, #255: URL: https://github.com/apache/maven-clean-plugin/pull/255 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Your pull request should address just one issue, without pulling in other changes

Re: [PR] Update issue-management.md with correct GH issues links [maven-site]

2025-05-27 Thread via GitHub
hboutemy commented on code in PR #798: URL: https://github.com/apache/maven-site/pull/798#discussion_r2110391052 ## content/markdown/issue-management.md: ## @@ -37,11 +37,11 @@ issue management systems depending on which component is involved: * Maven Shared Components: Plea

Re: [PR] Fix typos in module name and headline [maven-site]

2025-05-27 Thread via GitHub
hboutemy commented on PR #791: URL: https://github.com/apache/maven-site/pull/791#issuecomment-2914288975 @ascheman we need you for conflict resolution, as we don't have permission -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] Drop outdated modules [maven-site]

2025-05-27 Thread via GitHub
hboutemy commented on code in PR #792: URL: https://github.com/apache/maven-site/pull/792#discussion_r2110357377 ## content/markdown/scm.md: ## @@ -196,16 +196,13 @@ The components in Git are shown in the following table. | Content

Re: [PR] Drop outdated modules [maven-site]

2025-05-27 Thread via GitHub
hboutemy commented on code in PR #792: URL: https://github.com/apache/maven-site/pull/792#discussion_r2110356893 ## content/markdown/scm.md: ## @@ -196,16 +196,13 @@ The components in Git are shown in the following table. | Content

Re: [PR] Bump project to 3.5.0-SNAPSHOT version [maven-clean-plugin]

2025-05-27 Thread via GitHub
slawekjaranowski merged PR #254: URL: https://github.com/apache/maven-clean-plugin/pull/254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

Re: [I] Clean plugin 3.4.1. is unable to delete 'checkout' folder from prior release within target folder [maven-clean-plugin]

2025-05-27 Thread via GitHub
slawekjaranowski closed issue #246: Clean plugin 3.4.1. is unable to delete 'checkout' folder from prior release within target folder URL: https://github.com/apache/maven-clean-plugin/issues/246 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] chore: `ArtifactHandlerTest` add assertion to resolve `@SuppressWarnings("checkstyle:UnusedLocalVariable")` [maven]

2025-05-27 Thread via GitHub
elharo commented on code in PR #2375: URL: https://github.com/apache/maven/pull/2375#discussion_r2110303421 ## impl/maven-core/src/test/java/org/apache/maven/artifact/handler/ArtifactHandlerTest.java: ## @@ -77,8 +107,8 @@ void testAptConsistency() throws Exception {

[PR] Bump project to 3.5.0-SNAPSHOT version [maven-clean-plugin]

2025-05-27 Thread via GitHub
slawekjaranowski opened a new pull request, #254: URL: https://github.com/apache/maven-clean-plugin/pull/254 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Your pull request should address just one issue, without pulling in other changes

Re: [PR] Configuration parameter for deleting read-only files [maven-clean-plugin]

2025-05-27 Thread via GitHub
slawekjaranowski merged PR #252: URL: https://github.com/apache/maven-clean-plugin/pull/252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[PR] Bump org.apache.groovy:groovy-bom from 4.0.26 to 4.0.27 [maven-archetype]

2025-05-27 Thread via GitHub
dependabot[bot] opened a new pull request, #276: URL: https://github.com/apache/maven-archetype/pull/276 Bumps [org.apache.groovy:groovy-bom](https://github.com/apache/groovy) from 4.0.26 to 4.0.27. Commits See full diff in https://github.com/apache/groovy/commits";>compare vie

Re: [PR] Modernize codebase with Java improvements [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on PR #2277: URL: https://github.com/apache/maven/pull/2277#issuecomment-2913963836 merge will resolve and melt down until we can merge and grasp easily. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] `try` can use `automatic resource management` [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on PR #2395: URL: https://github.com/apache/maven/pull/2395#issuecomment-2913958855 wait for enabler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] `try` can use `automatic resource management` [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on PR #2395: URL: https://github.com/apache/maven/pull/2395#issuecomment-2913956493 might be flaky, as only one time and works on dev: https://github.com/user-attachments/assets/4c41471e-0bcc-43ba-8d89-3686a410dbcc"; /> https://github.com/user-attachments/assets

Re: [PR] [POC-FIX-PMD] maven-pmd-plugin: reactivate PMD - Error Prone [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on PR #2364: URL: https://github.com/apache/maven/pull/2364#issuecomment-2913930715 - https://github.com/apache/maven/pull/2395 - https://pmd.github.io/pmd/pmd_rules_java_bestpractices.html#usetrywithresources -- This is an automated message from the Apache Git Serv

Re: [PR] avoid false `IO` catch on `mkdirs()` [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2396: URL: https://github.com/apache/maven/pull/2396#discussion_r2110131765 ## its/core-it-support/core-it-plugins/maven-it-plugin-class-loader/maven-it-plugin-class-loader/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java: ## @@

Re: [PR] avoid false `IO` catch on `mkdirs()` [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2396: URL: https://github.com/apache/maven/pull/2396#discussion_r2110131191 ## its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckMojo.java: ## @@ -118,8 +118,8 @@ public void

Re: [PR] avoid false `IO` catch on `mkdirs()` [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2396: URL: https://github.com/apache/maven/pull/2396#discussion_r2110128993 ## its/core-it-suite/src/test/resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java: ## @@ -52,8 +52,8 @@ public class ItMojo extends AbstractMojo { private F

Re: [PR] chore: `ArtifactHandlerTest` add assertion to resolve `@SuppressWarnings("checkstyle:UnusedLocalVariable")` [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2375: URL: https://github.com/apache/maven/pull/2375#discussion_r2110119376 ## impl/maven-core/src/test/java/org/apache/maven/artifact/handler/ArtifactHandlerTest.java: ## @@ -77,8 +107,8 @@ void testAptConsistency() throws Exception {

Re: [PR] `try` can use automatic resource management [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2395: URL: https://github.com/apache/maven/pull/2395#discussion_r2110094149 ## its/core-it-support/core-it-plugins/maven-it-plugin-log-file/src/main/java/org/apache/maven/plugin/coreit/AbstractLogMojo.java: ## @@ -78,22 +78,13 @@ protected void

Re: [PR] `try` can use automatic resource management [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2395: URL: https://github.com/apache/maven/pull/2395#discussion_r2110094149 ## its/core-it-support/core-it-plugins/maven-it-plugin-log-file/src/main/java/org/apache/maven/plugin/coreit/AbstractLogMojo.java: ## @@ -78,22 +78,13 @@ protected void

Re: [PR] avoid false `IO` catch on `mkdirs()` [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2396: URL: https://github.com/apache/maven/pull/2396#discussion_r2109728748 ## its/core-it-suite/src/test/resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java: ## @@ -52,8 +52,8 @@ public class ItMojo extends AbstractMojo { private F

Re: [PR] avoid false `IO` catch on `mkdirs()` [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2396: URL: https://github.com/apache/maven/pull/2396#discussion_r2110086980 ## its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-deploy-plugin/src/main/java/org/apache/maven/plugin/coreit/DeployMojo.java: ## @@ -72,8 +72,8 @@

Re: [PR] Add UT for cache in FilteredProjectDependencyGraphTest [maven]

2025-05-27 Thread via GitHub
slawekjaranowski commented on code in PR #2394: URL: https://github.com/apache/maven/pull/2394#discussion_r2110064349 ## impl/maven-core/src/test/java/org/apache/maven/graph/FilteredProjectDependencyGraphTest.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] avoid false `IO` catch on `mkdirs()` [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2396: URL: https://github.com/apache/maven/pull/2396#discussion_r2110061815 ## its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/CompileMojo.java: ## @@ -72,8 +72,8

Re: [PR] avoid false `IO` catch on `mkdirs()` [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2396: URL: https://github.com/apache/maven/pull/2396#discussion_r2110061380 ## its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/TestCompileMojo.java: ## @@ -72,8 +

Re: [PR] avoid false `IO` catch on `mkdirs()` [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2396: URL: https://github.com/apache/maven/pull/2396#discussion_r2110059677 ## its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-clean-plugin/src/main/java/org/apache/maven/plugin/coreit/CleanMojo.java: ## @@ -72,8 +72,8 @@ p

Re: [PR] Add UT for cache in FilteredProjectDependencyGraphTest [maven]

2025-05-27 Thread via GitHub
gnodet commented on code in PR #2394: URL: https://github.com/apache/maven/pull/2394#discussion_r2109977840 ## impl/maven-core/src/test/java/org/apache/maven/graph/FilteredProjectDependencyGraphTest.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Add support for Maven 4 PluginDescriptor.getRequiredJavaVersion() method [maven-plugin-tools]

2025-05-27 Thread via GitHub
gnodet commented on PR #401: URL: https://github.com/apache/maven-plugin-tools/pull/401#issuecomment-2913424413 There must be a missing file in this commit, as the helper class is not used at all. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] avoid false `IO` catch on `mkdirs()` [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2396: URL: https://github.com/apache/maven/pull/2396#discussion_r2109728748 ## its/core-it-suite/src/test/resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java: ## @@ -52,8 +52,8 @@ public class ItMojo extends AbstractMojo { private F

[PR] Update issue-management.md with correct GH issues links [maven-site]

2025-05-27 Thread via GitHub
Bukama opened a new pull request, #798: URL: https://github.com/apache/maven-site/pull/798 Can be merged after https://github.com/apache/maven-doxia/pull/267 Updating Doxia-Site is on the list -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Enable Github Issues [maven-doxia]

2025-05-27 Thread via GitHub
Bukama commented on PR #267: URL: https://github.com/apache/maven-doxia/pull/267#issuecomment-2913163959 Note: PR-Template not added (yet), as @hboutemy wanted to discuss/think about to reduce the "wall of text" in the PR (for example post it as a comment by a bot or so), so reviewers bette

[PR] Enable Github Issues [maven-doxia]

2025-05-27 Thread via GitHub
Bukama opened a new pull request, #267: URL: https://github.com/apache/maven-doxia/pull/267 * Release was there * Milestone created -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] CVE-2024-13009 [maven-site-plugin]

2025-05-27 Thread via GitHub
jpmartins-ca commented on issue #237: URL: https://github.com/apache/maven-site-plugin/issues/237#issuecomment-2912838558 https://github.com/apache/maven-site-plugin/pull/238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[PR] MSITE-XXX - jetty-server dependency patch (CVE-2024-13009) [maven-site-plugin]

2025-05-27 Thread via GitHub
jpmartins-ca opened a new pull request, #238: URL: https://github.com/apache/maven-site-plugin/pull/238 Update dependency to a version of jetty-server 9 where CVE-2024-13009 is fixed. Following this checklist to help us incorporate your contribution quickly and easily: - [

Re: [PR] chore: resolve false negative suppression `@SuppressWarnings("checkstyle:UnusedLocalVariable")` [maven]

2025-05-27 Thread via GitHub
elharo merged PR #2369: URL: https://github.com/apache/maven/pull/2369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

Re: [PR] [chore] Modernize codebase with Java improvements - Replace custom null checks with `Objects.requireNonNull` [maven]

2025-05-27 Thread via GitHub
elharo merged PR #2290: URL: https://github.com/apache/maven/pull/2290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

Re: [PR] `try` can use automatic resource management [maven]

2025-05-27 Thread via GitHub
elharo commented on code in PR #2395: URL: https://github.com/apache/maven/pull/2395#discussion_r2109269450 ## its/core-it-support/core-it-plugins/maven-it-plugin-log-file/src/main/java/org/apache/maven/plugin/coreit/AbstractLogMojo.java: ## @@ -78,22 +78,13 @@ protected void ap

Re: [PR] avoid false `IO` catch on `mkdirs()` [maven]

2025-05-27 Thread via GitHub
elharo commented on code in PR #2396: URL: https://github.com/apache/maven/pull/2396#discussion_r2109264385 ## its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/TestCompileMojo.java: ## @@ -72,8 +72,

Re: [PR] fix: `DefaultModelInterpolator` PMD-Rule: `EmptyControlStatement` [maven]

2025-05-27 Thread via GitHub
elharo commented on code in PR #2373: URL: https://github.com/apache/maven/pull/2373#discussion_r2109252148 ## impl/maven-impl/src/test/java/org/apache/maven/impl/model/DefaultModelInterpolatorTest.java: ## @@ -592,4 +607,403 @@ public Path findMandatoryRoot(Path basedir) {

[jira] [Commented] (MDEP-931) AbstractSerializingVisitor should not use PrintWriter

2025-05-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MDEP-931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954343#comment-17954343 ] ASF GitHub Bot commented on MDEP-931: - elharo commented on code in PR #530: URL: https

Re: [PR] Fix [MDEP-931] Replace PrintWriter with Writer in AbstractSerializing Visitor and subclasses [maven-dependency-plugin]

2025-05-27 Thread via GitHub
elharo commented on code in PR #530: URL: https://github.com/apache/maven-dependency-plugin/pull/530#discussion_r2109238647 ## src/main/java/org/apache/maven/plugins/dependency/tree/DOTDependencyNodeVisitor.java: ## @@ -47,29 +48,38 @@ public DOTDependencyNodeVisitor(Writer wri

[jira] [Commented] (MDEP-979) Clean up AbstractDependencyMojoTestCase setUp

2025-05-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MDEP-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954342#comment-17954342 ] ASF GitHub Bot commented on MDEP-979: - elharo commented on code in PR #532: URL: https

Re: [PR] [MDEP-979] Clean up AbstractDependencyMojoTestCase setUp [maven-dependency-plugin]

2025-05-27 Thread via GitHub
elharo commented on code in PR #532: URL: https://github.com/apache/maven-dependency-plugin/pull/532#discussion_r2109220394 ## src/test/java/org/apache/maven/plugins/dependency/AbstractDependencyMojoTestCase.java: ## @@ -35,26 +35,49 @@ import org.eclipse.aether.RepositorySyst

[PR] Bump xmlunitVersion from 2.10.0 to 2.10.2 [maven-doxia]

2025-05-27 Thread via GitHub
dependabot[bot] opened a new pull request, #266: URL: https://github.com/apache/maven-doxia/pull/266 Bumps `xmlunitVersion` from 2.10.0 to 2.10.2. Updates `org.xmlunit:xmlunit-core` from 2.10.0 to 2.10.2 Release notes Sourced from https://github.com/xmlunit/xmlunit/releases";>org

[PR] Bump org.codehaus.groovy:groovy-xml from 2.4.16 to 3.0.25 [maven-archetypes]

2025-05-27 Thread via GitHub
dependabot[bot] opened a new pull request, #42: URL: https://github.com/apache/maven-archetypes/pull/42 Bumps [org.codehaus.groovy:groovy-xml](https://github.com/apache/groovy) from 2.4.16 to 3.0.25. Commits See full diff in https://github.com/apache/groovy/commits";>compare vi

Re: [PR] Bump org.codehaus.groovy:groovy-xml from 2.4.16 to 3.0.24 [maven-archetypes]

2025-05-27 Thread via GitHub
dependabot[bot] closed pull request #39: Bump org.codehaus.groovy:groovy-xml from 2.4.16 to 3.0.24 URL: https://github.com/apache/maven-archetypes/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Bump org.codehaus.groovy:groovy-xml from 2.4.16 to 3.0.24 [maven-archetypes]

2025-05-27 Thread via GitHub
dependabot[bot] commented on PR #39: URL: https://github.com/apache/maven-archetypes/pull/39#issuecomment-2912326752 Superseded by #42. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Created] (MNG-8752) Answer the question: "If a dependency is in provided scope, what should happen with its transitive dependencies, if any?"

2025-05-27 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MNG-8752: Summary: Answer the question: "If a dependency is in provided scope, what should happen with its transitive dependencies, if any?" Key: MNG-8752 URL: https://issues.apache.org/jir

[jira] [Updated] (MNG-8752) Answer the question: "If a dependency is in provided scope, what should happen with its transitive dependencies, if any?"

2025-05-27 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8752: - Description: This problem is very similar to MNG-8041 but kinda opposite and this matters resolving

[jira] [Updated] (MNG-8752) Answer the question: "If a dependency is in provided scope, what should happen with its transitive dependencies, if any?"

2025-05-27 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8752: - Description: This problem is very similar to MNG-8041 but kinda opposite and this matters resolving

Re: [PR] Add UT for cache in FilteredProjectDependencyGraphTest [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2394: URL: https://github.com/apache/maven/pull/2394#discussion_r2108911987 ## impl/maven-core/src/test/java/org/apache/maven/graph/FilteredProjectDependencyGraphTest.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] avoid false `IO` catch on `mkdirs()` [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on PR #2396: URL: https://github.com/apache/maven/pull/2396#issuecomment-2912155464 is this any good? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] `try` can use automatic resource management [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2395: URL: https://github.com/apache/maven/pull/2395#discussion_r2108925637 ## its/core-it-suite/src/test/resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java: ## @@ -52,8 +52,8 @@ public class ItMojo extends AbstractMojo { private F

[PR] avoid falsy catch on `mkdirs()` [maven]

2025-05-27 Thread via GitHub
Pankraz76 opened a new pull request, #2396: URL: https://github.com/apache/maven/pull/2396 - https://github.com/apache/maven/pull/2395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] `try` can use automatic resource management [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2395: URL: https://github.com/apache/maven/pull/2395#discussion_r2108907609 ## its/core-it-suite/src/test/resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java: ## @@ -52,8 +52,8 @@ public class ItMojo extends AbstractMojo { private F

Re: [PR] Add UT for cache in FilteredProjectDependencyGraphTest [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2394: URL: https://github.com/apache/maven/pull/2394#discussion_r2108915708 ## impl/maven-core/src/test/java/org/apache/maven/graph/FilteredProjectDependencyGraphTest.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Add UT for cache in FilteredProjectDependencyGraphTest [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2394: URL: https://github.com/apache/maven/pull/2394#discussion_r2108911987 ## impl/maven-core/src/test/java/org/apache/maven/graph/FilteredProjectDependencyGraphTest.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Add UT for cache in FilteredProjectDependencyGraphTest [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2394: URL: https://github.com/apache/maven/pull/2394#discussion_r2108910532 ## impl/maven-core/src/test/java/org/apache/maven/graph/FilteredProjectDependencyGraphTest.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] `try` can use automatic resource management [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2395: URL: https://github.com/apache/maven/pull/2395#discussion_r2108907609 ## its/core-it-suite/src/test/resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java: ## @@ -52,8 +52,8 @@ public class ItMojo extends AbstractMojo { private F

Re: [PR] `try` can use automatic resource management [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2395: URL: https://github.com/apache/maven/pull/2395#discussion_r2108882736 ## its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java: ## @@ -133,21 +133,11

Re: [PR] `try` can use automatic resource management [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2395: URL: https://github.com/apache/maven/pull/2395#discussion_r2108874963 ## its/core-it-support/core-it-plugins/maven-it-plugin-log-file/src/main/java/org/apache/maven/plugin/coreit/AbstractLogMojo.java: ## @@ -78,22 +78,13 @@ protected void

Re: [PR] `try` can use automatic resource management [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2395: URL: https://github.com/apache/maven/pull/2395#discussion_r2108874963 ## its/core-it-support/core-it-plugins/maven-it-plugin-log-file/src/main/java/org/apache/maven/plugin/coreit/AbstractLogMojo.java: ## @@ -78,22 +78,13 @@ protected void

Re: [PR] `try` can use automatic resource management [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2395: URL: https://github.com/apache/maven/pull/2395#discussion_r2108872547 ## its/core-it-support/core-it-plugins/maven-it-plugin-log-file/src/main/java/org/apache/maven/plugin/coreit/AbstractLogMojo.java: ## @@ -78,22 +78,13 @@ protected void

Re: [PR] `try` can use automatic resource management [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on code in PR #2395: URL: https://github.com/apache/maven/pull/2395#discussion_r2108871716 ## its/core-it-support/core-it-plugins/maven-it-plugin-log-file/src/main/java/org/apache/maven/plugin/coreit/AbstractLogMojo.java: ## @@ -78,22 +78,13 @@ protected void

Re: [PR] `try` can use automatic resource management [maven]

2025-05-27 Thread via GitHub
Pankraz76 closed pull request #2395: `try` can use automatic resource management URL: https://github.com/apache/maven/pull/2395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] `try` can use automatic resource management [maven]

2025-05-27 Thread via GitHub
Pankraz76 opened a new pull request, #2395: URL: https://github.com/apache/maven/pull/2395 https://github.com/user-attachments/assets/b40590c1-000d-4edb-b9ca-8c7e66b8c57a"; /> -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] `try` can use automatic resource management [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on PR #2395: URL: https://github.com/apache/maven/pull/2395#issuecomment-2912047685 wip -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [chore] Modernize codebase with Java improvements - Replace custom null checks with `Objects.requireNonNull` [maven]

2025-05-27 Thread via GitHub
Pankraz76 commented on PR #2290: URL: https://github.com/apache/maven/pull/2290#issuecomment-2912030491 @olamy any feedback from your side? If not might consider merge. Its just renaming of old method to new one, therefore no delta possible, and removal. No risky s&r brute for

[jira] [Commented] (MDEP-967) Demote info logging in AbstractFromConfigurationMojo

2025-05-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MDEP-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954282#comment-17954282 ] ASF GitHub Bot commented on MDEP-967: - olamy merged PR #529: URL: https://github.com/ap

  1   2   >