[jira] [Reopened] (MNG-5641) AbstractMavenLifecycleParticipant#afterSessionStart is never invoked

2025-05-24 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MNG-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reopened MNG-5641: --- > AbstractMavenLifecycleParticipant#afterSessionStart is never invoked > --

Re: [PR] Maven4 "legacy" mode and more [maven]

2025-05-24 Thread via GitHub
Pankraz76 commented on code in PR #2380: URL: https://github.com/apache/maven/pull/2380#discussion_r2105931763 ## impl/maven-impl/src/main/java/org/apache/maven/impl/resolver/scopes/Maven3ScopeManagerConfiguration.java: ## @@ -24,15 +24,14 @@ import java.util.Collections; impo

Re: [PR] Maven4 "legacy" mode and more [maven]

2025-05-24 Thread via GitHub
cstamas commented on code in PR #2380: URL: https://github.com/apache/maven/pull/2380#discussion_r2105929185 ## impl/maven-impl/src/main/java/org/apache/maven/impl/resolver/scopes/Maven3ScopeManagerConfiguration.java: ## @@ -89,33 +84,37 @@ public BuildScopeSource getBuildScopeS

Re: [PR] Maven4 "legacy" mode and more [maven]

2025-05-24 Thread via GitHub
cstamas commented on code in PR #2380: URL: https://github.com/apache/maven/pull/2380#discussion_r2105929185 ## impl/maven-impl/src/main/java/org/apache/maven/impl/resolver/scopes/Maven3ScopeManagerConfiguration.java: ## @@ -89,33 +84,37 @@ public BuildScopeSource getBuildScopeS

Re: [PR] Maven4 "legacy" mode and more [maven]

2025-05-24 Thread via GitHub
cstamas commented on code in PR #2380: URL: https://github.com/apache/maven/pull/2380#discussion_r2105928918 ## impl/maven-impl/src/main/java/org/apache/maven/impl/resolver/scopes/Maven3ScopeManagerConfiguration.java: ## @@ -24,15 +24,14 @@ import java.util.Collections; import

Re: [PR] Maven4 "legacy" mode and more [maven]

2025-05-24 Thread via GitHub
cstamas commented on code in PR #2380: URL: https://github.com/apache/maven/pull/2380#discussion_r2105929610 ## src/site/markdown/maven-configuration.md: ## @@ -53,6 +53,7 @@ To modify this file, edit the template and regenerate. | `maven.logger.showThreadId` | `Boolean` | If y

Re: [PR] Maven4 "legacy" mode and more [maven]

2025-05-24 Thread via GitHub
Pankraz76 commented on code in PR #2380: URL: https://github.com/apache/maven/pull/2380#discussion_r2105923657 ## impl/maven-impl/src/main/java/org/apache/maven/impl/resolver/scopes/Maven3ScopeManagerConfiguration.java: ## @@ -24,15 +24,14 @@ import java.util.Collections; impo

[PR] chore: add test for unused `VerificationException` in `MavenITmng5640LifecycleParticipantAfterSessionEnd` [maven]

2025-05-24 Thread via GitHub
Pankraz76 opened a new pull request, #2387: URL: https://github.com/apache/maven/pull/2387 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] fix: `DefaultModelInterpolator` PMD-Rule: `EmptyControlStatement` [maven]

2025-05-24 Thread via GitHub
Pankraz76 commented on PR #2373: URL: https://github.com/apache/maven/pull/2373#issuecomment-2907003559 issue: Error:DefaultModelInterpolatorTest.testProjectPropertyExtraction:650 expected: but was: -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] Flag to fail as in maven-enforcer-plugin [maven-toolchains-plugin]

2025-05-24 Thread via GitHub
jens-rommel commented on code in PR #42: URL: https://github.com/apache/maven-toolchains-plugin/pull/42#discussion_r2105907664 ## src/main/java/org/apache/maven/plugins/toolchain/ToolchainMojo.java: ## @@ -70,6 +70,13 @@ public class ToolchainMojo extends AbstractMojo { @P

Re: [PR] chore: `ArtifactHandlerTest` add assertion to resolve `@SuppressWarnings("checkstyle:UnusedLocalVariable")` [maven]

2025-05-24 Thread via GitHub
Pankraz76 commented on code in PR #2375: URL: https://github.com/apache/maven/pull/2375#discussion_r2105887608 ## impl/maven-core/src/test/java/org/apache/maven/artifact/handler/ArtifactHandlerTest.java: ## @@ -77,8 +107,8 @@ void testAptConsistency() throws Exception {

Re: [PR] Enable Github Issue 3x [maven-reporting-api]

2025-05-24 Thread via GitHub
Bukama commented on PR #25: URL: https://github.com/apache/maven-reporting-api/pull/25#issuecomment-2906916278 Closing as in https://github.com/apache/maven-reporting-impl/pull/68 : No more 3.x -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Enable Github Issue 3x [maven-reporting-api]

2025-05-24 Thread via GitHub
Bukama closed pull request #25: Enable Github Issue 3x URL: https://github.com/apache/maven-reporting-api/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Github Issues for shared-jar/io/utils/incremental, verifier, script-interpreter [maven-site]

2025-05-24 Thread via GitHub
Bukama merged PR #786: URL: https://github.com/apache/maven-site/pull/786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apach

Re: [PR] Enable Github Issues [maven-shared-incremental]

2025-05-24 Thread via GitHub
Bukama merged PR #32: URL: https://github.com/apache/maven-shared-incremental/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] Enable Github Issues [maven-script-interpreter]

2025-05-24 Thread via GitHub
Bukama merged PR #129: URL: https://github.com/apache/maven-script-interpreter/pull/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

Re: [PR] Enable Github Issues [maven-shared-io]

2025-05-24 Thread via GitHub
Bukama merged PR #30: URL: https://github.com/apache/maven-shared-io/pull/30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

Re: [PR] Enable Github Issues [maven-shared-jar]

2025-05-24 Thread via GitHub
Bukama merged PR #56: URL: https://github.com/apache/maven-shared-jar/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.a

Re: [PR] Enable Github Issues [maven-shared-utils]

2025-05-24 Thread via GitHub
Bukama merged PR #195: URL: https://github.com/apache/maven-shared-utils/pull/195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mav

Re: [PR] Enable Github Issues [maven-verifier]

2025-05-24 Thread via GitHub
Bukama merged PR #106: URL: https://github.com/apache/maven-verifier/pull/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.a

Re: [PR] Github Issues 3.x [maven-reporting-impl]

2025-05-24 Thread via GitHub
Bukama closed pull request #68: Github Issues 3.x URL: https://github.com/apache/maven-reporting-impl/pull/68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] Github Issues [maven-reporting-impl]

2025-05-24 Thread via GitHub
slawekjaranowski commented on code in PR #67: URL: https://github.com/apache/maven-reporting-impl/pull/67#discussion_r2105868998 ## .github/release-drafter-3.x.yml: ## Review Comment: not needed, as we not work on 3.x branch here -- This is an automated message from th

Re: [PR] Align modules and docs with repo manifest [maven-site]

2025-05-24 Thread via GitHub
ascheman commented on code in PR #787: URL: https://github.com/apache/maven-site/pull/787#discussion_r2105851254 ## content/markdown/scm.md: ## @@ -193,31 +193,29 @@ The components in Git are shown in the following table. Shared Components Review Comment: Nope, not

[jira] [Created] (MNG-8746) Maven4 reorders properties of read POM

2025-05-24 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MNG-8746: Summary: Maven4 reorders properties of read POM Key: MNG-8746 URL: https://issues.apache.org/jira/browse/MNG-8746 Project: Maven Issue Type: Bug Co

Re: [PR] [chore] Modernize codebase with Java improvements - Replace custom null checks with `Objects.requireNonNull` [maven]

2025-05-24 Thread via GitHub
Pankraz76 commented on PR #2290: URL: https://github.com/apache/maven/pull/2290#issuecomment-2906800898 yes, its a security risk not haven taken into account. Thanks for hint. If its only possible then with min. approval count increased to 2, better 3, this is altho not pleasant. -- Th

[I] automate consistency checks [maven-sources]

2025-05-24 Thread via GitHub
hboutemy opened a new issue, #20: URL: https://github.com/apache/maven-sources/issues/20 when we add or archive a component, we often forget one of the following: - repo's default.xml - README.md - aggregator build - dist tool https://ci-maven.apache.org/job/Maven/job/maven-box/j

Re: [PR] [chore] Modernize codebase with Java improvements - Replace custom null checks with `Objects.requireNonNull` [maven]

2025-05-24 Thread via GitHub
michael-o commented on PR #2290: URL: https://github.com/apache/maven/pull/2290#issuecomment-2906777670 > > Might enable an auto merge after 10 days non rejected. > > Not rejected does not mean approved (at least for me) and taken into account how large Maven is, that the Maven team i

Re: [PR] [MNG-8632] Update Full Build pipeline to also build with JDK 24 [maven]

2025-05-24 Thread via GitHub
cstamas commented on PR #2169: URL: https://github.com/apache/maven/pull/2169#issuecomment-2906775936 Agreed, but I meant _this very PR_ is done, as master (and even 3.9) already runs on 24 as well... -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [chore] Modernize codebase with Java improvements - Replace custom null checks with `Objects.requireNonNull` [maven]

2025-05-24 Thread via GitHub
Bukama commented on PR #2290: URL: https://github.com/apache/maven/pull/2290#issuecomment-2906774313 > Might enable an auto merge after 10 days non rejected. Not rejected does not mean approved (at least for me) and taken into account how large Maven is, that the Maven team is not a c

Re: [PR] [MNG-8632] Update Full Build pipeline to also build with JDK 24 [maven]

2025-05-24 Thread via GitHub
gnodet commented on PR #2169: URL: https://github.com/apache/maven/pull/2169#issuecomment-2906760412 FWIW, I think we should aim at jdk25 ea asap, but palantir is broken (I raised a PR to fix it). -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Align modules and docs with repo manifest [maven-site]

2025-05-24 Thread via GitHub
Bukama commented on code in PR #787: URL: https://github.com/apache/maven-site/pull/787#discussion_r2105777693 ## content/markdown/scm.md: ## @@ -193,31 +193,29 @@ The components in Git are shown in the following table. Shared Components Review Comment: In comparis

Re: [PR] chore: `ArtifactHandlerTest` add assertion to resolve `@SuppressWarnings("checkstyle:UnusedLocalVariable")` [maven]

2025-05-24 Thread via GitHub
Pankraz76 commented on code in PR #2375: URL: https://github.com/apache/maven/pull/2375#discussion_r2105767765 ## impl/maven-core/src/test/java/org/apache/maven/artifact/handler/ArtifactHandlerTest.java: ## @@ -29,16 +29,46 @@ import org.codehaus.plexus.testing.PlexusTest; imp

Re: [PR] [chore] Modernize codebase with Java improvements - Replace custom null checks with `Objects.requireNonNull` [maven]

2025-05-24 Thread via GitHub
Pankraz76 commented on PR #2290: URL: https://github.com/apache/maven/pull/2290#issuecomment-2906687190 > but I guess not merge not. It seems that its convention here to to merge immediately so others can review too. Might enable an auto merge after 10 days non rejected. -- This is

Re: [PR] Maven4 "legacy" mode and more [maven]

2025-05-24 Thread via GitHub
gnodet commented on code in PR #2380: URL: https://github.com/apache/maven/pull/2380#discussion_r2105765896 ## api/maven-api-core/src/main/java/org/apache/maven/api/Constants.java: ## @@ -462,6 +462,15 @@ public final class Constants { @Config(type = "java.lang.Boolean", de

Re: [I] Java Version 25ea Parsing Fails [maven-compiler-plugin]

2025-05-24 Thread via GitHub
slawekjaranowski commented on issue #330: URL: https://github.com/apache/maven-compiler-plugin/issues/330#issuecomment-2906668996 please provide output of: ``` mvn -v ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[I] Java Version Parsing Fails [maven-compiler-plugin]

2025-05-24 Thread via GitHub
daniel-pfeiffer opened a new issue, #330: URL: https://github.com/apache/maven-compiler-plugin/issues/330 ### Affected version 3.14 ### Bug description I get me the following error, plus a link to a most general web-page without a hint what’s wrong: `ERROR Failed

[PR] Align modules and docs with repo manifest [maven-site]

2025-05-24 Thread via GitHub
ascheman opened a new pull request, #787: URL: https://github.com/apache/maven-site/pull/787 Further align modules and docs with repo manifest cf. apache/maven-sources#18 and support-and-care/maven-support-and-care#77 Following this checklist to help us incorporate your co

[jira] [Updated] (MNG-8741) Lock file erroneously picks up command-line arguments from maven

2025-05-24 Thread Lenny Primak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lenny Primak updated MNG-8741: -- Description: This is a new regression in the master branch. Looks like a resolver bug. Looks like maven

Re: [PR] update documentation after #10 [maven-sources]

2025-05-24 Thread via GitHub
hboutemy merged PR #19: URL: https://github.com/apache/maven-sources/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

[PR] update documentation after #10 [maven-sources]

2025-05-24 Thread via GitHub
hboutemy opened a new pull request, #19: URL: https://github.com/apache/maven-sources/pull/19 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] Enlist missing branches that are actively maintained for Maven 3 [maven-sources]

2025-05-24 Thread via GitHub
hboutemy merged PR #10: URL: https://github.com/apache/maven-sources/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

Re: [PR] Cleanup repositories [maven-sources]

2025-05-24 Thread via GitHub
hboutemy commented on PR #18: URL: https://github.com/apache/maven-sources/pull/18#issuecomment-2906546482 I tried to do a review: each commit added so much to discuss that I don't want to start reviewing the full PR please create one PR per change, because each change nature needs so