[PR] Pull #2292: `Modernize codebase with Java improvements - test DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 opened a new pull request, #2304: URL: https://github.com/apache/maven/pull/2304 enable for: - https://github.com/apache/maven/pull/2292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on PR #2292: URL: https://github.com/apache/maven/pull/2292#issuecomment-2861942619 thats my headache `Exception 'java.io.IOException' is never thrown in the corresponding try block` https://github.com/user-attachments/assets/a8b3c800-e59f-40a9-a5e8-b797d73beaf0"; />

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on PR #2292: URL: https://github.com/apache/maven/pull/2292#issuecomment-2861935795 > This totally breaks the exception handling. I'm not sure—when asking AI and trying to mock it, both seem to say the same thing: "Checked exceptions must be declared!" That's ho

Re: [PR] Enable GitHub issues [maven-archetypes]

2025-05-07 Thread via GitHub
slawekjaranowski commented on code in PR #40: URL: https://github.com/apache/maven-archetypes/pull/40#discussion_r2078907805 ## pom.xml: ## @@ -58,12 +58,12 @@ under the License. https://github.com/apache/maven-archetypes/tree/${project.scm.tag} -jira -http

Re: [PR] Remove clean from the PR template [maven-archetype]

2025-05-07 Thread via GitHub
slawekjaranowski merged PR #266: URL: https://github.com/apache/maven-archetype/pull/266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] Enable GitHub issues [maven-archetypes]

2025-05-07 Thread via GitHub
Bukama commented on code in PR #40: URL: https://github.com/apache/maven-archetypes/pull/40#discussion_r2078825671 ## pom.xml: ## @@ -58,12 +58,12 @@ under the License. https://github.com/apache/maven-archetypes/tree/${project.scm.tag} -jira -https://issues

Re: [PR] Enable GitHub issues [maven-archetypes]

2025-05-07 Thread via GitHub
Bukama commented on code in PR #40: URL: https://github.com/apache/maven-archetypes/pull/40#discussion_r2078825248 ## .github/release-drafter.yml: ## @@ -0,0 +1,18 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See th

Re: [PR] Removed InvocationRequest setGoals(List goals)@deprecated [maven-invoker]

2025-05-07 Thread via GitHub
github-actions[bot] commented on PR #82: URL: https://github.com/apache/maven-invoker/pull/82#issuecomment-2861527510 This pull request is stale because it has been waiting for feedback for 60 days. Remove the stale label or comment on this PR, or it will be automatically closed in 30 days.

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2077330309 ## impl/maven-impl/src/test/java/org/apache/maven/impl/model/DefaultModelProcessorTest.java: ## @@ -0,0 +1,139 @@ +package org.apache.maven.impl.model; + +import org.ap

[PR] Enable GitHub issues [maven-archetypes]

2025-05-07 Thread via GitHub
slawekjaranowski opened a new pull request, #40: URL: https://github.com/apache/maven-archetypes/pull/40 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Create android.yml [maven-toolchains-plugin]

2025-05-07 Thread via GitHub
slawekjaranowski commented on PR #56: URL: https://github.com/apache/maven-toolchains-plugin/pull/56#issuecomment-2860488813 it is not a gradle project ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Create android.yml [maven-toolchains-plugin]

2025-05-07 Thread via GitHub
slawekjaranowski closed pull request #56: Create android.yml URL: https://github.com/apache/maven-toolchains-plugin/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Update CreateArchetypeFromProjectMojo.java [maven-archetype]

2025-05-07 Thread via GitHub
slawekjaranowski commented on code in PR #113: URL: https://github.com/apache/maven-archetype/pull/113#discussion_r2078546798 ## maven-archetype-plugin/src/main/java/org/apache/maven/archetype/mojos/CreateArchetypeFromProjectMojo.java: ## @@ -210,7 +210,7 @@ public class CreateA

Re: [PR] fixed required plugin version for the create-from-project goas build stability [maven-archetype]

2025-05-07 Thread via GitHub
slawekjaranowski closed pull request #131: fixed required plugin version for the create-from-project goas build stability URL: https://github.com/apache/maven-archetype/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] fixed required plugin version for the create-from-project goas build stability [maven-archetype]

2025-05-07 Thread via GitHub
slawekjaranowski commented on PR #131: URL: https://github.com/apache/maven-archetype/pull/131#issuecomment-2860448650 we need lock down versions in binding definition, so it will be suppressed by: - #267 -- This is an automated message from the Apache Git Service. To respond to the me

[PR] Lock down plugin versions in maven-archetype packaging [maven-archetype]

2025-05-07 Thread via GitHub
slawekjaranowski opened a new pull request, #267: URL: https://github.com/apache/maven-archetype/pull/267 All versions for plugins used in packaging binding should be defined. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Re-enable issue notifications after jira migration [maven-shared-resources]

2025-05-07 Thread via GitHub
slawekjaranowski merged PR #70: URL: https://github.com/apache/maven-shared-resources/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-uns

[PR] Create android.yml [maven-toolchains-plugin]

2025-05-07 Thread via GitHub
cole67 opened a new pull request, #56: URL: https://github.com/apache/maven-toolchains-plugin/pull/56 https://github.com/cole67/maven-toolchains-plugin/new/master?filename=.github%2Fworkflows%2Fandroid.yml&workflow_template=ci%2Fandroid Following this checklist to help us incorporate

Re: [PR] Pull apache#2301: `Modernize codebase - Bump maven-checkstyle-plugin to: 3.6.0` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2301: URL: https://github.com/apache/maven/pull/2301#discussion_r2078493610 ## its/core-it-support/maven-it-sample-archetype/src/main/resources/archetype-resources/src/test/resources/mng-/checkstyle-test/pom.xml: ## @@ -55,7 +55,7 @@ under

Re: [PR] Pull apache#2301: `Modernize codebase - Bump maven-checkstyle-plugin to: 3.6.0` [maven]

2025-05-07 Thread via GitHub
Pankraz76 closed pull request #2301: Pull apache#2301: `Modernize codebase - Bump maven-checkstyle-plugin to: 3.6.0` URL: https://github.com/apache/maven/pull/2301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on PR #2292: URL: https://github.com/apache/maven/pull/2292#issuecomment-2860345256 > Not sure what you mean exactly, but refactoring is not supposed to change the API in any way. yes of course will adapt then. sorry -- This is an automated message from the Apa

Re: [PR] Fix `JavadocParagraph` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on PR #2302: URL: https://github.com/apache/maven/pull/2302#issuecomment-2860328261 > If you want to enforce a checkstyle rule, you need to enabled it. Where to find it, please? I did not found it locally, assuming it comes from cloud, as I saw some SCV rece

[PR] Fix `JavadocParagraph` [maven-shared-resources]

2025-05-07 Thread via GitHub
Pankraz76 opened a new pull request, #72: URL: https://github.com/apache/maven-shared-resources/pull/72 Fix `JavadocParagraph` - https://github.com/apache/maven/pull/2302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Fix unused stream in DefaultPluginXmlFactory#write [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on PR #2303: URL: https://github.com/apache/maven/pull/2303#issuecomment-2860257509 ty, will add tc as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
gnodet commented on PR #2292: URL: https://github.com/apache/maven/pull/2292#issuecomment-2860229309 > > Adding checked exceptions to the API which relies on unchecked exceptions everywhere is problematic > > Thanks for the feedback. But just to clarify — this reflects what the curre

Re: [PR] Pull apache#2300: `Modernize codebase - Automatically fix Checkstyle violations` [maven]

2025-05-07 Thread via GitHub
gnodet commented on PR #2300: URL: https://github.com/apache/maven/pull/2300#issuecomment-2860068944 Ah, now, you enable the tooling. That's becoming interesting... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on PR #2292: URL: https://github.com/apache/maven/pull/2292#issuecomment-2860054029 > Adding checked exceptions to the API which relies on unchecked exceptions everywhere is problematic Thanks for the feedback. But just to clarify — this reflects what the current

Re: [PR] Pull #3003: `fix unused stream in DefaultPluginXmlFactory#write` [maven]

2025-05-07 Thread via GitHub
gnodet commented on code in PR #2303: URL: https://github.com/apache/maven/pull/2303#discussion_r2078366775 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java: ## @@ -93,7 +93,7 @@ public void write(XmlWriterRequest request) throws XmlWriterEx

Re: [PR] ignore .DS_Store [maven-plugin-testing]

2025-05-07 Thread via GitHub
elharo merged PR #100: URL: https://github.com/apache/maven-plugin-testing/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

Re: [PR] Jira to Github issues [maven-checkstyle-plugin]

2025-05-07 Thread via GitHub
elharo merged PR #175: URL: https://github.com/apache/maven-checkstyle-plugin/pull/175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2078317494 ## impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java: ## @@ -69,25 +72,31 @@ public class DefaultModelProcessor implements ModelProc

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2078312128 ## impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java: ## @@ -97,47 +106,44 @@ public Path locateExistingPom(Path projectDirectory) {

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2078310621 ## impl/maven-impl/src/test/java/org/apache/maven/impl/model/DefaultModelProcessorTest.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2078310207 ## impl/maven-impl/src/test/java/org/apache/maven/impl/model/DefaultModelProcessorTest.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2078307036 ## impl/maven-impl/src/test/java/org/apache/maven/impl/model/DefaultModelProcessorTest.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2078302185 ## impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java: ## @@ -97,47 +101,50 @@ public Path locateExistingPom(Path projectDirectory) {

[jira] [Updated] (MRESOLVER-718) Support dependencyManagement task

2025-05-07 Thread Per Nyfelt (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Per Nyfelt updated MRESOLVER-718: - Description: There does not seem to be a way to support BOM's Adding a dependency with the ty

[PR] Remove clean from the PR template [maven-archetype]

2025-05-07 Thread via GitHub
slawekjaranowski opened a new pull request, #266: URL: https://github.com/apache/maven-archetype/pull/266 Use the same command as in README -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Support for multiple archetypes repositories [maven-archetype]

2025-05-07 Thread via GitHub
slawekjaranowski commented on issue #259: URL: https://github.com/apache/maven-archetype/issues/259#issuecomment-2859623370 PR is welcome -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Pull apache#2301: `Modernize codebase - Bump maven-checkstyle-plugin to: 3.6.0` [maven]

2025-05-07 Thread via GitHub
slawekjaranowski commented on code in PR #2301: URL: https://github.com/apache/maven/pull/2301#discussion_r2078031110 ## its/core-it-support/maven-it-sample-archetype/src/main/resources/archetype-resources/src/test/resources/mng-/checkstyle-test/pom.xml: ## @@ -55,7 +55,7 @@

Re: [PR] Pull #3003: `fix unused stream in DefaultPluginXmlFactory#write` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2303: URL: https://github.com/apache/maven/pull/2303#discussion_r2077833340 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java: ## @@ -81,6 +81,7 @@ public void write(XmlWriterRequest request) throws XmlWriterE

Re: [PR] Pull #3003: `fix DefaultPluginXmlFactory#write` [maven]

2025-05-07 Thread via GitHub
pzygielo commented on code in PR #2303: URL: https://github.com/apache/maven/pull/2303#discussion_r2077830002 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java: ## @@ -81,6 +81,7 @@ public void write(XmlWriterRequest request) throws XmlWriterEx

Re: [PR] Pull #3003: `fix DefaultPluginXmlFactory#write` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on PR #2303: URL: https://github.com/apache/maven/pull/2303#issuecomment-2858891417 [INFO] BUILD SUCCESS -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Pull #3003: `fix DefaultPluginXmlFactory#write` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2303: URL: https://github.com/apache/maven/pull/2303#discussion_r2077796008 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java: ## @@ -93,7 +93,7 @@ public void write(XmlWriterRequest request) throws XmlWriterE

Re: [PR] Pull #3003: `fix DefaultPluginXmlFactory#write` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2303: URL: https://github.com/apache/maven/pull/2303#discussion_r2077792259 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java: ## @@ -93,7 +93,7 @@ public void write(XmlWriterRequest request) throws XmlWriterE

Re: [PR] Pull #3003: `fix DefaultPluginXmlFactory#write` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2303: URL: https://github.com/apache/maven/pull/2303#discussion_r2077788848 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java: ## @@ -93,7 +93,7 @@ public void write(XmlWriterRequest request) throws XmlWriterE

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2077784138 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java: ## @@ -92,7 +93,7 @@ public void write(XmlWriterRequest request) throws XmlWriterE

[PR] Pull #3003: `fix DefaultPluginXmlFactory#write` [maven]

2025-05-07 Thread via GitHub
Pankraz76 opened a new pull request, #2303: URL: https://github.com/apache/maven/pull/2303 Pull #3003: `fix DefaultPluginXmlFactory#write` - https://github.com/apache/maven/pull/2292 - https://github.com/apache/maven/pull/2292/files#r2077643882 -- This is an automated message fro

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2077768586 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java: ## @@ -92,7 +93,7 @@ public void write(XmlWriterRequest request) throws XmlWriterE

Re: [PR] [MNG-8686] Add `SourceRoot.matcher(boolean)` method [maven]

2025-05-07 Thread via GitHub
desruisseaux commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2077727577 ## impl/maven-impl/src/test/java/org/apache/maven/impl/PathSelectorTest.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
elharo commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2077643882 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java: ## @@ -92,7 +93,7 @@ public void write(XmlWriterRequest request) throws XmlWriterEx

Re: [PR] Jira to Github issues [maven-checkstyle-plugin]

2025-05-07 Thread via GitHub
elharo commented on PR #175: URL: https://github.com/apache/maven-checkstyle-plugin/pull/175#issuecomment-2858494423 flaky CI: Caused by: java.io.IOException: Cannot run program "git" (in directory "/home/jenkins/jenkins-home/workspace/x_maven-checkstyle-plugin_PR-175@libs/a1b1c2dbea

Re: [PR] Bump org.codehaus.groovy:groovy-xml from 2.4.16 to 3.0.23 [maven-archetypes]

2025-05-07 Thread via GitHub
dependabot[bot] commented on PR #37: URL: https://github.com/apache/maven-archetypes/pull/37#issuecomment-2858404070 Superseded by #39. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[PR] Bump org.codehaus.groovy:groovy-xml from 2.4.16 to 3.0.24 [maven-archetypes]

2025-05-07 Thread via GitHub
dependabot[bot] opened a new pull request, #39: URL: https://github.com/apache/maven-archetypes/pull/39 Bumps [org.codehaus.groovy:groovy-xml](https://github.com/apache/groovy) from 2.4.16 to 3.0.24. Commits See full diff in https://github.com/apache/groovy/commits";>compare vi

Re: [PR] Bump org.codehaus.groovy:groovy-xml from 2.4.16 to 3.0.23 [maven-archetypes]

2025-05-07 Thread via GitHub
dependabot[bot] closed pull request #37: Bump org.codehaus.groovy:groovy-xml from 2.4.16 to 3.0.23 URL: https://github.com/apache/maven-archetypes/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[PR] Bump org.apache.maven:maven-parent from 43 to 44 [maven-archetypes]

2025-05-07 Thread via GitHub
dependabot[bot] opened a new pull request, #38: URL: https://github.com/apache/maven-archetypes/pull/38 Bumps [org.apache.maven:maven-parent](https://github.com/apache/maven-parent) from 43 to 44. Release notes Sourced from https://github.com/apache/maven-parent/releases";>org.apa

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2077437814 ## impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java: ## @@ -39,27 +39,29 @@ import org.apache.maven.api.spi.ModelParser; import or

Re: [PR] Pull apache#2302: `Modernize codebase - fix JavadocParagraph` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on PR #2302: URL: https://github.com/apache/maven/pull/2302#issuecomment-2858339520 [INFO] BUILD SUCCESS -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Pull apache#2301: `Modernize codebase - Bump maven-checkstyle-plugin to: 3.6.0` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2301: URL: https://github.com/apache/maven/pull/2301#discussion_r2077352829 ## its/core-it-support/maven-it-sample-archetype/src/main/resources/archetype-resources/src/test/resources/mng-/checkstyle-test/pom.xml: ## @@ -55,7 +55,7 @@ under

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2077453834 ## impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java: ## @@ -77,17 +79,19 @@ public DefaultModelProcessor(ModelXmlFactory modelXmlFa

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2077453834 ## impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java: ## @@ -77,17 +79,19 @@ public DefaultModelProcessor(ModelXmlFactory modelXmlFa

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2077453834 ## impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java: ## @@ -77,17 +79,19 @@ public DefaultModelProcessor(ModelXmlFactory modelXmlFa

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2077453834 ## impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java: ## @@ -77,17 +79,19 @@ public DefaultModelProcessor(ModelXmlFactory modelXmlFa

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on PR #2292: URL: https://github.com/apache/maven/pull/2292#issuecomment-2858286975 is this any good? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2077449143 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java: ## @@ -109,7 +110,7 @@ public void write(XmlWriterRequest request) throws XmlWrite

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2077415845 ## impl/maven-impl/src/test/java/org/apache/maven/impl/model/DefaultModelProcessorTest.java: ## @@ -0,0 +1,139 @@ +package org.apache.maven.impl.model; + +import org.ap

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2077436936 ## impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java: ## @@ -97,47 +101,50 @@ public Path locateExistingPom(Path projectDirectory) {

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2077437814 ## impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java: ## @@ -39,27 +39,29 @@ import org.apache.maven.api.spi.ModelParser; import or

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2077437814 ## impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java: ## @@ -39,27 +39,29 @@ import org.apache.maven.api.spi.ModelParser; import or

Re: [PR] [MNG-8686] Add `SourceRoot.matcher(boolean)` method [maven]

2025-05-07 Thread via GitHub
elharo commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2077437770 ## impl/maven-impl/src/test/java/org/apache/maven/impl/PathSelectorTest.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2077437814 ## impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java: ## @@ -39,27 +39,29 @@ import org.apache.maven.api.spi.ModelParser; import or

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2077436936 ## impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java: ## @@ -97,47 +101,50 @@ public Path locateExistingPom(Path projectDirectory) {

Re: [PR] [MNG-8686] Add `SourceRoot.matcher(boolean)` method [maven]

2025-05-07 Thread via GitHub
elharo commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2077435547 ## impl/maven-impl/src/test/java/org/apache/maven/impl/PathSelectorTest.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2077415845 ## impl/maven-impl/src/test/java/org/apache/maven/impl/model/DefaultModelProcessorTest.java: ## @@ -0,0 +1,139 @@ +package org.apache.maven.impl.model; + +import org.ap

Re: [PR] Pull apache#2301: `Modernize codebase - Bump maven-checkstyle-plugin to: 3.6.0` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2301: URL: https://github.com/apache/maven/pull/2301#discussion_r2077352829 ## its/core-it-support/maven-it-sample-archetype/src/main/resources/archetype-resources/src/test/resources/mng-/checkstyle-test/pom.xml: ## @@ -55,7 +55,7 @@ under

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2077332746 ## impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java: ## @@ -137,7 +139,7 @@ private Path doLocateExistingPom(Path project) {

Re: [PR] Pull #2292: `Modernize codebase with Java improvements - functionalize DefaultModelProcessor#read` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2292: URL: https://github.com/apache/maven/pull/2292#discussion_r2077330309 ## impl/maven-impl/src/test/java/org/apache/maven/impl/model/DefaultModelProcessorTest.java: ## @@ -0,0 +1,139 @@ +package org.apache.maven.impl.model; + +import org.ap

Re: [PR] Pull #2290: Modernize codebase with Java improvements - Replace custom null checks with `Objects.requireNonNull` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2290: URL: https://github.com/apache/maven/pull/2290#discussion_r2077285108 ## impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultModelXmlFactoryTest.java: ## @@ -105,7 +105,7 @@ void testNoNamespaceWithModelVersion400() throws Exceptio

[jira] [Closed] (MNG-8720) Warning about root directory and multiModuleProjectDirectory not being aligned doesn't account for symlinks

2025-05-07 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8720. Resolution: Fixed > Warning about root directory and multiModuleProjectDirectory not being > aligned

Re: [PR] [MNG-8720] Fix for symlinked project directory [maven]

2025-05-07 Thread via GitHub
cstamas merged PR #2289: URL: https://github.com/apache/maven/pull/2289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

Re: [PR] [MNG-8720] Fix for symlinked project directory [maven]

2025-05-07 Thread via GitHub
cstamas commented on PR #2289: URL: https://github.com/apache/maven/pull/2289#issuecomment-2857763259 ``` [cstamas@angeleyes bar (main)]$ mvn -V validate Apache Maven 4.0.0-rc-3 (3952d00ce65df6753b63a51e86b1f626c55a8df2) Maven home: /home/cstamas/.sdkman/candidates/maven/4.0.0-rc-3

[jira] [Commented] (MNG-8720) Warning about root directory and multiModuleProjectDirectory not being aligned doesn't account for symlinks

2025-05-07 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949936#comment-17949936 ] Tamas Cservenak commented on MNG-8720: -- {noformat} [cstamas@angeleyes bar (main)]$ mvn

Re: [PR] Pull #2290: Modernize codebase with Java improvements - Replace custom null checks with `Objects.requireNonNull` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on code in PR #2290: URL: https://github.com/apache/maven/pull/2290#discussion_r2077038119 ## impl/maven-impl/src/main/java/org/apache/maven/impl/ImplUtils.java: ## @@ -25,18 +25,21 @@ import java.util.stream.Collectors; class ImplUtils { + +/** +

Re: [PR] Pull #2282: `Add project icon for IntelliJ IDEA` [maven]

2025-05-07 Thread via GitHub
Pankraz76 commented on PR #2283: URL: https://github.com/apache/maven/pull/2283#issuecomment-2857459810 ref: - https://github.com/editorconfig/editorconfig/issues/425 - https://github.com/checkstyle/checkstyle/issues/16813 - https://github.com/checkstyle/checkstyle/pull/16815

Re: [I] Issue with cucumber tests [maven-surefire]

2025-05-07 Thread via GitHub
meltz-dev closed issue #840: Issue with cucumber tests URL: https://github.com/apache/maven-surefire/issues/840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] Issue with cucumber tests [maven-surefire]

2025-05-07 Thread via GitHub
meltz-dev commented on issue #840: URL: https://github.com/apache/maven-surefire/issues/840#issuecomment-2857408304 > Given https://issues.apache.org/jira/browse/SUREFIRE-2299 is still open, I suppose this could be closed. I was not aware of this external issue tracker, thank you. -