slawekjaranowski commented on code in PR #37:
URL:
https://github.com/apache/maven-jdeprscan-plugin/pull/37#discussion_r2072537236
##
.github/workflows/maven.yaml:
##
@@ -1,54 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license a
slawekjaranowski commented on code in PR #37:
URL:
https://github.com/apache/maven-jdeprscan-plugin/pull/37#discussion_r2072536433
##
.github/workflows/maven.yaml:
##
@@ -1,54 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license a
desruisseaux closed issue #327: master does not build on windows with Maven
4.0.0-rc-3
URL: https://github.com/apache/maven-compiler-plugin/issues/327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
desruisseaux commented on issue #326:
URL:
https://github.com/apache/maven-compiler-plugin/issues/326#issuecomment-2848906022
Fixed by f97b68368d753be6125d3d18dfefc4c814e42a54.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
desruisseaux closed issue #326: API incompatibility when using Maven 4.0.0-RC3
URL: https://github.com/apache/maven-compiler-plugin/issues/326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
desruisseaux merged PR #318:
URL: https://github.com/apache/maven-compiler-plugin/pull/318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubs
desruisseaux commented on PR #318:
URL:
https://github.com/apache/maven-compiler-plugin/pull/318#issuecomment-2848898498
@dependabot recreate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] closed pull request #319: Bump
org.apache.maven.plugin-testing:maven-plugin-testing-harness from 4.0.0-beta-3
to 4.0.0-beta-4
URL: https://github.com/apache/maven-compiler-plugin/pull/319
--
This is an automated message from the Apache Git Service.
To respond to the message,
dependabot[bot] commented on PR #319:
URL:
https://github.com/apache/maven-compiler-plugin/pull/319#issuecomment-2848898212
Looks like org.apache.maven.plugin-testing:maven-plugin-testing-harness is
up-to-date now, so this is no longer needed.
--
This is an automated message from the Apa
desruisseaux commented on PR #319:
URL:
https://github.com/apache/maven-compiler-plugin/pull/319#issuecomment-2848897984
@dependabot recreate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
desruisseaux commented on PR #324:
URL:
https://github.com/apache/maven-compiler-plugin/pull/324#issuecomment-2848896081
@dependabot recreate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
desruisseaux commented on PR #315:
URL:
https://github.com/apache/maven-compiler-plugin/pull/315#issuecomment-2848893411
@dependabot recreate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] closed pull request #308: Bump mavenVersion from 4.0.0-rc-2 to
4.0.0-rc-3
URL: https://github.com/apache/maven-compiler-plugin/pull/308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
dependabot[bot] commented on PR #308:
URL:
https://github.com/apache/maven-compiler-plugin/pull/308#issuecomment-2848892897
Looks like these dependencies are up-to-date now, so this is no longer
needed.
--
This is an automated message from the Apache Git Service.
To respond to the messag
desruisseaux commented on PR #308:
URL:
https://github.com/apache/maven-compiler-plugin/pull/308#issuecomment-2848892706
@dependabot recreate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] commented on PR #308:
URL:
https://github.com/apache/maven-compiler-plugin/pull/308#issuecomment-2848892477
Looks like this PR has been edited by someone other than Dependabot. That
means Dependabot can't rebase it - sorry!
If you're happy for Dependabot to recreate i
desruisseaux commented on PR #308:
URL:
https://github.com/apache/maven-compiler-plugin/pull/308#issuecomment-2848892467
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
desruisseaux merged PR #320:
URL: https://github.com/apache/maven-compiler-plugin/pull/320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubs
desruisseaux commented on PR #250:
URL:
https://github.com/apache/maven-clean-plugin/pull/250#issuecomment-2848831018
Right, #246 is filled against 3.x and indeed would be a separated PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
slawekjaranowski commented on PR #250:
URL:
https://github.com/apache/maven-clean-plugin/pull/250#issuecomment-2848829491
> Fix #109 and #246.
I'm afraid that issues will not be fixed as issues are reported for version
3.x ...
This is for 4.x
--
This is an automated messag
slawekjaranowski commented on code in PR #2285:
URL: https://github.com/apache/maven/pull/2285#discussion_r2072473521
##
impl/maven-core/src/main/java/org/apache/maven/DefaultMaven.java:
##
@@ -408,7 +408,10 @@ private void persistResumptionData(MavenExecutionResult
result, Mav
desruisseaux commented on PR #250:
URL:
https://github.com/apache/maven-clean-plugin/pull/250#issuecomment-2848826808
Fix #109 and #246.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
desruisseaux opened a new pull request, #250:
URL: https://github.com/apache/maven-clean-plugin/pull/250
Add a `force` configuration option for deleting read-only files and
directories. This is required because `java.nio.file.Files.delete` does not
remove the read-only attribute, contrarily
slawekjaranowski opened a new pull request, #2296:
URL: https://github.com/apache/maven/pull/2296
https://issues.apache.org/jira/browse/MNG-8169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
[
https://issues.apache.org/jira/browse/MNG-8169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski reassigned MNG-8169:
Assignee: Slawomir Jaranowski
> MINGW support requires --add-opens java.base/java.la
desruisseaux merged PR #243:
URL: https://github.com/apache/maven-clean-plugin/pull/243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
cstamas commented on code in PR #2285:
URL: https://github.com/apache/maven/pull/2285#discussion_r2072470154
##
impl/maven-core/src/main/java/org/apache/maven/DefaultMaven.java:
##
@@ -408,7 +408,10 @@ private void persistResumptionData(MavenExecutionResult
result, MavenSession
cstamas commented on code in PR #2285:
URL: https://github.com/apache/maven/pull/2285#discussion_r2072468748
##
impl/maven-core/src/main/java/org/apache/maven/DefaultMaven.java:
##
@@ -408,7 +408,10 @@ private void persistResumptionData(MavenExecutionResult
result, MavenSession
[
https://issues.apache.org/jira/browse/MNG-8717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MNG-8717.
Resolution: Fixed
> Remove maven-plugin-plugin:addPluginArtifactMetadata from default binding
slawekjaranowski merged PR #2295:
URL: https://github.com/apache/maven/pull/2295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@mave
slawekjaranowski merged PR #403:
URL: https://github.com/apache/maven-integration-testing/pull/403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issue
slawekjaranowski merged PR #2294:
URL: https://github.com/apache/maven/pull/2294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@mave
slawekjaranowski commented on code in PR #2285:
URL: https://github.com/apache/maven/pull/2285#discussion_r2072467286
##
impl/maven-core/src/main/java/org/apache/maven/DefaultMaven.java:
##
@@ -408,7 +408,10 @@ private void persistResumptionData(MavenExecutionResult
result, Mav
[
https://issues.apache.org/jira/browse/MNG-8169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949210#comment-17949210
]
Slawomir Jaranowski commented on MNG-8169:
--
As jansi will be no longer maintained
Pankraz76 commented on code in PR #211:
URL:
https://github.com/apache/maven-build-cache-extension/pull/211#discussion_r2072464627
##
.github/workflows/maven-verify.yml:
##
@@ -29,6 +29,6 @@ jobs:
maven-args: '-D"maven.test.redirectTestOutputToFile=false"'
maven-m
slawekjaranowski commented on code in PR #211:
URL:
https://github.com/apache/maven-build-cache-extension/pull/211#discussion_r2072461022
##
.github/workflows/maven-verify.yml:
##
@@ -29,6 +29,6 @@ jobs:
maven-args: '-D"maven.test.redirectTestOutputToFile=false"'
Pankraz76 commented on PR #211:
URL:
https://github.com/apache/maven-build-cache-extension/pull/211#issuecomment-2848785781
> Nobody stops you from using 21 at runtime. What is the point having it at
build time?
> new language features like record patterns and string templates.
Pankraz76 commented on PR #201:
URL: https://github.com/apache/maven-pmd-plugin/pull/201#issuecomment-2848783517
yes if not fully agreed upon nor approved efforts should be kept small
before investing.
--
This is an automated message from the Apache Git Service.
To respond to the message,
michael-o commented on PR #201:
URL: https://github.com/apache/maven-pmd-plugin/pull/201#issuecomment-2848782468
@slachiewicz Why are you entertaning this and wasting your time? I'd close
it straight away.
--
This is an automated message from the Apache Git Service.
To respond to the mess
michael-o commented on PR #211:
URL:
https://github.com/apache/maven-build-cache-extension/pull/211#issuecomment-2848782189
Nobody stops you from using 21 at runtime. What is the point having it at
build time?
--
This is an automated message from the Apache Git Service.
To respond to the
slawekjaranowski commented on PR #2295:
URL: https://github.com/apache/maven/pull/2295#issuecomment-2848774365
and IT fix - https://github.com/apache/maven-integration-testing/pull/403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
slawekjaranowski opened a new pull request, #403:
URL: https://github.com/apache/maven-integration-testing/pull/403
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
[
https://issues.apache.org/jira/browse/MNG-8717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949195#comment-17949195
]
Slawomir Jaranowski commented on MNG-8717:
--
Result of this goal only was needed by
cstamas commented on PR #691:
URL: https://github.com/apache/maven-resolver/pull/691#issuecomment-2848697478
> Yes, that that is no problem. The structure is identical to src/site.
Cool! Resolver and Maven would gladly accept a PR that is fixing this
:smile:
--
This is an automate
Bukama opened a new pull request, #775:
URL: https://github.com/apache/maven-site/pull/775
Enable Githuss Issues for:
[MGPG](https://github.com/apache/maven-gpg-plugin/pull/134)
[MPH](https://github.com/apache/maven-help-plugin/pull/131)
[MINVOKER](https://github.com/apache/maven
Bukama opened a new pull request, #55:
URL: https://github.com/apache/maven-toolchains-plugin/pull/55
* Release and Milestone already there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
Bukama opened a new pull request, #19:
URL: https://github.com/apache/maven-stage-plugin/pull/19
* No release due no PR
* Milestone created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Bukama opened a new pull request, #55:
URL: https://github.com/apache/maven-scm-publish-plugin/pull/55
* Release and milestone created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Bukama opened a new pull request, #242:
URL: https://github.com/apache/maven-scm/pull/242
* Release and milestone created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
michael-o commented on PR #691:
URL: https://github.com/apache/maven-resolver/pull/691#issuecomment-2848595314
> Is markdown supported? And can i enlist the generated file in site.xml as
a side menu entry?
Yes, that that is no problem. The structure is identical to src/site.
--
Thi
Markus Karg created MNG-8721:
Summary: Prints Warnings about JANSI when running on JDK 24
Key: MNG-8721
URL: https://issues.apache.org/jira/browse/MNG-8721
Project: Maven
Issue Type: Bug
cstamas commented on PR #691:
URL: https://github.com/apache/maven-resolver/pull/691#issuecomment-2848586484
Is markdown supported? And can i enlist the generated file in site.xml as a
side menu entry?
--
This is an automated message from the Apache Git Service.
To respond to the message,
Pankraz76 commented on PR #2291:
URL: https://github.com/apache/maven/pull/2291#issuecomment-2848568999
> This may lead to incompatibilities if someone overrides a protected method
and actually throw one exception that you removed
new contract is not to throw; with checked it wont com
Pankraz76 commented on code in PR #2287:
URL: https://github.com/apache/maven/pull/2287#discussion_r2072371193
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultChecksumAlgorithmService.java:
##
@@ -75,9 +74,9 @@ public ChecksumAlgorithm select(String algorithmName)
Pankraz76 commented on PR #211:
URL:
https://github.com/apache/maven-build-cache-extension/pull/211#issuecomment-2848547747
- https://github.com/pmd/pmd/pull/5714
-
https://github.com/checkstyle/checkstyle/issues/16981#issuecomment-2841063249
> Java 21 brings significant improveme
gnodet commented on PR #2293:
URL: https://github.com/apache/maven/pull/2293#issuecomment-2848545196
> > The PR removes part of the API. It's not dead code, it's an API.
>
> yes i was wondering about this myself. But then adding a simple test to
make it used is a good thing, right?
Pankraz76 commented on PR #2292:
URL: https://github.com/apache/maven/pull/2292#issuecomment-2848545027
> This totally breaks the exception handling.
yes, then we need test, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Pankraz76 commented on code in PR #2292:
URL: https://github.com/apache/maven/pull/2292#discussion_r2072361875
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelProcessor.java:
##
@@ -97,30 +95,20 @@ public Path locateExistingPom(Path projectDirectory) {
Pankraz76 commented on PR #2293:
URL: https://github.com/apache/maven/pull/2293#issuecomment-2848544588
> The PR removes part of the API. It's not dead code, it's an API.
yes i was wondering about this myself. But then adding a simple test to make
it used is a good thing, right?
--
slachiewicz commented on PR #165:
URL: https://github.com/apache/maven-parent/pull/165#issuecomment-2848541345
Maven-parent is used for other Maven projects that we maintain, where the
base is java 8. If we remove it now - we need to adjust around 100 repos.
Please think also about backward
gnodet commented on code in PR #2289:
URL: https://github.com/apache/maven/pull/2289#discussion_r2072360063
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/rootlocator/DefaultRootLocator.java:
##
@@ -64,8 +66,14 @@ public Path findMandatoryRoot(@Nonnull Path basedir
[
https://issues.apache.org/jira/browse/MNG-8717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949149#comment-17949149
]
Guillaume Nodet commented on MNG-8717:
--
And what if someone uses an old version of mav
slachiewicz commented on PR #201:
URL: https://github.com/apache/maven-pmd-plugin/pull/201#issuecomment-2848539110
Yes this file. Documentation for our gha can be found here
https://github.com/apache/maven-gh-actions-shared
--
This is an automated message from the Apache Git Ser
gnodet commented on code in PR #2287:
URL: https://github.com/apache/maven/pull/2287#discussion_r2072359212
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultChecksumAlgorithmService.java:
##
@@ -75,9 +74,9 @@ public ChecksumAlgorithm select(String algorithmName) {
gnodet commented on PR #2293:
URL: https://github.com/apache/maven/pull/2293#issuecomment-2848534534
The PR removes part of the API. It's not dead code, it's an API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
gnodet closed pull request #2293: Pull #2292: `Modernize codebase with Java
improvements - remove dead code`
URL: https://github.com/apache/maven/pull/2293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
slawekjaranowski opened a new pull request, #2295:
URL: https://github.com/apache/maven/pull/2295
https://issues.apache.org/jira/browse/MNG-8717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
slawekjaranowski opened a new pull request, #2294:
URL: https://github.com/apache/maven/pull/2294
https://issues.apache.org/jira/browse/MNG-8717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
olamy commented on PR #211:
URL:
https://github.com/apache/maven-build-cache-extension/pull/211#issuecomment-2848529776
I would say I'm a bit sceptical here.
What is the added value, except for preventing people stuck with 17, from
using the cache?
--
This is an automated message fro
Pankraz76 commented on PR #201:
URL: https://github.com/apache/maven-pmd-plugin/pull/201#issuecomment-2848522846
you mean this?
https://github.com/apache/maven-pmd-plugin/blob/master/.github/workflows/maven-verify.yml
I did not found any java version in this and googled:
https://githu
Pankraz76 opened a new pull request, #211:
URL: https://github.com/apache/maven-build-cache-extension/pull/211
- https://github.com/apache/maven-pmd-plugin/pull/201
- https://github.com/apache/maven-pmd-plugin/pull/201#issuecomment-2848187270
Following this checklist to help us inco
Pankraz76 commented on PR #2277:
URL: https://github.com/apache/maven/pull/2277#issuecomment-2848515253
> @Pankraz76 I'm not sure what you aim for with your PRs. How do they differ
from this one ? It's fine very fine that you used openrewrite rules, but isn't
the result the same at the end
[
https://issues.apache.org/jira/browse/MNG-8717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949137#comment-17949137
]
Slawomir Jaranowski commented on MNG-8717:
--
[~cstamas]
{quote}
Yup, go for it. Sti
Bukama commented on PR #165:
URL: https://github.com/apache/maven-parent/pull/165#issuecomment-2848475204
I guess I was not clear what I mean. As of kno (3.x) you can specifiy
release8 and the compiler plugin turns that into source/target if you are on
JDK 8, which does not know release. Bu
74 matches
Mail list logo
