[jira] [Commented] (MSHARED-1351) Confusing message when copying resources from project's baseDir

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807922#comment-17807922 ] ASF GitHub Bot commented on MSHARED-1351: - abelsromero commented on code in PR

Re: [PR] [MSHARED-1351] Fix console message when origin is baseDir [maven-filtering]

2024-01-17 Thread via GitHub
abelsromero commented on code in PR #93: URL: https://github.com/apache/maven-filtering/pull/93#discussion_r1456564669 ## src/test/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFilteringTest.java: ## @@ -24,13 +24,10 @@ import java.io.FileInputStream; import java

Re: [PR] [MSHARED-1351] Fix console message when origin is baseDir [maven-filtering]

2024-01-17 Thread via GitHub
abelsromero commented on code in PR #93: URL: https://github.com/apache/maven-filtering/pull/93#discussion_r1456564669 ## src/test/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFilteringTest.java: ## @@ -24,13 +24,10 @@ import java.io.FileInputStream; import java

[jira] [Commented] (MSHARED-1351) Confusing message when copying resources from project's baseDir

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807921#comment-17807921 ] ASF GitHub Bot commented on MSHARED-1351: - abelsromero commented on code in PR

[jira] [Commented] (MSHARED-1351) Confusing message when copying resources from project's baseDir

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807920#comment-17807920 ] ASF GitHub Bot commented on MSHARED-1351: - abelsromero commented on code in PR

Re: [PR] [MSHARED-1351] Fix console message when origin is baseDir [maven-filtering]

2024-01-17 Thread via GitHub
abelsromero commented on code in PR #93: URL: https://github.com/apache/maven-filtering/pull/93#discussion_r1456561815 ## src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java: ## @@ -254,9 +255,15 @@ private File getTargetFile(File file) throws Ma

[jira] [Commented] (MSHADE-462) 3.5.1 not compatible with 3.4.1: The version cannot be empty

2024-01-17 Thread Justin Bertram (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807919#comment-17807919 ] Justin Bertram commented on MSHADE-462: --- I just hit this on ActiveMQ Artemis when t

Re: [PR] Session factory extender [maven]

2024-01-17 Thread via GitHub
cstamas commented on PR #1384: URL: https://github.com/apache/maven/pull/1384#issuecomment-1896990629 Fixing the UT (changed the source of props) is now beyond my current capabls :smile: but @gnodet i think you see what the goal is: have some _internal_ stuff that mediates. -- This is an

[jira] [Commented] (DOXIASITETOOLS-327) Support multi-language for menu "name"

2024-01-17 Thread Abel Salgado Romero (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807905#comment-17807905 ] Abel Salgado Romero commented on DOXIASITETOOLS-327: Thanks!

Re: [PR] Session factory extender [maven]

2024-01-17 Thread via GitHub
cstamas commented on code in PR #1384: URL: https://github.com/apache/maven/pull/1384#discussion_r1456503763 ## maven-core/src/main/java/org/apache/maven/session/RepositorySystemSessionExtender.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Session factory extender [maven]

2024-01-17 Thread via GitHub
gnodet commented on code in PR #1384: URL: https://github.com/apache/maven/pull/1384#discussion_r1456496944 ## maven-core/src/main/java/org/apache/maven/session/RepositorySystemSessionExtender.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Session factory extender [maven]

2024-01-17 Thread via GitHub
gnodet commented on code in PR #1384: URL: https://github.com/apache/maven/pull/1384#discussion_r1456496944 ## maven-core/src/main/java/org/apache/maven/session/RepositorySystemSessionExtender.java: ## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[jira] [Commented] (MRESOLVER-464) JDK transport bug

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807860#comment-17807860 ] ASF GitHub Bot commented on MRESOLVER-464: -- rmannibucau commented on PR #408:

Re: [PR] [MRESOLVER-464] Workaround for JDK-822647 bug [maven-resolver]

2024-01-17 Thread via GitHub
rmannibucau commented on PR #408: URL: https://github.com/apache/maven-resolver/pull/408#issuecomment-1896498271 > So the workaround is that if you hit this issue with remote repository "foo", then you can check in .mvn/maven.config that sets proper value for repository "foo" (check the con

[jira] [Commented] (MRESOLVER-464) JDK transport bug

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807845#comment-17807845 ] ASF GitHub Bot commented on MRESOLVER-464: -- cstamas commented on PR #408: URL

Re: [PR] [MRESOLVER-464] Workaround for JDK-822647 bug [maven-resolver]

2024-01-17 Thread via GitHub
cstamas commented on PR #408: URL: https://github.com/apache/maven-resolver/pull/408#issuecomment-1896389068 > Now about your fix we still have the same issue, you set it to 100 but then it is set to 12 so maybe we should revert and default to http1? Hence the "workaround": exposed co

[jira] [Comment Edited] (MNG-7539) Validate/Download SNAPSHOT dependencies once

2024-01-17 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807844#comment-17807844 ] Tamas Cservenak edited comment on MNG-7539 at 1/17/24 6:23 PM: --

[jira] [Commented] (MNG-7539) Validate/Download SNAPSHOT dependencies once

2024-01-17 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807844#comment-17807844 ] Tamas Cservenak commented on MNG-7539: -- Just to be on safe side, went to reproduce, bu

[jira] [Commented] (MRESOLVER-464) JDK transport bug

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807840#comment-17807840 ] ASF GitHub Bot commented on MRESOLVER-464: -- rmannibucau commented on PR #408:

Re: [PR] [MRESOLVER-464] Workaround for JDK-822647 bug [maven-resolver]

2024-01-17 Thread via GitHub
rmannibucau commented on PR #408: URL: https://github.com/apache/maven-resolver/pull/408#issuecomment-1896342446 It works cause it is per connection but agree it is bad from a design standpoint - but it is http2, we cant help. As a side note my thread count for resolver is always 512

Re: [PR] [MRESOLVER-464] Workaround for JDK-822647 bug [maven-resolver]

2024-01-17 Thread via GitHub
cstamas commented on PR #408: URL: https://github.com/apache/maven-resolver/pull/408#issuecomment-1896309679 Wrong, as if remote server on first response tells client "my max_concurrent_stream=12" then client will have to obey it AFAIK. Again, see first paragraph. Yes, instead of Inte

[jira] [Commented] (MRESOLVER-464) JDK transport bug

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807835#comment-17807835 ] ASF GitHub Bot commented on MRESOLVER-464: -- cstamas commented on PR #408: URL

[jira] [Commented] (MRESOLVER-464) JDK transport bug

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807831#comment-17807831 ] ASF GitHub Bot commented on MRESOLVER-464: -- rmannibucau commented on PR #408:

Re: [PR] [MRESOLVER-464] Workaround for JDK-822647 bug [maven-resolver]

2024-01-17 Thread via GitHub
rmannibucau commented on PR #408: URL: https://github.com/apache/maven-resolver/pull/408#issuecomment-1896294912 > the fact HttpClient inits this value to Integer.MAX_VALUE and lowers it on first response just means each connection much await the first response, a semaphore does not

[jira] [Comment Edited] (MNG-7539) Validate/Download SNAPSHOT dependencies once

2024-01-17 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807828#comment-17807828 ] Tamas Cservenak edited comment on MNG-7539 at 1/17/24 5:32 PM: --

[jira] [Commented] (MNG-7539) Validate/Download SNAPSHOT dependencies once

2024-01-17 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807828#comment-17807828 ] Tamas Cservenak commented on MNG-7539: -- Checked Maven 3.8.x branch as well, does the v

[jira] [Assigned] (MRESOLVER-464) JDK transport bug

2024-01-17 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOLVER-464: - Assignee: Tamas Cservenak > JDK transport bug > - > >

[jira] [Updated] (MRESOLVER-463) Ensure checksum record file (summary fie) is sorted by artifact relative path and not checksum

2024-01-17 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-463: -- Component/s: Resolver > Ensure checksum record file (summary fie) is sorted by artif

[jira] [Commented] (MRESOLVER-464) JDK transport bug

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807822#comment-17807822 ] ASF GitHub Bot commented on MRESOLVER-464: -- cstamas commented on PR #408: URL

Re: [PR] [MRESOLVER-464] Workaround for JDK-822647 bug [maven-resolver]

2024-01-17 Thread via GitHub
cstamas commented on PR #408: URL: https://github.com/apache/maven-resolver/pull/408#issuecomment-1896267693 Ah, so if you mean the system property, that will set it, but will it queue requests over 100? -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Closed] (MRESOLVER-464) JDK transport bug

2024-01-17 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOLVER-464. - Resolution: Fixed > JDK transport bug > - > > Key: MRE

[jira] [Commented] (MRESOLVER-464) JDK transport bug

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807821#comment-17807821 ] ASF GitHub Bot commented on MRESOLVER-464: -- cstamas commented on PR #408: URL

Re: [PR] [MRESOLVER-464] Workaround for JDK-822647 bug [maven-resolver]

2024-01-17 Thread via GitHub
cstamas commented on PR #408: URL: https://github.com/apache/maven-resolver/pull/408#issuecomment-1896262783 @rmannibucau sorry, we did it at same moment :smile: Can you provide a PR to show what you mean? Also, the fact HttpClient _inits_ this value to `Integer.MAX_VALUE` and lowers

[jira] [Commented] (MRESOLVER-464) JDK transport bug

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807819#comment-17807819 ] ASF GitHub Bot commented on MRESOLVER-464: -- rmannibucau commented on PR #408:

[jira] [Commented] (MRESOLVER-464) JDK transport bug

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807820#comment-17807820 ] ASF GitHub Bot commented on MRESOLVER-464: -- cstamas merged PR #408: URL: http

Re: [PR] [MRESOLVER-464] Workaround for JDK-822647 bug [maven-resolver]

2024-01-17 Thread via GitHub
cstamas merged PR #408: URL: https://github.com/apache/maven-resolver/pull/408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

Re: [PR] [MRESOLVER-464] Workaround for JDK-822647 bug [maven-resolver]

2024-01-17 Thread via GitHub
rmannibucau commented on PR #408: URL: https://github.com/apache/maven-resolver/pull/408#issuecomment-1896260133 why not using `jdk.httpclient.maxstreams`? I kind of fail to see how a semaphore helps, we should just ensure to respect server settings no, so a "warmup" call then we know and j

[jira] [Commented] (MRESOLVER-464) JDK transport bug

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807811#comment-17807811 ] ASF GitHub Bot commented on MRESOLVER-464: -- cstamas opened a new pull request

[PR] [MRESOLVER-464] Workaround for JDK-822647 bug [maven-resolver]

2024-01-17 Thread via GitHub
cstamas opened a new pull request, #408: URL: https://github.com/apache/maven-resolver/pull/408 Artificially limit the max concurrent request count doable with JDK HttpClient, as otherwise you may end up with IOEx. The value is exposed as config param, so users can tweak it. Valu

[jira] [Commented] (MNG-8015) Control the type of path where each dependency can be placed

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807798#comment-17807798 ] ASF GitHub Bot commented on MNG-8015: - cstamas commented on code in PR #1378: URL: http

Re: [PR] [MNG-8015] Control the type of path where each dependency can be placed [maven]

2024-01-17 Thread via GitHub
cstamas commented on code in PR #1378: URL: https://github.com/apache/maven/pull/1378#discussion_r1455986899 ## api/maven-api-core/src/main/java/org/apache/maven/api/DependencyProperties.java: ## @@ -33,27 +36,226 @@ @Immutable public interface DependencyProperties { /**

[jira] [Commented] (MNG-8015) Control the type of path where each dependency can be placed

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807789#comment-17807789 ] ASF GitHub Bot commented on MNG-8015: - desruisseaux commented on code in PR #1378: URL:

Re: [PR] [MNG-8015] Control the type of path where each dependency can be placed [maven]

2024-01-17 Thread via GitHub
desruisseaux commented on code in PR #1378: URL: https://github.com/apache/maven/pull/1378#discussion_r1455933266 ## api/maven-api-core/src/main/java/org/apache/maven/api/DependencyProperties.java: ## @@ -33,27 +36,226 @@ @Immutable public interface DependencyProperties {

[jira] [Closed] (MRESOLVER-465) Make room for new version scheme implementations

2024-01-17 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOLVER-465. - Resolution: Fixed > Make room for new version scheme implementations > ---

[jira] [Commented] (MRESOLVER-465) Make room for new version scheme implementations

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1780#comment-1780 ] ASF GitHub Bot commented on MRESOLVER-465: -- cstamas merged PR #407: URL: http

Re: [PR] [MRESOLVER-465] Make room for alternate version scheme [maven-resolver]

2024-01-17 Thread via GitHub
cstamas merged PR #407: URL: https://github.com/apache/maven-resolver/pull/407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

Re: [PR] Make ArtifactFilter into a Predicate [maven]

2024-01-17 Thread via GitHub
cstamas closed pull request #1383: Make ArtifactFilter into a Predicate URL: https://github.com/apache/maven/pull/1383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Make ArtifactFilter into a Predicate [maven]

2024-01-17 Thread via GitHub
cstamas commented on PR #1383: URL: https://github.com/apache/maven/pull/1383#issuecomment-1896060763 Meh, this was just an experiment... am dropping this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (MRELEASE-1137) git path suffix from submodule

2024-01-17 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807776#comment-17807776 ] Michael Osipov commented on MRELEASE-1137: -- I bet the git provider is not de

[jira] [Commented] (MNG-8015) Control the type of path where each dependency can be placed

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807769#comment-17807769 ] ASF GitHub Bot commented on MNG-8015: - gnodet commented on code in PR #1378: URL: https

Re: [PR] [MNG-8015] Control the type of path where each dependency can be placed [maven]

2024-01-17 Thread via GitHub
gnodet commented on code in PR #1378: URL: https://github.com/apache/maven/pull/1378#discussion_r1455844108 ## api/maven-api-core/src/main/java/org/apache/maven/api/DependencyProperties.java: ## @@ -33,27 +36,226 @@ @Immutable public interface DependencyProperties { /** -

Re: [PR] Make ArtifactFilter into a Predicate [maven]

2024-01-17 Thread via GitHub
gnodet commented on PR #1383: URL: https://github.com/apache/maven/pull/1383#issuecomment-1896006747 If they are needed, shouldn't all these classes be reimplemented on top of the v4 api instead ? -- This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Commented] (MRESOLVER-465) Make room for new version scheme implementations

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807741#comment-17807741 ] ASF GitHub Bot commented on MRESOLVER-465: -- cstamas commented on PR #407: URL

Re: [PR] [MRESOLVER-465] Make room for alternate version scheme [maven-resolver]

2024-01-17 Thread via GitHub
cstamas commented on PR #407: URL: https://github.com/apache/maven-resolver/pull/407#issuecomment-1895916360 Removed them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[jira] [Updated] (MRELEASE-1137) git path suffix from submodule

2024-01-17 Thread Jira
[ https://issues.apache.org/jira/browse/MRELEASE-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rüdiger zu Dohna updated MRELEASE-1137: --- Description: We have a mono-repo with a root maven pom and submodules that we want

[jira] [Commented] (MRELEASE-1137) git path suffix from submodule

2024-01-17 Thread Jira
[ https://issues.apache.org/jira/browse/MRELEASE-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807727#comment-17807727 ] Rüdiger zu Dohna commented on MRELEASE-1137: I'm only speculating, but it

[jira] [Created] (MRELEASE-1137) git path suffix from submodule

2024-01-17 Thread Jira
Rüdiger zu Dohna created MRELEASE-1137: -- Summary: git path suffix from submodule Key: MRELEASE-1137 URL: https://issues.apache.org/jira/browse/MRELEASE-1137 Project: Maven Release Plugin

[jira] [Commented] (MRESOLVER-465) Make room for new version scheme implementations

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807724#comment-17807724 ] ASF GitHub Bot commented on MRESOLVER-465: -- gnodet commented on PR #407: URL:

Re: [PR] [MRESOLVER-465] Make room for alternate version scheme [maven-resolver]

2024-01-17 Thread via GitHub
gnodet commented on PR #407: URL: https://github.com/apache/maven-resolver/pull/407#issuecomment-1895829404 > Oh, yes, true, oversight on my part. Fixed Much better now. Do we need to keep the hashCode / equals on version scheme ? They really look weird on a pure service class. --

[jira] [Commented] (MRESOLVER-465) Make room for new version scheme implementations

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807717#comment-17807717 ] ASF GitHub Bot commented on MRESOLVER-465: -- cstamas commented on PR #407: URL

Re: [PR] [MRESOLVER-465] Make room for alternate version scheme [maven-resolver]

2024-01-17 Thread via GitHub
cstamas commented on PR #407: URL: https://github.com/apache/maven-resolver/pull/407#issuecomment-1895736927 Oh, yes, true, oversight on my part. Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Commented] (MRESOLVER-465) Make room for new version scheme implementations

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807714#comment-17807714 ] ASF GitHub Bot commented on MRESOLVER-465: -- gnodet commented on PR #407: URL:

Re: [PR] [MRESOLVER-465] Make room for alternate version scheme [maven-resolver]

2024-01-17 Thread via GitHub
gnodet commented on PR #407: URL: https://github.com/apache/maven-resolver/pull/407#issuecomment-1895725220 > @gnodet agreed with all, but _I did not change any of these_, all I did is split the class (support + generic scheme). The idea is to have new version scheme provided by Resolver in

[jira] [Commented] (MRESOLVER-465) Make room for new version scheme implementations

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807713#comment-17807713 ] ASF GitHub Bot commented on MRESOLVER-465: -- cstamas commented on PR #407: URL

Re: [PR] [MRESOLVER-465] Make room for alternate version scheme [maven-resolver]

2024-01-17 Thread via GitHub
cstamas commented on PR #407: URL: https://github.com/apache/maven-resolver/pull/407#issuecomment-1895722253 @gnodet agreed with all, but _I did not change any of these_, all I did is split the class (support + generic scheme). The idea is to have new version scheme provided by Resolver in

[jira] [Created] (MCOMPILER-571) annotationProcessorPaths from maven-compiler-plugin are not resolved when using dependency:go-offline

2024-01-17 Thread Filip Hrisafov (Jira)
Filip Hrisafov created MCOMPILER-571: Summary: annotationProcessorPaths from maven-compiler-plugin are not resolved when using dependency:go-offline Key: MCOMPILER-571 URL: https://issues.apache.org/jira/brows

[jira] [Commented] (MRESOLVER-465) Make room for new version scheme implementations

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807712#comment-17807712 ] ASF GitHub Bot commented on MRESOLVER-465: -- gnodet commented on code in PR #4

Re: [PR] [MRESOLVER-465] Make room for alternate version scheme [maven-resolver]

2024-01-17 Thread via GitHub
gnodet commented on code in PR #407: URL: https://github.com/apache/maven-resolver/pull/407#discussion_r1455436530 ## maven-resolver-util/src/main/java/org/eclipse/aether/util/version/GenericVersionConstraint.java: ## @@ -28,6 +28,8 @@ /** * A constraint on versions for a d

[jira] [Updated] (DOXIASITETOOLS-327) Support multi-language for menu "name"

2024-01-17 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIASITETOOLS-327: -- Fix Version/s: waiting-for-feedback > Support multi-language for menu "

Re: [PR] Clarify default values for repositories [maven-site]

2024-01-17 Thread via GitHub
kwin merged PR #485: URL: https://github.com/apache/maven-site/pull/485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

Re: [PR] Clarify default values for repositories [maven-site]

2024-01-17 Thread via GitHub
kwin commented on PR #485: URL: https://github.com/apache/maven-site/pull/485#issuecomment-1895531631 It currently says: > **never** (only downloads if not yet existing in the local repository) For the this already covers the never != offline aspect. -- This is an automated m

[jira] [Commented] (MNG-8015) Control the type of path where each dependency can be placed

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807683#comment-17807683 ] ASF GitHub Bot commented on MNG-8015: - desruisseaux commented on code in PR #1378: URL:

Re: [PR] [MNG-8015] Control the type of path where each dependency can be placed [maven]

2024-01-17 Thread via GitHub
desruisseaux commented on code in PR #1378: URL: https://github.com/apache/maven/pull/1378#discussion_r1455189120 ## api/maven-api-core/src/main/java/org/apache/maven/api/DependencyProperties.java: ## @@ -33,27 +36,226 @@ @Immutable public interface DependencyProperties {

[jira] [Commented] (MNG-8015) Control the type of path where each dependency can be placed

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807681#comment-17807681 ] ASF GitHub Bot commented on MNG-8015: - desruisseaux commented on code in PR #1378: URL:

Re: [PR] [MNG-8015] Control the type of path where each dependency can be placed [maven]

2024-01-17 Thread via GitHub
desruisseaux commented on code in PR #1378: URL: https://github.com/apache/maven/pull/1378#discussion_r1455178371 ## api/maven-api-core/src/main/java/org/apache/maven/api/DependencyProperties.java: ## @@ -33,27 +36,226 @@ @Immutable public interface DependencyProperties {

[jira] [Commented] (MNG-8015) Control the type of path where each dependency can be placed

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807676#comment-17807676 ] ASF GitHub Bot commented on MNG-8015: - desruisseaux commented on code in PR #1378: URL:

Re: [PR] [MNG-8015] Control the type of path where each dependency can be placed [maven]

2024-01-17 Thread via GitHub
desruisseaux commented on code in PR #1378: URL: https://github.com/apache/maven/pull/1378#discussion_r1455165979 ## api/maven-api-core/src/main/java/org/apache/maven/api/DependencyProperties.java: ## @@ -33,27 +36,226 @@ @Immutable public interface DependencyProperties {

[jira] [Commented] (MNG-8015) Control the type of path where each dependency can be placed

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807672#comment-17807672 ] ASF GitHub Bot commented on MNG-8015: - desruisseaux commented on code in PR #1378: URL:

Re: [PR] [MNG-8015] Control the type of path where each dependency can be placed [maven]

2024-01-17 Thread via GitHub
desruisseaux commented on code in PR #1378: URL: https://github.com/apache/maven/pull/1378#discussion_r1455141844 ## api/maven-api-core/src/main/java/org/apache/maven/api/PathType.java: ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

[jira] [Commented] (MNG-8015) Control the type of path where each dependency can be placed

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807669#comment-17807669 ] ASF GitHub Bot commented on MNG-8015: - desruisseaux commented on code in PR #1378: URL:

Re: [PR] [MNG-8015] Control the type of path where each dependency can be placed [maven]

2024-01-17 Thread via GitHub
desruisseaux commented on code in PR #1378: URL: https://github.com/apache/maven/pull/1378#discussion_r1455123703 ## api/maven-api-core/src/main/java/org/apache/maven/api/DependencyProperties.java: ## @@ -33,27 +36,226 @@ @Immutable public interface DependencyProperties {

[jira] [Assigned] (MRESOLVER-465) Make room for new version scheme implementations

2024-01-17 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOLVER-465: - Assignee: Tamas Cservenak > Make room for new version scheme implementations

[jira] [Commented] (MRESOLVER-465) Make room for new version scheme implementations

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807662#comment-17807662 ] ASF GitHub Bot commented on MRESOLVER-465: -- cstamas opened a new pull request

[jira] [Updated] (MRESOLVER-465) Make room for new version scheme implementations

2024-01-17 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-465: -- Description: Since eons Resolver had the "generic" scheme implementing the {{Version

[jira] [Updated] (MRESOLVER-465) Make room for new version scheme implementations

2024-01-17 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-465: -- Description: Since eons Resolver had the "generic" scheme implementing the {{Version

[jira] [Created] (MRESOLVER-465) Make room for new version scheme implementations

2024-01-17 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MRESOLVER-465: - Summary: Make room for new version scheme implementations Key: MRESOLVER-465 URL: https://issues.apache.org/jira/browse/MRESOLVER-465 Project: Maven Resolver

[jira] [Commented] (DOXIA-726) MarkdownSink: Incorrect escaping of <

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807657#comment-17807657 ] ASF GitHub Bot commented on DOXIA-726: -- kwin merged PR #196: URL: https://github.com/

[jira] [Resolved] (DOXIA-726) MarkdownSink: Incorrect escaping of <

2024-01-17 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved DOXIA-726. --- Fix Version/s: 2.0.0 2.0.0-M10 Resolution: Fixed Fixed in https://g

Re: [PR] [DOXIA-726] Incorrect escaping of <,>,",' and & [maven-doxia]

2024-01-17 Thread via GitHub
kwin merged PR #196: URL: https://github.com/apache/maven-doxia/pull/196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache

[jira] [Closed] (MRESOLVER-336) Unexpected handling of qualifiers in GenericVersionScheme

2024-01-17 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOLVER-336. - Resolution: Fixed > Unexpected handling of qualifiers in GenericVersionScheme > --

[jira] [Commented] (MRESOLVER-336) Unexpected handling of qualifiers in GenericVersionScheme

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807643#comment-17807643 ] ASF GitHub Bot commented on MRESOLVER-336: -- cstamas merged PR #406: URL: http

Re: [PR] [MRESOLVER-336] Fixes to generic schema [maven-resolver]

2024-01-17 Thread via GitHub
cstamas merged PR #406: URL: https://github.com/apache/maven-resolver/pull/406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

[jira] [Commented] (DOXIASITETOOLS-327) Support multi-language for menu "name"

2024-01-17 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807634#comment-17807634 ] Michael Osipov commented on DOXIASITETOOLS-327: --- See: https://gith

[jira] [Commented] (MSHARED-1351) Confusing message when copying resources from project's baseDir

2024-01-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807630#comment-17807630 ] ASF GitHub Bot commented on MSHARED-1351: - abelsromero commented on code in PR

Re: [PR] [MSHARED-1351] Fix console message when origin is baseDir [maven-filtering]

2024-01-17 Thread via GitHub
abelsromero commented on code in PR #93: URL: https://github.com/apache/maven-filtering/pull/93#discussion_r1454936658 ## src/test/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFilteringTest.java: ## @@ -24,13 +24,10 @@ import java.io.FileInputStream; import java