[
https://issues.apache.org/jira/browse/MSHARED-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784700#comment-17784700
]
ASF GitHub Bot commented on MSHARED-1327:
-
michael-o commented on PR #26:
URL:
michael-o commented on PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1805231560
I still stand with `reports`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/MSHARED-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784651#comment-17784651
]
ASF GitHub Bot commented on MSHARED-1327:
-
kriegaex commented on PR #26:
URL:
kriegaex commented on PR #26:
URL:
https://github.com/apache/maven-reporting-impl/pull/26#issuecomment-1804970463
> Even if a plugin uses a subdir in the shared one, there are still assets
from the skin which need to be present to properly render the report in the
browser.
Then, I t
[
https://issues.apache.org/jira/browse/MDEP-896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784649#comment-17784649
]
Karl Heinz Marbaise commented on MDEP-896:
--
Done in
[8b150c49a6221751c3bc992dbff6
[
https://issues.apache.org/jira/browse/MDEP-896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise closed MDEP-896.
Resolution: Done
> Removing unused code
>
>
> Key: MDEP-
Karl Heinz Marbaise created MDEP-896:
Summary: Removing unused code
Key: MDEP-896
URL: https://issues.apache.org/jira/browse/MDEP-896
Project: Maven Dependency Plugin
Issue Type: Improvem
[
https://issues.apache.org/jira/browse/MSHARED-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784646#comment-17784646
]
Karl Heinz Marbaise commented on MSHARED-1333:
--
Done in
[b2923d2f0dd6241c
[
https://issues.apache.org/jira/browse/MSHARED-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise closed MSHARED-1333.
Resolution: Done
> Upgrade maven-shared-components to version 40
> --
dependabot[bot] closed pull request #99: Bump
org.junit.jupiter:junit-jupiter-api from 5.10.0 to 5.10.1
URL: https://github.com/apache/maven-dependency-analyzer/pull/99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dependabot[bot] commented on PR #99:
URL:
https://github.com/apache/maven-dependency-analyzer/pull/99#issuecomment-1804938814
Looks like org.junit.jupiter:junit-jupiter-api is up-to-date now, so this is
no longer needed.
--
This is an automated message from the Apache Git Service.
To res
[
https://issues.apache.org/jira/browse/MSHARED-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784645#comment-17784645
]
Karl Heinz Marbaise commented on MSHARED-1332:
--
Done in
[0ae9f893d29d7dea
[
https://issues.apache.org/jira/browse/MSHARED-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise closed MSHARED-1332.
Resolution: Done
> Usage of bom instead of single dependencies
>
Karl Heinz Marbaise created MSHARED-1333:
Summary: Upgrade maven-shared-components to version 40
Key: MSHARED-1333
URL: https://issues.apache.org/jira/browse/MSHARED-1333
Project: Maven Shared
Karl Heinz Marbaise created MSHARED-1332:
Summary: Usage of bom instead of single dependencies
Key: MSHARED-1332
URL: https://issues.apache.org/jira/browse/MSHARED-1332
Project: Maven Shared Co
cstamas closed pull request #225: [EXPERIMENT] Jetty transport
URL: https://github.com/apache/maven-resolver/pull/225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
dependabot[bot] closed pull request #287: Bump hazelcast from 5.1.4 to 5.3.0 in
/maven-resolver-named-locks-hazelcast
URL: https://github.com/apache/maven-resolver/pull/287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dependabot[bot] commented on PR #287:
URL: https://github.com/apache/maven-resolver/pull/287#issuecomment-1804891476
Looks like com.hazelcast:hazelcast is up-to-date now, so this is no longer
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
cstamas commented on PR #287:
URL: https://github.com/apache/maven-resolver/pull/287#issuecomment-1804891140
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
cstamas commented on PR #1302:
URL: https://github.com/apache/maven/pull/1302#issuecomment-1804884501
+1 but no change detected...
built master with master vs this PR, pretty much same result (build time)
--
This is an automated message from the Apache Git Service.
To respond to the mes
gnodet opened a new pull request, #1302:
URL: https://github.com/apache/maven/pull/1302
- Try to improve concurrency
- Delegate display to a single thread
- Disable test which is broken with new logic
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784627#comment-17784627
]
ASF GitHub Bot commented on MRESOLVER-302:
--
cstamas merged PR #360:
URL: http
cstamas merged PR #360:
URL: https://github.com/apache/maven-resolver/pull/360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.
[
https://issues.apache.org/jira/browse/MNG-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784626#comment-17784626
]
ASF GitHub Bot commented on MNG-7899:
-
gnodet merged PR #1296:
URL: https://github.com/
gnodet merged PR #1296:
URL: https://github.com/apache/maven/pull/1296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o
[
https://issues.apache.org/jira/browse/MSHARED-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784622#comment-17784622
]
Karl Heinz Marbaise commented on MSHARED-1331:
--
Done in
[07a2d3939ac17dc8
[
https://issues.apache.org/jira/browse/MSHARED-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise closed MSHARED-1331.
Resolution: Done
> Upgrade maven-shared-parent to version 40
> --
[
https://issues.apache.org/jira/browse/MSHARED-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise reassigned MSHARED-1331:
Assignee: Karl Heinz Marbaise
> Upgrade maven-shared-parent to version 4
Karl Heinz Marbaise created MSHARED-1331:
Summary: Upgrade maven-shared-parent to version 40
Key: MSHARED-1331
URL: https://issues.apache.org/jira/browse/MSHARED-1331
Project: Maven Shared Comp
[
https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784612#comment-17784612
]
ASF GitHub Bot commented on MRESOLVER-302:
--
gnodet commented on code in PR #3
gnodet commented on code in PR #360:
URL: https://github.com/apache/maven-resolver/pull/360#discussion_r1388076564
##
maven-resolver-api/src/main/java/org/eclipse/aether/RepositorySystemSession.java:
##
@@ -88,12 +88,18 @@ interface CloseableRepositorySystemSession extends
Repo
hazendaz commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1804183734
Sorry never got around to opening a ticket on this but tried out alpha 8, it
works perfect now. Confirmed with java 11, 17, and 21. No issues. So
whatever was wrong was magically fixed ;)
[
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784545#comment-17784545
]
ASF GitHub Bot commented on MNG-7648:
-
hazendaz commented on PR #940:
URL: https://gith
[
https://issues.apache.org/jira/browse/MSHADE-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784516#comment-17784516
]
ASF GitHub Bot commented on MSHADE-406:
---
nielsbasjes commented on PR #202:
URL:
ht
nielsbasjes commented on PR #202:
URL:
https://github.com/apache/maven-shade-plugin/pull/202#issuecomment-1804054638
Next hurdle: Almost all of the code assumes the name of the class file is
the same as the package+class name.
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/MNG-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784494#comment-17784494
]
ASF GitHub Bot commented on MNG-7899:
-
sebastien-doyon commented on PR #1296:
URL: http
sebastien-doyon commented on PR #1296:
URL: https://github.com/apache/maven/pull/1296#issuecomment-1803979760
@gnodet I just fixed a format problem that made the build fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/MNG-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784481#comment-17784481
]
ASF GitHub Bot commented on MNG-7899:
-
sebastien-doyon commented on PR #1296:
URL: http
sebastien-doyon commented on PR #1296:
URL: https://github.com/apache/maven/pull/1296#issuecomment-1803945482
@gnodet your changes are cleaner. I agree with your contribution, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
[
https://issues.apache.org/jira/browse/MSHADE-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784476#comment-17784476
]
ASF GitHub Bot commented on MSHADE-406:
---
nielsbasjes commented on PR #202:
URL:
ht
nielsbasjes commented on PR #202:
URL:
https://github.com/apache/maven-shade-plugin/pull/202#issuecomment-1803939052
Current status: A basic shade and a shade+minimize seem to work.
Relocated does not yet work.
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784472#comment-17784472
]
ASF GitHub Bot commented on MRESOLVER-302:
--
cstamas opened a new pull request
cstamas opened a new pull request, #360:
URL: https://github.com/apache/maven-resolver/pull/360
Changes:
* rename closeable session to lessen repetition in source
* make builder implement session interface but explain what is the intent
here
---
https://issues.apache.org/
[
https://issues.apache.org/jira/browse/MNG-7653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784467#comment-17784467
]
ASF GitHub Bot commented on MNG-7653:
-
cstamas opened a new pull request, #1301:
URL: h
[
https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784457#comment-17784457
]
ASF GitHub Bot commented on MNG-7662:
-
gnodet merged PR #950:
URL: https://github.com/a
[
https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MNG-7662.
Resolution: Fixed
> Proxy session scoped components so that they can be injected into singletons
> b
gnodet merged PR #950:
URL: https://github.com/apache/maven/pull/950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
[
https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784449#comment-17784449
]
ASF GitHub Bot commented on MNG-7924:
-
rmannibucau commented on PR #1299:
URL: https://
rmannibucau commented on PR #1299:
URL: https://github.com/apache/maven/pull/1299#issuecomment-1803806891
@cstamas one reason I really dislike type vs flags is type is not composable
without coding (our limitation of being descriptive in our descriptor/pom -
which is a good thing by itself
cstamas commented on PR #950:
URL: https://github.com/apache/maven/pull/950#issuecomment-1803792327
Ah, true, yes, proxies are ONLY about interfaces kk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784442#comment-17784442
]
ASF GitHub Bot commented on MNG-7662:
-
cstamas commented on PR #950:
URL: https://githu
[
https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784440#comment-17784440
]
ASF GitHub Bot commented on MNG-7662:
-
gnodet commented on PR #950:
URL: https://github
gnodet commented on PR #950:
URL: https://github.com/apache/maven/pull/950#issuecomment-1803785911
> Why is `@Typed` required? It has a serious side effect in Sisu regarding
how bean is bound...
Oh, yes. That's actually the semantics that we need. The goal is to make
sure the proxi
[
https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-7662:
-
Description:
The {{SessionScope}} will now create proxies to wrap beans when there's a need
to inj
[
https://issues.apache.org/jira/browse/MNG-7775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784438#comment-17784438
]
Elliotte Rusty Harold commented on MNG-7775:
Optimization doesn't help. Perform
[
https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784437#comment-17784437
]
ASF GitHub Bot commented on MNG-7662:
-
cstamas commented on PR #950:
URL: https://githu
cstamas commented on PR #950:
URL: https://github.com/apache/maven/pull/950#issuecomment-1803778150
Why is `@Typed` required? It has a serious side effect in Sisu regarding how
bean is bound...
--
This is an automated message from the Apache Git Service.
To respond to the message, please
gnodet opened a new pull request, #1300:
URL: https://github.com/apache/maven/pull/1300
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the
[
https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet reassigned MNG-7662:
Assignee: Guillaume Nodet
> Proxy session scoped components so that they can be injected int
[
https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-7662:
-
Fix Version/s: 4.0.0-alpha-9
> Proxy session scoped components so that they can be injected into si
[
https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784435#comment-17784435
]
ASF GitHub Bot commented on MNG-7924:
-
cstamas commented on PR #1299:
URL: https://gith
[
https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-7662:
-
Description:
The {{SessionScope}} will now create proxies to wrap beans when there's a need
to inj
cstamas commented on PR #1299:
URL: https://github.com/apache/maven/pull/1299#issuecomment-1803773056
And a counter example: consider maven-resolver artifacts (!):
* uses plain packaging "jar", but
* the produced JARs have Sisu index (Sisu DI, JSR330)
* the produced JARs have OSGi he
[
https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-7662:
-
Description:
The {{SessionScope}} will now create proxies to wrap beans when there's a need
to inj
[
https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-7662:
-
Description:
The {{SessionScope}} will now create proxies to wrap beans when there's a need
to inj
[
https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-7662:
-
Summary: Proxy session scoped components so that they can be injected into
singletons beans (was:
[
https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784421#comment-17784421
]
ASF GitHub Bot commented on MNG-7924:
-
cstamas commented on PR #1299:
URL: https://gith
cstamas commented on PR #1299:
URL: https://github.com/apache/maven/pull/1299#issuecomment-1803725216
Just a thought experiment (that takari somewhat tried to deliver): Look at
the `takari-maven-component` packaging. It's goal is: producing jar artifact
meant to be used within Maven.
[
https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784415#comment-17784415
]
ASF GitHub Bot commented on MNG-7924:
-
cstamas commented on PR #1299:
URL: https://gith
cstamas commented on PR #1299:
URL: https://github.com/apache/maven/pull/1299#issuecomment-1803707342
Along those lines, yes:
Packaging provides flexibility for producers, to build new (or "old", like
packaging "jar" vs "takari-jar") things.
Type provides flexibility for consum
[
https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784412#comment-17784412
]
ASF GitHub Bot commented on MNG-7924:
-
rmannibucau commented on PR #1299:
URL: https://
rmannibucau commented on PR #1299:
URL: https://github.com/apache/maven/pull/1299#issuecomment-1803703826
@cstamas I guess current state is clear but since it is not fully embraced
by the community and your PR enables to align both worlds I really think we
shouldnt miss this opportunity.
[
https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784405#comment-17784405
]
ASF GitHub Bot commented on MNG-7924:
-
cstamas commented on PR #1299:
URL: https://gith
cstamas commented on PR #1299:
URL: https://github.com/apache/maven/pull/1299#issuecomment-1803688709
Another important thing people forget is that `type != packaging`, and due
this bias/assumption they come up with wrong conclusions...
Type is NOT packaging, but they CAN be equal. Th
[
https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784402#comment-17784402
]
ASF GitHub Bot commented on MNG-7924:
-
rmannibucau commented on PR #1299:
URL: https://
rmannibucau commented on PR #1299:
URL: https://github.com/apache/maven/pull/1299#issuecomment-1803682292
I fully understand that and this is exactly why I'd like we stop doing that.
> We could add "flags" to dependencies, but that would make Maven very very
"low level", and would tri
[
https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784389#comment-17784389
]
ASF GitHub Bot commented on MNG-7924:
-
cstamas commented on PR #1299:
URL: https://gith
cstamas commented on PR #1299:
URL: https://github.com/apache/maven/pull/1299#issuecomment-1803653059
Type is part of Maven DNA, and let me try to explain why:
When you are on "resolver level" (so no Maven in vicinity, like MIMA or
Resolver "demos" runs), you are dealing with "artifac
[
https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784384#comment-17784384
]
ASF GitHub Bot commented on MNG-7924:
-
rmannibucau commented on PR #1299:
URL: https://
rmannibucau commented on PR #1299:
URL: https://github.com/apache/maven/pull/1299#issuecomment-1803635618
> um, is like that even today
Exactly, and I hope the refactoring enables to stop doing that, it is very
misleading for end users and technically no more needed with your PR.
--
[
https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784381#comment-17784381
]
ASF GitHub Bot commented on MNG-7924:
-
cstamas commented on PR #1299:
URL: https://gith
cstamas commented on PR #1299:
URL: https://github.com/apache/maven/pull/1299#issuecomment-1803632036
> Is it planned to make the properties injected from the pom "mvn 4 version"
and therefore makes the type dictionnary useless? If so +1 (means the toggles
will be exposed to users and type
[
https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784380#comment-17784380
]
ASF GitHub Bot commented on MNG-7662:
-
rmannibucau commented on code in PR #950:
URL: h
rmannibucau commented on code in PR #950:
URL: https://github.com/apache/maven/pull/950#discussion_r1387851206
##
maven-core/pom.xml:
##
@@ -144,6 +144,12 @@ under the License.
org.slf4j
slf4j-api
+
Review Comment:
yes the JVM embed a relocated asm ve
[
https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784379#comment-17784379
]
ASF GitHub Bot commented on MNG-7924:
-
cstamas commented on code in PR #1299:
URL: http
cstamas commented on code in PR #1299:
URL: https://github.com/apache/maven/pull/1299#discussion_r1387849231
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java:
##
@@ -59,8 +62,37 @@ private MavenRepositorySystemUtils()
[
https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784378#comment-17784378
]
ASF GitHub Bot commented on MNG-7924:
-
cstamas commented on code in PR #1299:
URL: http
cstamas commented on code in PR #1299:
URL: https://github.com/apache/maven/pull/1299#discussion_r1387786371
##
maven-core/src/main/java/org/apache/maven/artifact/handler/manager/LegacyArtifactHandlerManager.java:
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Found
[
https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784377#comment-17784377
]
ASF GitHub Bot commented on MNG-7924:
-
cstamas commented on code in PR #1299:
URL: http
[
https://issues.apache.org/jira/browse/MNG-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784376#comment-17784376
]
ASF GitHub Bot commented on MNG-7662:
-
gnodet commented on code in PR #950:
URL: https:
cstamas commented on code in PR #1299:
URL: https://github.com/apache/maven/pull/1299#discussion_r1387841807
##
api/maven-api-core/src/main/java/org/apache/maven/api/Type.java:
##
@@ -51,14 +51,21 @@ public interface Type {
* Returns the dependency type id.
* The id
gnodet commented on code in PR #950:
URL: https://github.com/apache/maven/pull/950#discussion_r1387840616
##
maven-core/pom.xml:
##
@@ -144,6 +144,12 @@ under the License.
org.slf4j
slf4j-api
+
Review Comment:
> Yes exactly, I think it is a case which
[
https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784367#comment-17784367
]
ASF GitHub Bot commented on MNG-7924:
-
cstamas commented on code in PR #1299:
URL: http
cstamas commented on code in PR #1299:
URL: https://github.com/apache/maven/pull/1299#discussion_r1387827010
##
api/maven-api-core/src/main/java/org/apache/maven/api/Type.java:
##
@@ -51,14 +51,21 @@ public interface Type {
* Returns the dependency type id.
* The id
[
https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784364#comment-17784364
]
ASF GitHub Bot commented on MNG-7924:
-
cstamas commented on code in PR #1299:
URL: http
cstamas commented on code in PR #1299:
URL: https://github.com/apache/maven/pull/1299#discussion_r1387816705
##
api/maven-api-core/src/main/java/org/apache/maven/api/Type.java:
##
@@ -51,14 +51,21 @@ public interface Type {
* Returns the dependency type id.
* The id
[
https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784362#comment-17784362
]
ASF GitHub Bot commented on MNG-7924:
-
cstamas commented on code in PR #1299:
URL: http
cstamas commented on code in PR #1299:
URL: https://github.com/apache/maven/pull/1299#discussion_r1387813713
##
api/maven-api-core/src/main/java/org/apache/maven/api/Type.java:
##
@@ -51,14 +51,21 @@ public interface Type {
* Returns the dependency type id.
* The id
[
https://issues.apache.org/jira/browse/MNG-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784359#comment-17784359
]
ASF GitHub Bot commented on MNG-7924:
-
cstamas commented on code in PR #1299:
URL: http
cstamas commented on code in PR #1299:
URL: https://github.com/apache/maven/pull/1299#discussion_r1387809160
##
api/maven-api-core/src/main/java/org/apache/maven/api/Type.java:
##
@@ -51,14 +51,21 @@ public interface Type {
* Returns the dependency type id.
* The id
1 - 100 of 124 matches
Mail list logo
