[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759321#comment-17759321 ] ASF GitHub Bot commented on MNG-7820: - gnodet commented on code in PR #1208: URL: https

[GitHub] [maven] gnodet commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-26 Thread via GitHub
gnodet commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1306609506 ## maven-compat/src/main/java/org/apache/maven/profiles/activation/OperatingSystemProfileActivator.java: ## @@ -122,12 +153,54 @@ private boolean determineFamilyMatch(Stri

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759304#comment-17759304 ] ASF GitHub Bot commented on MNG-7820: - CrazyHZM commented on PR #1208: URL: https://git

[GitHub] [maven-build-cache-extension] michael-o commented on pull request #88: remove unused logback dependency

2023-08-26 Thread via GitHub
michael-o commented on PR #88: URL: https://github.com/apache/maven-build-cache-extension/pull/88#issuecomment-1694500254 > > Slf4j simple is enough here... > > Agree but we need one. I had to debug some issues here in the past with docker on GHA and it was really helpful That

[GitHub] [maven-build-cache-extension] olamy commented on pull request #88: remove unused logback dependency

2023-08-26 Thread via GitHub
olamy commented on PR #88: URL: https://github.com/apache/maven-build-cache-extension/pull/88#issuecomment-1694498297 > Slf4j simple is enough here... Agree but we need one. I had to debug some issues here in the past with docker on GHA and it was really helpful -- This is an aut

[GitHub] [maven-build-cache-extension] olamy commented on pull request #88: remove unused logback dependency

2023-08-26 Thread via GitHub
olamy commented on PR #88: URL: https://github.com/apache/maven-build-cache-extension/pull/88#issuecomment-1694496822 -1 Please revert your commit. It's used only in test and very helpful when you need to debug failing tests locally or even in CI -- This is an automated message

[jira] [Commented] (DOXIASITETOOLS-311) Rework and simplify the site model

2023-08-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759256#comment-17759256 ] ASF GitHub Bot commented on DOXIASITETOOLS-311: --- michael-o commente

[GitHub] [maven-doxia-sitetools] michael-o commented on pull request #110: [DOXIASITETOOLS-311] Rework and simplify the site model

2023-08-26 Thread via GitHub
michael-o commented on PR #110: URL: https://github.com/apache/maven-doxia-sitetools/pull/110#issuecomment-1694355983 > very good, just need to associate the commit to a Jira issue (critical for future references) Done -- This is an automated message from the Apache Git Service. T

[GitHub] [maven-build-cache-extension] cstamas commented on pull request #99: remove debugging code

2023-08-26 Thread via GitHub
cstamas commented on PR #99: URL: https://github.com/apache/maven-build-cache-extension/pull/99#issuecomment-1694342746 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [maven-build-cache-extension] elharo commented on a diff in pull request #98: Avoid hash calculation when is true

2023-08-26 Thread via GitHub
elharo commented on code in PR #98: URL: https://github.com/apache/maven-build-cache-extension/pull/98#discussion_r1306438915 ## src/main/java/org/apache/maven/buildcache/DefaultProjectInputCalculator.java: ## @@ -72,7 +72,7 @@ public DefaultProjectInputCalculator( @Over

[GitHub] [maven-build-cache-extension] elharo merged pull request #99: remove debugging code

2023-08-26 Thread via GitHub
elharo merged PR #99: URL: https://github.com/apache/maven-build-cache-extension/pull/99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [maven-build-cache-extension] elharo merged pull request #88: remove unused logback dependency

2023-08-26 Thread via GitHub
elharo merged PR #88: URL: https://github.com/apache/maven-build-cache-extension/pull/88 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [maven-build-cache-extension] elharo opened a new pull request, #99: remove debugging code

2023-08-26 Thread via GitHub
elharo opened a new pull request, #99: URL: https://github.com/apache/maven-build-cache-extension/pull/99 Clear log junk from passing tests so it's easier to find real problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [maven-build-cache-extension] elharo commented on pull request #88: remove unused logback dependency

2023-08-26 Thread via GitHub
elharo commented on PR #88: URL: https://github.com/apache/maven-build-cache-extension/pull/88#issuecomment-1694334442 The warning is an annoying bug in slf4j. We don't need a logging backend in tests. For that matter, we don't need logging in tests. Logging in tests is a *bug*. Only faili

[GitHub] [maven-build-cache-extension] elharo commented on pull request #88: remove unused logback dependency

2023-08-26 Thread via GitHub
elharo commented on PR #88: URL: https://github.com/apache/maven-build-cache-extension/pull/88#issuecomment-1694333603 1. It cures an unused dependency warning. 2. More importantly it removes yet another idiosyncratic dependency not used anywhere else in maven tossed into the classpath,

[jira] [Commented] (MNG-7855) Dependencies wrongly put on class-path rather than module-path

2023-08-26 Thread Martin Desruisseaux (Jira)
[ https://issues.apache.org/jira/browse/MNG-7855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759233#comment-17759233 ] Martin Desruisseaux commented on MNG-7855: -- Another area where being on the class-

[GitHub] [maven-deploy-plugin] Scrappers-glitch opened a new pull request, #43: DeployFileMojo#readModel(File): fixed MojoExecutionException javadoc

2023-08-26 Thread via GitHub
Scrappers-glitch opened a new pull request, #43: URL: https://github.com/apache/maven-deploy-plugin/pull/43 This PR fixes the MojoExecutionException Javadoc at `DeployFileMojo#readModel(File)`. -- This is an automated message from the Apache Git Service. To respond to the message, ple