[GitHub] [maven-mvnd] gnodet closed issue #849: The detection of mvnd home is broken on alpine linux

2023-05-17 Thread via GitHub
gnodet closed issue #849: The detection of mvnd home is broken on alpine linux URL: https://github.com/apache/maven-mvnd/issues/849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [maven-mvnd] gnodet merged pull request #848: Fix broken detection of mvnd home on alpine linux (fixes #849)

2023-05-17 Thread via GitHub
gnodet merged PR #848: URL: https://github.com/apache/maven-mvnd/pull/848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apach

[GitHub] [maven] CrazyHZM commented on pull request #1096: [MNG-7639] Add unit test for DefaultRepositorySystemSessionFactory#newRepositorySession

2023-05-17 Thread via GitHub
CrazyHZM commented on PR #1096: URL: https://github.com/apache/maven/pull/1096#issuecomment-1552397971 > @CrazyHZM - please select checkboxes (at least one) about license acknowledge Done. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Commented] (MSOURCES-113) Store source encoding info in a standard file

2023-05-17 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MSOURCES-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17723746#comment-17723746 ] Elliotte Rusty Harold commented on MSOURCES-113: There's an assumption

[jira] [Updated] (MDEP-854) Bump jsoup from 1.15.3 to 1.16.1

2023-05-17 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MDEP-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MDEP-854: - Summary: Bump jsoup from 1.15.3 to 1.16.1 (was: Bump jsoup from 1.15.3 to 1.15.4) > Bump

[GitHub] [maven] Giovds commented on a diff in pull request #1105: [MNG-7740] Remove old temporary consumer*pom files from buildDir

2023-05-17 Thread via GitHub
Giovds commented on code in PR #1105: URL: https://github.com/apache/maven/pull/1105#discussion_r1197071123 ## maven-core/src/main/java/org/apache/maven/internal/transformation/ConsumerPomArtifactTransformer.java: ## @@ -77,13 +80,34 @@ public void injectTransformedArtifacts(Mav

[jira] [Closed] (MSOURCES-135) Cleanup project code

2023-05-17 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSOURCES-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSOURCES-135. Resolution: Fixed > Cleanup project code > > >

[GitHub] [maven-source-plugin] slawekjaranowski merged pull request #9: [MSOURCES-135] Cleanup project code

2023-05-17 Thread via GitHub
slawekjaranowski merged PR #9: URL: https://github.com/apache/maven-source-plugin/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [maven-dependency-plugin] michael-o opened a new pull request, #319: [MDEP-864] Replace AnalyzeReportView with a new AnalyzeReportRenderer

2023-05-17 Thread via GitHub
michael-o opened a new pull request, #319: URL: https://github.com/apache/maven-dependency-plugin/pull/319 This closes #319 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.o

[jira] [Updated] (MDEP-862) warns about depending on plexus-container-default

2023-05-17 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MDEP-862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MDEP-862: - Fix Version/s: 3.6.0 > warns about depending on plexus-container-default >

[jira] [Assigned] (MDEP-862) warns about depending on plexus-container-default

2023-05-17 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MDEP-862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MDEP-862: Assignee: Slawomir Jaranowski > warns about depending on plexus-container-default >

[jira] [Closed] (MDEP-865) Get rid of plexus-container-default from dependencies

2023-05-17 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MDEP-865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MDEP-865. Fix Version/s: (was: 3.6.0) Resolution: Duplicate > Get rid of plexus-container-de

[jira] [Created] (MDEP-865) Get rid of plexus-container-default from dependencies

2023-05-17 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MDEP-865: Summary: Get rid of plexus-container-default from dependencies Key: MDEP-865 URL: https://issues.apache.org/jira/browse/MDEP-865 Project: Maven Dependency Plug

[jira] [Created] (MDEP-864) Replace AnalyzeReportView with a new AnalyzeReportRenderer

2023-05-17 Thread Michael Osipov (Jira)
Michael Osipov created MDEP-864: --- Summary: Replace AnalyzeReportView with a new AnalyzeReportRenderer Key: MDEP-864 URL: https://issues.apache.org/jira/browse/MDEP-864 Project: Maven Dependency Plugin

[jira] [Commented] (MPOM-289) Use properties to define the versions of plugins

2023-05-17 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPOM-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17723725#comment-17723725 ] Michael Osipov commented on MPOM-289: - Not just in Velocity: * {{maven.}} is our namesp

[GitHub] [maven] elharo commented on a diff in pull request #1099: [MNG-7714] Fixed a scenario in version sorting where sp1 is less than final

2023-05-17 Thread via GitHub
elharo commented on code in PR #1099: URL: https://github.com/apache/maven/pull/1099#discussion_r1196823648 ## maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java: ## @@ -199,6 +202,7 @@ public int compareTo(Item item) {

[GitHub] [maven-deploy-plugin] elharo commented on pull request #28: [MDEPLOY-118] - Enable deployment of attached release artifacts if POM is identical

2023-05-17 Thread via GitHub
elharo commented on PR #28: URL: https://github.com/apache/maven-deploy-plugin/pull/28#issuecomment-1551767074 Probably worth discussing on the dev list to see what everyone thinks. Maven has gotten a lot of mileage out of the principle that an "artifact" is uniquely identified by coordina

[GitHub] [maven] slawekjaranowski commented on pull request #1096: [MNG-7639] Add unit test for DefaultRepositorySystemSessionFactory#newRepositorySession

2023-05-17 Thread via GitHub
slawekjaranowski commented on PR #1096: URL: https://github.com/apache/maven/pull/1096#issuecomment-1551694775 @CrazyHZM - please select checkboxes (at least one) about license acknowledge -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Closed] (MENFORCER-483) excludedScopes should use the default value

2023-05-17 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MENFORCER-483. - Resolution: Duplicate > excludedScopes should use the default value >

[GitHub] [maven] CrazyHZM commented on a diff in pull request #1099: [MNG-7714] Fixed a scenario in version sorting where sp1 is less than final

2023-05-17 Thread via GitHub
CrazyHZM commented on code in PR #1099: URL: https://github.com/apache/maven/pull/1099#discussion_r1196680362 ## maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java: ## @@ -199,6 +202,7 @@ public int compareTo(Item item) {

[GitHub] [maven] CrazyHZM commented on a diff in pull request #1096: [MNG-7639] Add unit test for DefaultRepositorySystemSessionFactory#newRepositorySession

2023-05-17 Thread via GitHub
CrazyHZM commented on code in PR #1096: URL: https://github.com/apache/maven/pull/1096#discussion_r1196675733 ## maven-core/src/test/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactoryTest.java: ## @@ -0,0 +1,401 @@ +/* + * Licensed to the Apache Software

[GitHub] [maven-deploy-plugin] mdrie commented on pull request #28: [MDEPLOY-118] - Enable deployment of attached release artifacts if POM is identical

2023-05-17 Thread via GitHub
mdrie commented on PR #28: URL: https://github.com/apache/maven-deploy-plugin/pull/28#issuecomment-1551537648 Could you explain, why you might want to insist? In the company I was doing this for, it is regular practice to publish artifacts for the same version for additional platform

[GitHub] [maven-shade-plugin] elharo merged pull request #186: refactor: refactor bad smell UnnecessaryToStringCall

2023-05-17 Thread via GitHub
elharo merged PR #186: URL: https://github.com/apache/maven-shade-plugin/pull/186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mav

[GitHub] [maven-deploy-plugin] elharo commented on pull request #28: [MDEPLOY-118] - Enable deployment of attached release artifacts if POM is identical

2023-05-17 Thread via GitHub
elharo commented on PR #28: URL: https://github.com/apache/maven-deploy-plugin/pull/28#issuecomment-1551287410 Ideally things wouldn't be built on several platforms but if they were, the binaries could be copied from one machine to another before deployment. As soon as a build process invo

[jira] [Commented] (MENFORCER-483) excludedScopes should use the default value

2023-05-17 Thread Giovanni van der Schelde (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17723416#comment-17723416 ] Giovanni van der Schelde commented on MENFORCER-483: I did look th

[GitHub] [maven-deploy-plugin] mdrie commented on pull request #28: [MDEPLOY-118] - Enable deployment of attached release artifacts if POM is identical

2023-05-17 Thread via GitHub
mdrie commented on PR #28: URL: https://github.com/apache/maven-deploy-plugin/pull/28#issuecomment-1551186296 Thanks, @elharo, for the quick response! I ran into the problem described in #MDEPLOY-118. I think, I implemented this in a way, that current behavior of the plugin is

[GitHub] [maven-mvnd] gnodet merged pull request #846: Fix version display (fixes #838)

2023-05-17 Thread via GitHub
gnodet merged PR #846: URL: https://github.com/apache/maven-mvnd/pull/846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apach

[GitHub] [maven-mvnd] gnodet closed issue #838: Consistent version output

2023-05-17 Thread via GitHub
gnodet closed issue #838: Consistent version output URL: https://github.com/apache/maven-mvnd/issues/838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-deploy-plugin] elharo commented on pull request #28: [MDEPLOY-118] - Enable deployment of attached release artifacts if POM is identical

2023-05-17 Thread via GitHub
elharo commented on PR #28: URL: https://github.com/apache/maven-deploy-plugin/pull/28#issuecomment-1551159887 It can be considered. I'm personally not sure this is a good idea. This seems like it might break some Maven repos stare decisis properties. It's generally not possible to change

[jira] [Reopened] (MDEPLOY-118) Enable deployment of attached release artifacts if POM is identical

2023-05-17 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MDEPLOY-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reopened MDEPLOY-118: --- Active PR for this issue has been submitted > Enable deployment of attached rel

[jira] [Commented] (MENFORCER-483) excludedScopes should use the default value

2023-05-17 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17723402#comment-17723402 ] Slawomir Jaranowski commented on MENFORCER-483: --- Please look MENFORCER-4

[jira] [Created] (MENFORCER-483) excludedScopes should use the default value

2023-05-17 Thread Giovanni van der Schelde (Jira)
Giovanni van der Schelde created MENFORCER-483: -- Summary: excludedScopes should use the default value Key: MENFORCER-483 URL: https://issues.apache.org/jira/browse/MENFORCER-483 Project: M

[GitHub] [maven-mvnd] gnodet closed issue #596: mvnd doesn't work in alpine

2023-05-17 Thread via GitHub
gnodet closed issue #596: mvnd doesn't work in alpine URL: https://github.com/apache/maven-mvnd/issues/596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [maven-mvnd] gnodet commented on issue #596: mvnd doesn't work in alpine

2023-05-17 Thread via GitHub
gnodet commented on issue #596: URL: https://github.com/apache/maven-mvnd/issues/596#issuecomment-1550886935 This may just be missing glibc on alpine. You need to install the `gcompact` package. ``` ➜ tmp docker run --rm -it --user root jenkins/inbound-agent:latest-alpine-jdk11