[GitHub] [maven-surefire] andpab opened a new pull request, #591: [SUREFIRE-2139] Raise asm to 9.4 for proper Java 19/20 bytecode support

2022-12-30 Thread GitBox
andpab opened a new pull request, #591: URL: https://github.com/apache/maven-surefire/pull/591 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed

[GitHub] [maven-site] michael-o merged pull request #359: Fix formatting to have XML rendered correctly

2022-12-30 Thread GitBox
michael-o merged PR #359: URL: https://github.com/apache/maven-site/pull/359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

[GitHub] [maven-site] michael-o merged pull request #357: Fix formatting to have XML rendered correctly

2022-12-30 Thread GitBox
michael-o merged PR #357: URL: https://github.com/apache/maven-site/pull/357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

[GitHub] [maven-site] asfgit merged pull request #356: Add release notes for Maven 3.8.7

2022-12-30 Thread GitBox
asfgit merged PR #356: URL: https://github.com/apache/maven-site/pull/356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apach

[jira] [Updated] (SUREFIRE-2139) Fully support Java 19 byte code

2022-12-30 Thread Andreas Pabst (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Pabst updated SUREFIRE-2139: Description: The examples from Surefire's [JPMS documentation|https://maven.apache.org/

[GitHub] [maven-surefire] andpab commented on pull request #565: add jdk 19

2022-12-30 Thread GitBox
andpab commented on PR #565: URL: https://github.com/apache/maven-surefire/pull/565#issuecomment-1368091463 I rebased this branch to master locally and ran the ITs. Most of them are successful except for 6 JPMS-related ITs: - MultiModuleProjectWithJPMSIT - Surefire1570ModularFailsa

[jira] [Created] (SUREFIRE-2139) Fully support Java 19 byte code

2022-12-30 Thread Andreas Pabst (Jira)
Andreas Pabst created SUREFIRE-2139: --- Summary: Fully support Java 19 byte code Key: SUREFIRE-2139 URL: https://issues.apache.org/jira/browse/SUREFIRE-2139 Project: Maven Surefire Issue Type

[GitHub] [maven-surefire] andpab commented on a diff in pull request #554: [SUREFIRE-2109] Add suffix derived from current user to Surefire temp directory name and make directory writable for all

2022-12-30 Thread GitBox
andpab commented on code in PR #554: URL: https://github.com/apache/maven-surefire/pull/554#discussion_r1059513138 ## surefire-api/src/main/java/org/apache/maven/surefire/api/util/TempFileManager.java: ## @@ -180,6 +180,8 @@ public synchronized File createTempFile( String prefix

[jira] [Updated] (MNG-7222) Validate and warn for naming collisions between Maven and System properties

2022-12-30 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7222: Fix Version/s: waiting-for-feedback > Validate and warn for naming collisions between Maven and Syste

[jira] [Commented] (MNG-7222) Validate and warn for naming collisions between Maven and System properties

2022-12-30 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653179#comment-17653179 ] Michael Osipov commented on MNG-7222: - I have been working in some properties related i

[jira] [Commented] (MNG-7656) Dependencies copied to target have stricter permissions

2022-12-30 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653177#comment-17653177 ] Michael Osipov commented on MNG-7656: - Alright, will stay put and wait for the logs. Gu

[jira] [Updated] (MNG-7656) Dependencies copied to target have stricter permissions

2022-12-30 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7656: Fix Version/s: waiting-for-feedback > Dependencies copied to target have stricter permissions > -

[GitHub] [maven-enforcer] ajarmoniuk commented on a diff in pull request #214: MENFORCER-435: Fixing unit tests

2022-12-30 Thread GitBox
ajarmoniuk commented on code in PR #214: URL: https://github.com/apache/maven-enforcer/pull/214#discussion_r1059493012 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/BannedDependenciesBase.java: ## @@ -20,12 +20,12 @@ import java.util.List; -import org.ap

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #214: MENFORCER-435: Fixing unit tests

2022-12-30 Thread GitBox
slawekjaranowski commented on code in PR #214: URL: https://github.com/apache/maven-enforcer/pull/214#discussion_r1059488879 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/BannedDependenciesBase.java: ## @@ -20,12 +20,12 @@ import java.util.List; -import

[jira] [Commented] (DOXIA-617) doxia-module-markdown: Add support for --- header section marks

2022-12-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653162#comment-17653162 ] ASF GitHub Bot commented on DOXIA-617: -- michael-o commented on PR #132: URL: https://

[GitHub] [maven-doxia] michael-o commented on pull request #132: [DOXIA-617] support yaml metadata

2022-12-30 Thread GitBox
michael-o commented on PR #132: URL: https://github.com/apache/maven-doxia/pull/132#issuecomment-1368019605 > @hboutemy This is a very good point. It's better to keep backward compatibility as long as it doesn't make our code too complex. > > In this case, we could use a simple replac

[jira] [Commented] (MENFORCER-445) Include Java Home in Message for Java Rule Failures

2022-12-30 Thread Jira
[ https://issues.apache.org/jira/browse/MENFORCER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653155#comment-17653155 ] Petr Široký commented on MENFORCER-445: --- The error messages now look like this (

[GitHub] [maven-shade-plugin] pzygielo commented on pull request #171: Update overlapping resources warning

2022-12-30 Thread GitBox
pzygielo commented on PR #171: URL: https://github.com/apache/maven-shade-plugin/pull/171#issuecomment-1367972060 Thanks for checking. Probably just "file" would be even better indeed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Closed] (MENFORCER-445) Include Java Home in Message for Java Rule Failures

2022-12-30 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MENFORCER-445. - Fix Version/s: 3.2.0 Assignee: Slawomir Jaranowski Resolution:

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

2022-12-30 Thread GitBox
slawekjaranowski merged PR #213: URL: https://github.com/apache/maven-enforcer/pull/213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Closed] (DOXIATOOLS-68) Update HttpComponents HttpClient 5.1

2022-12-30 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/DOXIATOOLS-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed DOXIATOOLS-68. -- Resolution: Fixed > Update HttpComponents HttpClient 5.1 > -

[jira] [Updated] (DOXIATOOLS-68) Update HttpComponents HttpClient 5.1

2022-12-30 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/DOXIATOOLS-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated DOXIATOOLS-68: --- Summary: Update HttpComponents HttpClient 5.1 (was: Update HttpComponents

[GitHub] [maven-enforcer] ajarmoniuk commented on pull request #214: MENFORCER-435: Fixing unit tests

2022-12-30 Thread GitBox
ajarmoniuk commented on PR #214: URL: https://github.com/apache/maven-enforcer/pull/214#issuecomment-1367942567 @slawekjaranowski fixes the unit test problems you spotted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [maven-enforcer] ajarmoniuk opened a new pull request, #214: MENFORCER-435: Fixing unit tests

2022-12-30 Thread GitBox
ajarmoniuk opened a new pull request, #214: URL: https://github.com/apache/maven-enforcer/pull/214 Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed

[GitHub] [maven-shade-plugin] pzygielo opened a new pull request, #171: Update overlapping resources warning

2022-12-30 Thread GitBox
pzygielo opened a new pull request, #171: URL: https://github.com/apache/maven-shade-plugin/pull/171 - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) -- This is an automated messag

[GitHub] [maven-surefire] sman-81 commented on a diff in pull request #554: [SUREFIRE-2109] Add suffix derived from current user to Surefire temp directory name and make directory writable for all

2022-12-30 Thread GitBox
sman-81 commented on code in PR #554: URL: https://github.com/apache/maven-surefire/pull/554#discussion_r1059393355 ## surefire-api/src/main/java/org/apache/maven/surefire/api/util/TempFileManager.java: ## @@ -180,6 +180,8 @@ public synchronized File createTempFile( String prefi

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

2022-12-30 Thread GitBox
slawekjaranowski commented on code in PR #213: URL: https://github.com/apache/maven-enforcer/pull/213#discussion_r1059381501 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireJavaVersion.java: ## @@ -76,6 +76,7 @@ public void execute(EnforcerRuleHelper hel

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

2022-12-30 Thread GitBox
psiroky commented on code in PR #213: URL: https://github.com/apache/maven-enforcer/pull/213#discussion_r1059372306 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireJavaVersion.java: ## @@ -76,6 +76,7 @@ public void execute(EnforcerRuleHelper helper) thro

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

2022-12-30 Thread GitBox
psiroky commented on code in PR #213: URL: https://github.com/apache/maven-enforcer/pull/213#discussion_r1059372306 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireJavaVersion.java: ## @@ -76,6 +76,7 @@ public void execute(EnforcerRuleHelper helper) thro

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

2022-12-30 Thread GitBox
psiroky commented on code in PR #213: URL: https://github.com/apache/maven-enforcer/pull/213#discussion_r1059372306 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireJavaVersion.java: ## @@ -76,6 +76,7 @@ public void execute(EnforcerRuleHelper helper) thro

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

2022-12-30 Thread GitBox
psiroky commented on code in PR #213: URL: https://github.com/apache/maven-enforcer/pull/213#discussion_r1059372306 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireJavaVersion.java: ## @@ -76,6 +76,7 @@ public void execute(EnforcerRuleHelper helper) thro

[jira] [Commented] (DOXIA-617) doxia-module-markdown: Add support for --- header section marks

2022-12-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653124#comment-17653124 ] ASF GitHub Bot commented on DOXIA-617: -- bertysentry commented on PR #132: URL: https:

[GitHub] [maven-doxia] bertysentry commented on pull request #132: [DOXIA-617] support yaml metadata

2022-12-30 Thread GitBox
bertysentry commented on PR #132: URL: https://github.com/apache/maven-doxia/pull/132#issuecomment-1367895354 @hboutemy This is a very good point. It's better to keep backward compatibility as long as it doesn't make our code too complex. In this case, we could use a simple replace re

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #213: [MENFORCER-445] Include JAVA_HOME location in the Java rule failure messages

2022-12-30 Thread GitBox
slawekjaranowski commented on code in PR #213: URL: https://github.com/apache/maven-enforcer/pull/213#discussion_r1059370417 ## enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequireJavaVersion.java: ## @@ -76,6 +76,7 @@ public void execute(EnforcerRuleHelper hel

[jira] [Commented] (MNG-7656) Dependencies copied to target have stricter permissions

2022-12-30 Thread Moshe Elisha (Jira)
[ https://issues.apache.org/jira/browse/MNG-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653117#comment-17653117 ] Moshe Elisha commented on MNG-7656: --- Shalom. Thank you for the quick reply.  We have a r

[jira] [Commented] (MNG-7656) Dependencies copied to target have stricter permissions

2022-12-30 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653100#comment-17653100 ] Michael Osipov commented on MNG-7656: - Shalom Moshe, copied from where? Please show ls

[jira] [Commented] (MNG-7655) rename Maven core's plexus-utils to more explicit artifactId

2022-12-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653082#comment-17653082 ] ASF GitHub Bot commented on MNG-7655: - hboutemy commented on PR #942: URL: https://gith

[GitHub] [maven] hboutemy commented on pull request #942: [MNG-7655] maven-plexus-utils and maven-plexus-utils-xml (xml-impl)

2022-12-30 Thread GitBox
hboutemy commented on PR #942: URL: https://github.com/apache/maven/pull/942#issuecomment-1367816557 ok, launching some feedback on the Maven dev ML for plexus-xml: this looks simple and wold make things much cleaner = Plexus plexus-utils 4 is used as is (and eventually migrated away), and

[GitHub] [maven-doxia-converter] kwin commented on pull request #32: [DOXIATOOLS-73] Drop support for Converting Confluence documents

2022-12-30 Thread GitBox
kwin commented on PR #32: URL: https://github.com/apache/maven-doxia-converter/pull/32#issuecomment-1367815612 @michael-o @slachiewicz Given that there will be a new release for https://issues.apache.org/jira/browse/DOXIATOOLS-74 should we reopen and merge? -- This is an automated me

[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #202: [MENFORCER-435] Remove not needed maven-dependency-tree and maven-compat

2022-12-30 Thread GitBox
slawekjaranowski commented on PR #202: URL: https://github.com/apache/maven-enforcer/pull/202#issuecomment-1367813010 It is valid questions. I added comments on commit ... https://github.com/apache/maven-enforcer/commit/919fe02a0fe92a055a6e24dff04fb9c7618954f4 -- This is an aut

[jira] [Commented] (MRESOLVER-302) Introduce onSession close

2022-12-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653080#comment-17653080 ] ASF GitHub Bot commented on MRESOLVER-302: -- kwin commented on code in PR #232

[GitHub] [maven-resolver] kwin commented on a diff in pull request #232: [MRESOLVER-302] Introduce onSessionClose hooks

2022-12-30 Thread GitBox
kwin commented on code in PR #232: URL: https://github.com/apache/maven-resolver/pull/232#discussion_r1059306441 ## maven-resolver-api/src/main/java/org/eclipse/aether/RepositorySystem.java: ## @@ -302,4 +302,39 @@ List newResolutionRepositories( RepositorySystemSession sessio

[GitHub] [maven-enforcer] ajarmoniuk commented on pull request #202: [MENFORCER-435] Remove not needed maven-dependency-tree and maven-compat

2022-12-30 Thread GitBox
ajarmoniuk commented on PR #202: URL: https://github.com/apache/maven-enforcer/pull/202#issuecomment-1367811899 Can't see them anywhere. I only got a notification about new comments, but there were nowhere to be seen. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [maven-enforcer] ajarmoniuk commented on pull request #202: [MENFORCER-435] Remove not needed maven-dependency-tree and maven-compat

2022-12-30 Thread GitBox
ajarmoniuk commented on PR #202: URL: https://github.com/apache/maven-enforcer/pull/202#issuecomment-1367811069 > [@ajarmoniuk](https://github.com/ajarmoniuk) - can you check it, looks strange > I also afraid that IT test - require-release-dependencies check nothing - there is no depende

[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #202: [MENFORCER-435] Remove not needed maven-dependency-tree and maven-compat

2022-12-30 Thread GitBox
slawekjaranowski commented on PR #202: URL: https://github.com/apache/maven-enforcer/pull/202#issuecomment-1367809795 Which comments? I don't remember to remove something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Commented] (MNG-7655) rename Maven core's plexus-utils to more explicit artifactId

2022-12-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653070#comment-17653070 ] ASF GitHub Bot commented on MNG-7655: - hboutemy commented on PR #942: URL: https://gith

[GitHub] [maven] hboutemy commented on pull request #942: [MNG-7655] maven-plexus-utils and maven-plexus-utils-xml (xml-impl)

2022-12-30 Thread GitBox
hboutemy commented on PR #942: URL: https://github.com/apache/maven/pull/942#issuecomment-1367796459 oh, back to plexus-utils https://codehaus-plexus.github.io/plexus-utils/ vs maven-shared-utils https://maven.apache.org/shared/maven-shared-utils/ discussion I suppose we can split ma

[jira] [Commented] (MNG-7655) rename Maven core's plexus-utils to more explicit artifactId

2022-12-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653068#comment-17653068 ] ASF GitHub Bot commented on MNG-7655: - rmannibucau commented on PR #942: URL: https://g

[GitHub] [maven] rmannibucau commented on pull request #942: [MNG-7655] maven-plexus-utils and maven-plexus-utils-xml (xml-impl)

2022-12-30 Thread GitBox
rmannibucau commented on PR #942: URL: https://github.com/apache/maven/pull/942#issuecomment-1367794025 +1 for maven to ingest used plexus classes rather than working on plexus off radars for the long term (probably lazily, ie each time we need a change we rather import the lib instead of p

[jira] [Commented] (MNG-7655) rename Maven core's plexus-utils to more explicit artifactId

2022-12-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653067#comment-17653067 ] ASF GitHub Bot commented on MNG-7655: - hboutemy commented on PR #942: URL: https://gith

[GitHub] [maven] hboutemy commented on pull request #942: [MNG-7655] maven-plexus-utils and maven-plexus-utils-xml (xml-impl)

2022-12-30 Thread GitBox
hboutemy commented on PR #942: URL: https://github.com/apache/maven/pull/942#issuecomment-1367793268 yes, splitting Plexus' plexus-utils 4.0.0 https://github.com/codehaus-plexus/plexus-utils into plexus-xml + plexus-utils makes sense because AFAIK Maven core exports plexus-xml only, not

[jira] [Commented] (MNG-7655) rename Maven core's plexus-utils to more explicit artifactId

2022-12-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653065#comment-17653065 ] ASF GitHub Bot commented on MNG-7655: - hboutemy commented on code in PR #942: URL: http

[GitHub] [maven] hboutemy commented on a diff in pull request #942: [MNG-7655] maven-plexus-utils and maven-plexus-utils-xml (xml-impl)

2022-12-30 Thread GitBox
hboutemy commented on code in PR #942: URL: https://github.com/apache/maven/pull/942#discussion_r1059289711 ## maven-plexus-utils-xml/pom.xml: ## @@ -25,9 +25,10 @@ under the License. 4.0.0-alpha-4-SNAPSHOT - maven-xml-impl + maven-plexus-utils-xml - Maven XML Im

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

2022-12-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653064#comment-17653064 ] ASF GitHub Bot commented on MNG-7648: - pavelhoral opened a new pull request, #943: URL:

[GitHub] [maven] pavelhoral opened a new pull request, #943: [MNG-7648] Fix locationTracking in DefaultModelBuildingRequest copy constructor

2022-12-30 Thread GitBox
pavelhoral opened a new pull request, #943: URL: https://github.com/apache/maven/pull/943 This is backport / cherry-pick of #940. -- Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://